From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E0DB257AC8; Mon, 14 Apr 2025 10:04:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744625053; cv=none; b=MTV8GL63yWM+9F2dcLpdz+Jj9oXSXncllCh7kme5dCeWmV1Sky403JkGbaO5+8f4xIfyB0HgalaDUrsaUBwobZsr8HURslhNbsO49+ITrfVADTVnO/GN4apn4+3Z8QewqU0UJb3HcUHzLbYT8G58zqYQ0tDYcX6BvSSb4V1PXVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744625053; c=relaxed/simple; bh=WG9PaJz5Ij2QEAgSW+06zGhgRIzXBSAv3szM6gdSwso=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Q8bjHmrEotY82OxC2uXmZjthmlP78gY4Um5H3a4aCZQxcTeN5GByHnaYByUPQicMuoWXf3iwVap9Mk6pvtSDIafh1tePoMFgvOh8vOmaNP1mU+EUwTm6luOxcIAUOTPnHLd43SpK17/ALC/Vg6Fok1+P0/MAJjPs+ja0XqMWp0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=bl2kTNjO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="bl2kTNjO" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53E99mCR028993; Mon, 14 Apr 2025 10:03:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cRPLfy2uJJmtyi5JccFjWXd9aKPL46uk82fq4phKWro=; b=bl2kTNjO3qn75rEB f6Qvzz37v0xwPZhACqPCzw59OKE9nUPu6mUsHZyZ/D8acRvSehhhS9w+FFJRxjuS iGdrtrpmY6XZ8E0r4Vy+sDhoc5kac+ba/PQHv3lWZuk1ukHVTjXxh00YxvOIDZYR DrN8Bs01mY6MaS9KdpAfV5WtHVi5kbY2sxrUiZv8SODW6oN7IzXXwMwiuarRueZC 12cCMDZPQetVGcCakYSlu0QxLsrjt5ax1wWHHLCsAZORjzoSE+2bLgnXV5zkP26y IUHP4ZAWB4b5Ll3YF/BaPrCRTtnxRsKD4M4JRdFwY75XH/gbfBuCeQvixfSbR5JZ LqhmdA== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45yfs1462a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Apr 2025 10:03:54 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 53EA3r8J017866 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Apr 2025 10:03:53 GMT Received: from [10.204.66.137] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 14 Apr 2025 03:03:46 -0700 Message-ID: Date: Mon, 14 Apr 2025 15:33:43 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P To: Dmitry Baryshkov , Krzysztof Kozlowski CC: , , , , , , , , , , , , , , , , , , , , , , , , References: <20250311122445.3597100-4-quic_amakhija@quicinc.com> <20250312-calm-steadfast-cricket-fe9dd8@krzk-bin> <654d409e-2325-46e7-a064-ed9e64277e69@quicinc.com> <767e11cd-e338-4e00-a8e7-2e15f3da84b4@oss.qualcomm.com> <04d90c1b-1b73-4b6a-b7fc-351754fbb16b@kernel.org> Content-Language: en-US From: Ayushi Makhija In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Authority-Analysis: v=2.4 cv=P9I6hjAu c=1 sm=1 tr=0 ts=67fcdd8a cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=5Xq4O0xs5KunBNiUOD0A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: ZtTx-SX1Ic77Jw0-I654mLR5wxWoP_xL X-Proofpoint-ORIG-GUID: ZtTx-SX1Ic77Jw0-I654mLR5wxWoP_xL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-14_03,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 impostorscore=0 phishscore=0 suspectscore=0 mlxscore=0 spamscore=0 malwarescore=0 adultscore=0 priorityscore=1501 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504140072 Hi Krzysztof/Dmitry, On 4/10/2025 2:46 PM, Dmitry Baryshkov wrote: > On Thu, Apr 10, 2025 at 08:08:17AM +0200, Krzysztof Kozlowski wrote: >> On 09/04/2025 17:24, Dmitry Baryshkov wrote: >>> On 09/04/2025 09:07, Krzysztof Kozlowski wrote: >>>> On 08/04/2025 22:26, Dmitry Baryshkov wrote: >>>>>>>>>>> + - const: qcom,sa8775p-dsi-ctrl >>>>>>>>>>> + - const: qcom,mdss-dsi-ctrl >>>>>>>>>> >>>>>>>>>> Drop fallback >>>>>>>>>> >>>>>>>>> >>>>>>>>> Hi Krzysztof, >>>>>>>>> >>>>>>>>> I couldn't understand the meaning of "Drop fallback", could please elaborate it ? >>>>>>>> Look at SM8750 example on the lists. Keep only front compatible. >>>>>>> >>>>>>> Why? >>>>>> >>>>>> To make things simpler and shorter. >>>>> >>>>> I'd prefer consistency. Previous platforms use qcom,mdss-dsi-ctrl. >>>> Then you should have objected month(s) ago when Rob asked for dropping >>>> fallback and since then we consistently drop it. >>> >>> Well... It's still not merged. is it? >>> For SM8750 it kinda makes sense, because the clock handling is different >>> from all other current platforms. For the existing devices... I'm not >>> that sure. >> How does it differ? The clock handling does not matter - this is just >> select of schema for the child node. > > Ah.... I'm sorry, I misinterpreted the email. Yes, having only a single > compat here is perfectly fine. Please excuse me for the confusion. > Thanks, for the review. I will write single compatible string. Will update it in next patchset. + "^dsi@[0-9a-f]+$": + type: object + additionalProperties: true + properties: + compatible: + contains: + const: qcom,sa8775p-dsi-ctrl + Thanks, Ayushi