From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "zheng-yan.chen" <zheng-yan.chen@mediatek.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Jason-JH . Lin" <jason-jh.lin@mediatek.com>,
Singo Chang <singo.chang@mediatek.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 3/3] arm64: dts: Modify gamma compatible for mt8195
Date: Tue, 30 Aug 2022 12:13:18 +0300 [thread overview]
Message-ID: <e668a86b-f47b-bc42-440a-a74591827ccb@linaro.org> (raw)
In-Reply-To: <20220830063929.13390-4-zheng-yan.chen@mediatek.com>
On 30/08/2022 09:39, zheng-yan.chen wrote:
> Modify gamma compatible for mt8195.
Commit should explain why. "What" we all can easily see.
>
> Fixes: 16590e634f1d ("arm64: dts: mt8195: Add display node for vdosys0")
Your patchset is not bisectable and might cause ABI break. I doubt that
it matches the criteria of backports, especially that you did not
describe here bug being fixed.
Drop the tag and explain reasons for ABI break.
> Signed-off-by: zheng-yan.chen <zheng-yan.chen@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index a50ebb5d145f..d4110f6fac62 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -2022,7 +2022,7 @@
> };
>
> gamma0: gamma@1c006000 {
> - compatible = "mediatek,mt8195-disp-gamma", "mediatek,mt8183-disp-gamma";
> + compatible = "mediatek,mt8195-disp-gamma";
> reg = <0 0x1c006000 0 0x1000>;
> interrupts = <GIC_SPI 642 IRQ_TYPE_LEVEL_HIGH 0>;
> power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>;
Best regards,
Krzysztof
prev parent reply other threads:[~2022-08-30 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220830063929.13390-1-zheng-yan.chen@mediatek.com>
[not found] ` <20220830063929.13390-3-zheng-yan.chen@mediatek.com>
2022-08-30 7:47 ` [PATCH v2 2/3] drm/mediatek: Add gamma lut support for mt8195 AngeloGioacchino Del Regno
[not found] ` <20220830063929.13390-2-zheng-yan.chen@mediatek.com>
2022-08-30 7:48 ` [PATCH v2 1/3] dt-bindings: mediatek: Add gamma compatible " AngeloGioacchino Del Regno
2022-08-30 9:10 ` Krzysztof Kozlowski
[not found] ` <20220830063929.13390-4-zheng-yan.chen@mediatek.com>
2022-08-30 7:49 ` [PATCH v2 3/3] arm64: dts: Modify " AngeloGioacchino Del Regno
2022-08-30 9:14 ` Krzysztof Kozlowski
[not found] ` <b61776761eb0ab9a0b1dcf29d908e4bfd789d2ac.camel@mediatek.com>
2022-08-31 6:04 ` Krzysztof Kozlowski
2022-08-31 7:47 ` AngeloGioacchino Del Regno
2022-08-30 9:13 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e668a86b-f47b-bc42-440a-a74591827ccb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-jh.lin@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=singo.chang@mediatek.com \
--cc=zheng-yan.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).