From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated
Date: Fri, 9 Sep 2022 18:36:15 +0200 [thread overview]
Message-ID: <e67e888c-ba40-7e72-39d1-98d02416d8b8@linaro.org> (raw)
In-Reply-To: <20220909163416.1021551-2-bryan.odonoghue@linaro.org>
On 09/09/2022 18:34, Bryan O'Donoghue wrote:
> We've had some discongruity in the compatible string of the lpass for 8916
> for a while.
>
> Mark the old compat as deprecated. New SoC additions such as msm8936 and
> msm8939 should use the compat string "qcom,apq8016-lpass-cpu".
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> index ef18a572a1ff3..bb6f0c5dd4e8b 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> @@ -18,11 +18,13 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - qcom,lpass-cpu
> - - qcom,apq8016-lpass-cpu
> - - qcom,sc7180-lpass-cpu
> - - qcom,sc7280-lpass-cpu
> + oneOf:
> + - const: qcom,lpass-cpu
> + - const: qcom,apq8016-lpass-cpu
> + - const: qcom,sc7180-lpass-cpu
> + - const: qcom,sc7280-lpass-cpu
We talked and I gave you the expected code with enum. I also explained
why other schema (Odroid sound) is done differently. The code here is
correct, but I find more readable and common to use enum. Please make
these entries as enum.
> + - const: qcom,lpass-cpu-apq8016
> + deprecated: true
>
> reg:
> minItems: 1
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-09 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 16:34 [PATCH 0/1] Update apq8016 lpass-cpu compat string Bryan O'Donoghue
2022-09-09 16:34 ` [PATCH 1/1] ASoC: dt-bindings: Mark old binding qcom,cpu-lpass-apq8016 as deprecated Bryan O'Donoghue
2022-09-09 16:36 ` Krzysztof Kozlowski [this message]
2022-09-09 17:22 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e67e888c-ba40-7e72-39d1-98d02416d8b8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).