From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf2-f12.google.com (mail-lf2-f12.google.com [74.125.229.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BECC334E74D for ; Tue, 15 Sep 2026 14:04:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.204 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789481082; cv=none; b=Dq0FC8ateqgQPByyn8vzy9gpOdhEUkIisiD2i53s8semQhy7aJSpAUTbBe7KpAIEG6uxXom1FgaUuiK/ecIlsgY8Knm7/VFyuj/MntTbTOUwW9JBGgtyeGbAjl6td2sdHPZEOEqdPg7YwXNLopKBh8ZUlkzYlcygLceicoWVS8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789481082; c=relaxed/simple; bh=J9OGQHwLd5RQh6VgnwYcZJ1/tJctHZfW70ij/Hm6Nr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tOjoXtioGDqhFDSKD9D42EUshuiRItK5vVc0MPRRxmppChOPFJOhkTVA9Fxw3XdpzoFPWo9utaga87m1rUM0IbRl+FfaKT+e7lwyPtO5A+K9SkshIucOLGY8HCLI0rf10AXxk8wZmOKhwbD2F84Ho8UI+DOriYtjx1/U5fM5ajo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MhlnMHc9; arc=none smtp.client-ip=74.125.229.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MhlnMHc9" Received: by mail-lf2-f12.google.com with SMTP id 2adb3069b0e04-5b5e4f16c81so378041e87.2 for ; Tue, 15 Sep 2026 07:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789481078; x=1790085878; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7z0suvtQdygMfp5C2F1T6+DtNCb79uQkob7ja2atco0=; b=MhlnMHc9QqsoRD2RgxoIE1BY0710gtsrrTFU81/08B4zSMs8N5BuWC4zs5+UL4hDsA xKGnO+WIc3IOw0dEFrYDFkPmYEIf99amiuwC2MoqSUCdtHDIZABecQ39/l62CEXwGdLH +x+6XBJjhUWiL4676jm4lRE4rt/VO/GUqN6JMNn4iDZqxq5r54/tqyXuhSMuzpim9D1G IRz7v8b8sQmsM9AxIa8mctFrwAPowfTimGMtt9USiakv+zqlLSqTdOdLyGkvOM/qXPMx ja2ufwGw9Kd9m27cVnPlsdFw58nA2jv/RJizaHBP65XZRfr1KQX9h96krH4Vu+PA/arA kSaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789481078; x=1790085878; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7z0suvtQdygMfp5C2F1T6+DtNCb79uQkob7ja2atco0=; b=D6phyUNqMVUGI7cDK7ehkCjUXQLU9lozmODpjtmOQM76uN/ZQj04Rlws5+altm8aLu mQZtq9xaExaVybNmx+bxG+DtVrGAWJTLu70ZPrI716hvKBUsmkTz9HTlh/5g7ocu2YFV n29nhbgm5DSbBNmmronebcw40kj1xRJ946iSi4/Z+59nEOQlUKazrwtOB/MgPtNG41Jr fITfbbybFJ9n9HdriVwHE6015IF1A7f0cNod+xjNPo9JUHsQ4bPEO8f8FnwGJl3hT3KH dPAOIl8ZCWURiZ2d8yXoU7A0CKQ7S4P+6CoRL7U+ZOGOoVHJlyP8twxXKazrr89ibm+l rt2Q== X-Forwarded-Encrypted: i=1; AKwUvBwZlku0GkZNBmAQyHC25kUn37ZaxRnWDGywdaUa7/xBcdXL2xsvQsZNERWyywPW6VX5D9YnxLR4wVV1@vger.kernel.org X-Gm-Message-State: AFuF++lN5RMHUPx125m7vrBxdm7x5lBlE0CeY1VhVn8QehYXD9mBHTug UyDsjjgqU97jM3NeoWRBp/gIj4QJbdpYZWEqGu63uIvT4f1GgzOdqH48aSPK2HMPBE5TXA== X-Gm-Gg: AYBFou0pd41rSY66aaVgduAArqkpHmwHjT6i3LTevofs5Fl2oWrh2D2/Et/eUyCtBkK LKLUZZvdBX2Ygg+sSSvr2/Ogh4OswPqPFt6MSSv5tM40ktztw0ORyedWO6/AI/glWGzbkvMBQUF 6ryKPypUsb1w9x5JtOFTNrko+NNYwf5zqSVAdp+c1Hs8kqne5pm9RvH7bOlO5f8nWsScQ6oIkaD jrvXvXbmLuahomyuA+LErCWyT3KnmgPjfI9D8o9PKLeLIKy2PMZvsxrja+A8rbHUwQahU+SGGVt BWfyl+xl9oOlzcFkN8g3S6iGREWjnc9RjzdsqrM7DxxVtqY0pryJV8724JQUWGkRiWXQHd83RkG PxA2oRibf5YU9hFeecHjOPr88kH6Yn2bu/L52v0VWIblPrF99JTqbQPxYcGece62lrc8TY244vM jNn/d+D+zrO0Jq29rK6gK+pOKdQugn4HD/0WNIsk3hKWzMZakMHAityh4iUQ9npEQmYs6bS/Jz5 4KiADPRnkmwUItw X-Received: by 2002:a17:907:3ea7:b0:c28:e01d:1d08 with SMTP id a640c23a62f3a-c29d7a166d7mr87629266b.49.1789480709299; Tue, 15 Sep 2026 06:58:29 -0700 (PDT) Received: from [10.43.61.105] ([185.94.190.187]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2965c4e3d8sm608169766b.9.2026.09.15.06.58.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Sep 2026 06:58:28 -0700 (PDT) Message-ID: Date: Tue, 15 Sep 2026 15:58:26 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] clk: Add gpio-locked fixed clock driver To: Jerome Brunet , Vyacheslav Yurkov via B4 Relay , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Brian Masney , Brian Masney , Jerome Brunet , Jyri Sarha Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Vyacheslav Yurkov References: <20260915-feature-clock-guard-v5-0-42ab5dc3a6aa@bruker.com> <20260915-feature-clock-guard-v5-2-42ab5dc3a6aa@bruker.com> <1j33vaesh7.fsf@starbuckisacylon.baylibre.com> Content-Language: en-US From: Vyacheslav Yurkov In-Reply-To: <1j33vaesh7.fsf@starbuckisacylon.baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15.09.2026 12:09, Jerome Brunet wrote: > On mar. 15 sept. 2026 at 09:27, Vyacheslav Yurkov via B4 Relay wrote: > >> From: Vyacheslav Yurkov >> >> A gpio-locked clock exposes a clock, which status is determined by a >> GPIO signal. The common use-case is a FPGA-assisted clocking design >> where peripheral clocks are generated by FPGA PLLs that are outside >> CPU control, with clock-valid/PLL-lock status exposed through GPIO signals. >> Consumers can use the output clock to wait until the input clock is locked >> and only then initialize dependent peripherals. >> > > We already have gpio gate driver in drivers/clk/clk-gpio.c > > It would be much better if you could just extend that one that take > optionally take a clock input like you do here. It is a bit more than that. The gated clock requires "enable-gpios" property, while gpio-locked clock needs "locked-gpios". Technically I could re-use the "enable-gpios", but that might lead to a confusion, because semantically they are used for different purpose. Do you think the extension of clk-gpio.c would be still better in this case? >> Signed-off-by: Vyacheslav Yurkov >> --- >> drivers/clk/Makefile | 1 + >> drivers/clk/clk-gpio-locked.c | 169 ++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 170 insertions(+) >> >> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile >> index b18af485d7f0..b904f292d683 100644 >> --- a/drivers/clk/Makefile >> +++ b/drivers/clk/Makefile >> @@ -46,6 +46,7 @@ obj-$(CONFIG_CLK_FD_KUNIT_TEST) += clk-fractional-divider_test.o >> obj-$(CONFIG_COMMON_CLK) += clk-gpio.o >> ifeq ($(CONFIG_OF), y) >> obj-$(CONFIG_COMMON_CLK) += clk-conf.o >> +obj-$(CONFIG_COMMON_CLK) += clk-gpio-locked.o >> endif >> >> # KUnit specific helpers >> diff --git a/drivers/clk/clk-gpio-locked.c b/drivers/clk/clk-gpio-locked.c >> new file mode 100644 >> index 000000000000..b648f8763922 >> --- /dev/null >> +++ b/drivers/clk/clk-gpio-locked.c >> @@ -0,0 +1,169 @@ >> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +/* >> + * Clock Controller Guard Driver >> + * >> + * Copyright 2026 Bruker Corporation >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +/** >> + * struct gpio_locked_clk_priv - private state for the whole driver >> + * @dev: platform device >> + * >> + * @input_clk input clock >> + * @gpios: input GPIO descriptor >> + * >> + * @output_hw_clk: output clock HW descriptor >> + * @output_clock_name: output clock name >> + */ >> +struct gpio_locked_clk_priv { >> + struct device *dev; >> + >> + struct clk *input_clk; >> + struct gpio_desc *gpios; >> + >> + struct clk_hw output_hw_clk; >> + const char *output_clock_name; >> +}; >> + >> +#define to_gpio_locked_clk_priv(_hw) \ >> + container_of(_hw, struct gpio_locked_clk_priv, output_hw_clk) >> + >> +static int gpio_locked_clk_is_enabled(struct clk_hw *hw) >> +{ >> + struct gpio_locked_clk_priv *priv = to_gpio_locked_clk_priv(hw); >> + >> + int data = gpiod_get_value(priv->gpios); >> + >> + if (data < 0) { >> + dev_err(priv->dev, "Failed to get data gpio val: %d\n", >> + data); >> + return data; >> + } else if (!data) { >> + dev_warn(priv->dev, "GPIO is not ready"); >> + return -EBUSY; >> + } >> + >> + return 0; >> +} >> + >> +/* We can't enable the clock, but the Common Clock Framework calls only >> + * enable() not is_enabled() >> + */ >> +static int gpio_locked_clk_enable(struct clk_hw *hw) >> +{ >> + return gpio_locked_clk_is_enabled(hw); >> +} >> + >> +/* We have to implement it, but we are not going to control >> + * parent clock selection >> + */ >> +static u8 gpio_locked_clk_get_parent(struct clk_hw *hw) >> +{ >> + return 0; >> +} >> + >> +static const struct clk_ops gpio_locked_clk_ops = { >> + .enable = gpio_locked_clk_enable, >> + .is_enabled = gpio_locked_clk_is_enabled, >> + .get_parent = gpio_locked_clk_get_parent, >> +}; >> + >> +static int gpio_locked_clk_parse_outputs(struct gpio_locked_clk_priv *priv) >> +{ >> + struct device *dev = priv->dev; >> + struct device_node *np = dev->of_node; >> + int ret; >> + >> + of_property_read_string_index(np, "clock-output-names", 0, >> + &priv->output_clock_name); >> + >> + if (!priv->output_clock_name) >> + priv->output_clock_name = dev_name(priv->dev); >> + >> + priv->output_hw_clk.init = >> + CLK_HW_INIT_FW_NAME(priv->output_clock_name, >> + __clk_get_name(priv->input_clk), >> + &gpio_locked_clk_ops, 0); >> + >> + ret = devm_clk_hw_register(dev, &priv->output_hw_clk); >> + if (ret) { >> + dev_err(dev, "failed to register output clk'%s': %d\n", >> + priv->output_clock_name, ret); >> + return ret; >> + } >> + >> + dev_info(priv->dev, "Output clock '%s' registered\n", priv->output_clock_name); >> + >> + return 0; >> +} >> + >> +static int gpio_locked_clk_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + struct gpio_locked_clk_priv *priv; >> + int ret; >> + >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); >> + if (!priv) >> + return -ENOMEM; >> + >> + priv->dev = dev; >> + platform_set_drvdata(pdev, priv); >> + >> + priv->input_clk = devm_clk_get_enabled(priv->dev, NULL); >> + if (IS_ERR(priv->input_clk)) >> + return dev_err_probe(priv->dev, PTR_ERR(priv->input_clk), >> + "Failed to get locked fixed clock, not yet ready\n"); > > In your use case it might be fixed, but nothing says it is in general > Good point, thanks.