From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6E6A18B0A for ; Sun, 5 Apr 2026 00:05:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775347538; cv=none; b=uvBcoG4wqXD7HDaNAvVSpBywf2Wk+03xGX6K1LdSgjrfXL7+NutUBEeT+2dQMo4kY19ECDCT5CAeYaRanCYBb2jMBoTWQZLO+R0jUqaUScdYe9BYyySbol85fd0S0K+j5U1begC0ZuW2SgkTkOye4jl7jURJ2OIJnzI11bP2Zk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775347538; c=relaxed/simple; bh=eD839NDE5H9CmiRueWDchOB7qjzUfCxB7uRTtrbIfqM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AenuDmSguVzoM10xF6/GeWg1QSkD/DLYoVwclVUrtxIoJJTQ202MunkLFzWMQp5pJczY56oSzw/PkgeLltK12w4DEb/SlfOoEY6f+5QqRTgbyNaBvP+qh5fUFwiWNCXOVlCi4admls+o+p62BZZbVuif1EKCs19nDkvlXVg42Ps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KSc9op4s; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KSc9op4s" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48374014a77so38408165e9.3 for ; Sat, 04 Apr 2026 17:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775347535; x=1775952335; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F6niN5rHkfj9+STb1B7vVxgC82p/xl+UfQX44Fsubjc=; b=KSc9op4syQgcWg5K/WIYliDjKhLBUE1VZfpebjg67BwohCmo8TlFKJ5/o5lnfRg/+9 MPSfKq707P4/9mVGWAclfd8T523hI9L/E1TzdSFo8ECHak34kXwylZr0kArCWKwoP4Gi DDtzXja/n9GRKjg80QGf2G9pZi1BzYzqg0FTUTsMvwBoJWWGFqgvsIK6wB1TfvXWSQAn zFRw8XUoDR1zjZATC+piFhooZ+jdCg72Hi1Fn/F1KSaF1MyXT/Dh/o8fPs1bN3Fze9IB 10DO5cXzBPnLEI9bOFJ6WS0B+KNwUSGKlfXLD3G9D7OgXYm4cf9TDR9C0TfUdzllJz8M p5Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775347535; x=1775952335; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=F6niN5rHkfj9+STb1B7vVxgC82p/xl+UfQX44Fsubjc=; b=aEGgG35Xf0LUa5SXoR4wXiRYGISvWsTjqZwMurAdsB/JWMBpmzjgZL90w4YeMwIDXr ksv2n5x86YPNi6hdIKw4EvKGyVSQO7XVlO5wt3iGy1xIehtlfZu7+OMpsPDsdsDFjxzK L+jEleM5n12XkNTnDrM+TqNBH1xEENB0kc1Y/6MlaIAtJI9X+ucR21Z57ZnJ4I6xXE3M b9Ey9LPhJIbogJlRtZ+fNVOI0pI+sRMae4EjGS95Z/71J3x4DfZjlw6OVd4u+xVSXjvd Y6diIb2q7Aq+sb1Icij2NIjaSJA03Bv8fjYQ79iCNJI3cVHBo2DSCCnn/Gh7wSl8s9Tn TTiQ== X-Forwarded-Encrypted: i=1; AJvYcCV2peSr/L23v3Td4gbOa0Zq6G1ExxbaJqNZHIdv7183cLZFUYApRn4h/awpipvHsdNQtG48SyQlh64B@vger.kernel.org X-Gm-Message-State: AOJu0Yzh7QcrchxO67N7YvSK43EuyH6AvpckG8IX3JlPOJWUSCEhTK+R w67cfAA7aj2ZzHxAM7tkR61qVqc5NLBsL3RTJY0Qp+qRYhqj1GyFp7bqdrgl9yo0Je8= X-Gm-Gg: AeBDieuloThwWyIyjYoeVgTivHXfV74WC7AvAvaL+o6P3T95HYmqOkjsyI/lKhAEQ5Y rSMTqRW3CrOR0l92ZBm/cQ9k+HlLvn65c1NPKHNyi4HLasLNC7bMID5ZePbL/bs/XKB4Y3gM5Yq yTN4e/hb0n5X5a1C1DnO3w/b3khraO/f7BCi2nWjhg8hPYNYVEI8Lo+qCOPFN02rVQVCFxvEIkj jJ6lsaovkwUOb0WRpUmohHys0YkfMZXhfZMtQ2tjKH9AWRdbzFfEF/1hBLeGx4ZSDXnobavfFXT JpabkdExuk4nLvVjSoMh/Qy3kuP45ds7iMLz9OmIgbveTvwJ/vYbNImrFd9+7iIzXT8a38pUcSA A0rhjsvm0taGgQdf7D+FWt74w5hTCwYhhUeoG5gWBlxk+9M6EbzPP0GdaYH453rwzrxiwx9ZMFQ vCskgTg7wSShfg3alCl54hMc2zzXyUK+FIE3Q= X-Received: by 2002:a05:6000:2c0c:b0:439:b59e:5e65 with SMTP id ffacd0b85a97d-43d2927ffe4mr11556544f8f.6.1775347535109; Sat, 04 Apr 2026 17:05:35 -0700 (PDT) Received: from [192.168.0.35] ([109.77.125.194]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4d27a8sm28693271f8f.17.2026.04.04.17.05.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Apr 2026 17:05:34 -0700 (PDT) Message-ID: Date: Sun, 5 Apr 2026 01:05:33 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] dt-bindings: platform: introduce EC for Dell XPS 13 9345 To: Aleksandrs Vinarskis , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, laurentiu.tudor1@dell.com, Abel Vesa , Tobias Heider , Val Packett , Krzysztof Kozlowski References: <20260404-dell-xps-9345-ec-v2-0-c977c3caa81f@vinarskis.com> <20260404-dell-xps-9345-ec-v2-1-c977c3caa81f@vinarskis.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20260404-dell-xps-9345-ec-v2-1-c977c3caa81f@vinarskis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/04/2026 13:55, Aleksandrs Vinarskis wrote: > Add bindings for Embedded Controller (EC) in Dell XPS 13 9345 (platform > codename 'tributo'). It may be partially or fully compatible with EC > found in Snapdragon-based Dell Latitude, Inspiron ('thena'). > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Aleksandrs Vinarskis > --- > .../embedded-controller/dell,xps13-9345-ec.yaml | 91 ++++++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 96 insertions(+) > > diff --git a/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..e14dbf2f1a6af8cc7511890fbef08c6c717c0aa6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml I believe the part name of this embedded controller is the "mec5200" so instead of calling it dell,xps13-9345-ec suggest "dell,mec5200" > @@ -0,0 +1,91 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/embedded-controller/dell,xps13-9345-ec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Dell XPS 13 9345 Embedded Controller > + > +maintainers: > + - Aleksandrs Vinarskis > + > +description: > + The Dell XPS 13 9345 has an Embedded Controller (EC) which handles thermal > + and power management. It is communicating with SoC over multiple i2c busses. > + Among other things, it handles fan speed control, thermal shutdown, peripheral > + power supply including trackpad, touch-row, display. For these functions, it > + requires frequently updated thermal readings from onboard thermistors. > + > +properties: > + compatible: > + const: dell,xps13-9345-ec Ditto the compat - name it after the IC not the laptop its a "mec5200" or "mec5200-ec" - I suspect the -ec postfix is a tautology the ec bit in "mec" probably captures. > + > + reg: > + const: 0x3b > + > + interrupts: > + maxItems: 1 > + > + io-channels: > + description: > + ADC channels connected to the 7 onboard thermistors on PMK8550. > + EC requires frequent thermal readings of these channels to perform > + automated fan speed control. > + items: > + - description: ADC channel for sys_therm0 > + - description: ADC channel for sys_therm1 > + - description: ADC channel for sys_therm2 > + - description: ADC channel for sys_therm3 > + - description: ADC channel for sys_therm4 > + - description: ADC channel for sys_therm5 > + - description: ADC channel for sys_therm6 > + > + io-channel-names: > + items: > + - const: sys_therm0 > + - const: sys_therm1 > + - const: sys_therm2 > + - const: sys_therm3 > + - const: sys_therm4 > + - const: sys_therm5 > + - const: sys_therm6 > + > +required: > + - compatible > + - reg > + - interrupts > + - io-channels > + - io-channel-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + embedded-controller@3b { > + compatible = "dell,xps13-9345-ec"; > + reg = <0x3b>; > + interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_LOW>; > + > + io-channels = <&pmk8550_vadc PM8350_ADC7_GPIO3_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_GPIO4_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_AMUX_THM1_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_AMUX_THM2_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_AMUX_THM3_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_AMUX_THM4_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_AMUX_THM5_100K_PU(1)>; > + io-channel-names = "sys_therm0", > + "sys_therm1", > + "sys_therm2", > + "sys_therm3", > + "sys_therm4", > + "sys_therm5", > + "sys_therm6"; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 96e0781f2201b41b976dfa69efd44d62c4ff0058..a5d175559f4468dfe363b319a1b08d3425f4d712 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7236,6 +7236,11 @@ S: Maintained > F: Documentation/ABI/testing/sysfs-class-firmware-attributes > F: drivers/platform/x86/dell/dell-wmi-sysman/ > > +DELL XPS EMBEDDED CONTROLLER DRIVER > +M: Aleksandrs Vinarskis > +S: Maintained > +F: Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml > + > DELTA AHE-50DC FAN CONTROL MODULE DRIVER > M: Zev Weiss > L: linux-hwmon@vger.kernel.org >