From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: Device tree BSP Date: Sat, 4 Jul 2009 20:32:58 +0200 Message-ID: References: <4A49F472.3030902@petalogix.com> <20090704181837.6224D13E8056@mail113-va3.bigfish.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1289017642==" Return-path: In-Reply-To: <20090704181837.6224D13E8056-4w96H/B/PjLzgBzxlff1BqQXxVRGGlT3@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: Stephen Neuendorffer Cc: John Linn , David DeBonis , devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, John Williams List-Id: devicetree@vger.kernel.org --===============1289017642== Content-Type: multipart/alternative; boundary=0015174c0eca86be63046de580a2 --0015174c0eca86be63046de580a2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit 2009/7/4 Stephen Neuendorffer > > > I'm not exactly sure what you're trying to do here, but it doesn't look > right to me. > In particular, why would I have to have a separate core for these > functions? > Furthermore, I'm sure there must be some generic mechanisms that can/should > be used for these kind of things. > In general, we shouldn't reinvent the wheel here.. > > CC'ing devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, which is really the best place to > ask such questions. Yes, I know - I talked with Grant about too. And I found a solution for heartbeat. We have there one small problem that led-gpio heartbeat trigger starts when driver is ready (long time from the system start) Current heartbeat works when timer/intc is setup. That big time gap between current - proposed solution I don't like and I want to remove it. I am doing different work now and I'll solve it later. Thanks, Michal > > > Steve > > -----Original Message----- > From: Michal Simek [mailto:michal.simek-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org] > Sent: Tue 6/30/2009 4:18 AM > To: John Williams; John Linn; David DeBonis; Stephen Neuendorffer > Subject: Device tree BSP > > Hi all, > > I need to talk to you about names for at least one new compatible > property name. > It is for heartbeat led gpio and (not important now) reset gpio. > Currently linux kernel takes > first gpio for heartbeat led which needn't be led gpio that's why we > need to specify which gpio > node is for it. I think we can't used it aliases because in case you > enable gpio linux driver > heartbeat go away because that node had gpio compatible property. > > Our proposed compatible names are xlnx,heartbeat-gpio-1.00.a and > xlnx,reset-gpio-1.00.a > which replaced all gpio compatible properties. Below are two parts of > fragments. > > LEDs_8Bit: gpio@42000000 { > compatible = "xlnx,heartbeat-gpio-1.00.a"; > reg = < 0x42000000 0x10000 >; > xlnx,all-inputs = <0x0>; > > Push_Buttons: gpio@42600000 { > compatible = "xlnx,reset-gpio-1.00.a"; > interrupt-parent = <&xps_intc_0>; > interrupts = < 4 2 >; > > If you agree with heartbeat name, I will change it in linux kernel code. > > Thanks, > Michal > > -- > Michal Simek, Ing. (M.Eng) > PetaLogix - Linux Solutions for a Reconfigurable World > w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663 > > > > > > This email and any attachments are intended for the sole use of the named > recipient(s) and contain(s) confidential information that may be > proprietary, privileged or copyrighted under applicable law. If you are not > the intended recipient, do not read, copy, or forward this email message or > any attachments. Delete this email message and any attachments immediately. > > -- Michal Simek, Ing. (M.Eng) PetaLogix - Linux Solutions for a Reconfigurable World w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663 --0015174c0eca86be63046de580a2 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

2009/7/4 Stephen Neuendorffer <stephen.neu= endorffer-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>


I'm not exactly sure what you're trying to do here, but it doesn= 9;t look right to me.
In particular, why would I have to have a separate core for these functions= ?
Furthermore, I'm sure there must be some generic mechanisms that can/sh= ould be used for these kind of things.
In general, we shouldn't reinvent the wheel here..

CC'ing devicetree-disc= uss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, which is really the best place to ask such questions.


Yes, I know - I talked with Grant about too. And I = found a solution for heartbeat.
We have there one small problem that led-gpio heartbeat trigger starts when= driver is ready (long time from the system start)
Current heartbeat works when timer/intc is setup. That big time gap between= current - proposed solution I don't like and
I want to remove it.
I am doing different work now and I'll solve it later.

Thanks,
Michal
=A0

-----Original Message-----
From: Michal Simek [mailto:mi= chal.simek-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org]
Sent: Tue 6/30/2009 4:18 AM
To: John Williams; John Linn; David DeBonis; Stephen Neuendorffer
Subject: Device tree BSP

Hi all,

I need to talk to you about names for at least one new compatible
property name.
It is for heartbeat led gpio and (not important now) reset gpio.
Currently linux kernel takes
first gpio for heartbeat led which needn't be led gpio that's why w= e
need to specify which gpio
node is for it. I think we can't used it aliases because in case you enable gpio linux driver
heartbeat go away because that node had gpio compatible property.

Our proposed compatible names are xlnx,heartbeat-gpio-1.00.a and
xlnx,reset-gpio-1.00.a
which replaced all gpio compatible properties. Below are two parts of
fragments.

LEDs_8Bit: gpio@42000000 {
=A0 =A0compatible =3D "xlnx,heartbeat-gpio-1.00.a";
=A0 =A0reg =3D < 0x42000000 0x10000 >;
=A0 =A0xlnx,all-inputs =3D <0x0>;

Push_Buttons: gpio@42600000 {
=A0 =A0compatible =3D "xlnx,reset-gpio-1.00.a";
=A0 =A0interrupt-parent =3D <&xps_intc_0>;
=A0 =A0interrupts =3D < 4 2 >;

If you agree with heartbeat name, I will change it in linux kernel code.
Thanks,
Michal

--
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com= p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663





This email and any attachment= s are intended for the sole use of the named recipient(s) and contain(s) co= nfidential information that may be proprietary, privileged or copyrighted u= nder applicable law. If you are not the intended recipient, do not read, co= py, or forward this email message or any attachments. Delete this email mes= sage and any attachments immediately.




--
Michal Sime= k, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable Worldw: www.petalogix.com p: +61-7-30= 090663,+42-0-721842854 f: +61-7-30090663
--0015174c0eca86be63046de580a2-- --===============1289017642== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org https://ozlabs.org/mailman/listinfo/devicetree-discuss --===============1289017642==--