From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC2BC61DA4 for ; Wed, 15 Feb 2023 01:28:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233601AbjBOB2G (ORCPT ); Tue, 14 Feb 2023 20:28:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233472AbjBOB2F (ORCPT ); Tue, 14 Feb 2023 20:28:05 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E331A1BA; Tue, 14 Feb 2023 17:28:03 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 7D07E24E20A; Wed, 15 Feb 2023 09:27:56 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 15 Feb 2023 09:27:56 +0800 Received: from [192.168.1.100] (183.27.97.168) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 15 Feb 2023 09:27:55 +0800 Message-ID: Date: Wed, 15 Feb 2023 09:27:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 2/4] dt-bindings: phy: Add starfive,jh7110-dphy-rx Content-Language: en-US To: Krzysztof Kozlowski , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel CC: Jack Zhu , , , , References: <20230210061713.6449-1-changhuang.liang@starfivetech.com> <20230210061713.6449-3-changhuang.liang@starfivetech.com> <3fc07187-f5a0-86d1-a0fd-ba18a2baf555@linaro.org> <80d16935-dad6-8087-c1b2-1d5b1c3f738e@linaro.org> From: Changhuang Liang In-Reply-To: <80d16935-dad6-8087-c1b2-1d5b1c3f738e@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.168] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/2/14 15:49, Krzysztof Kozlowski wrote: > On 14/02/2023 04:07, Changhuang Liang wrote: >> >> OK, will drop quotes >> >>>> + items: >>>> + items: >>>> + - description: phandle of AON SYSCON >>>> + - description: register offset >>>> + description: The register of dphy rx driver can be configured >>>> + by AON SYSCON in this property. >>> >>> Can be? So does not have to? But you made it a required property.... >>> >> >> Maybe I described it wrong. >> I will change to: >> description: The power of dphy rx can be configured by AON SYSCON >> in this property. >> It is like AON SYSCON is the power switch of the dphy rx, it is necessary to >> configure the AON SYSCON register, so I made it a required property. > > Then do not use "can be". Can is optional: I can jump but I don't have > to. :) > OK, "can be" will be changed to "is". Best Regards, Changhuang Liang