public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	Prathamesh Shete <pshete@nvidia.com>
Subject: Re: [PATCH 1/2] dt-bindings: tegra: pmc: Update aotag as an optional aperture
Date: Tue, 18 Nov 2025 15:22:21 +0100	[thread overview]
Message-ID: <e6c73b8a-6a73-488e-8520-1df30ec1006b@kernel.org> (raw)
In-Reply-To: <d7b5fa60-c6ec-45f2-8bc3-ba79dccf6c5d@nvidia.com>

On 18/11/2025 15:11, Jon Hunter wrote:
> 
> On 18/11/2025 13:08, Krzysztof Kozlowski wrote:
>> On 18/11/2025 12:11, Jon Hunter wrote:
>>>        then:
>>>          properties:
>>>            reg-names:
>>> @@ -184,7 +187,7 @@ examples:
>>>                  <0x0c370000 0x10000>,
>>>                  <0x0c380000 0x10000>,
>>>                  <0x0c390000 0x10000>;
>>> -        reg-names = "pmc", "wake", "aotag", "scratch";
>>> +        reg-names = "pmc", "wake", "scratch", "scratch";
>>>            nvidia,invert-interrupt;
>>>    
>>>            sdmmc1_3v3: sdmmc1-3v3 {
>>>
>>>
>>> The above did not trigger any errors even though I introduced
>>> an error in the example. Anything I am missing?
>>
>> You are right - dtschema does not work here. That's a bug, because it
>> should and we already rely on that for many other bindings. You can add
>> "uniqueItems: true" as workaround, but we should fix it in dtschema, so
>> you can go with my approach anyway.
> 
> Thanks. Looks like I can't add 'uniqueItems' to reg-names ...
> 
> Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.yaml: properties:reg-names: Additional properties are not allowed ('uniqueItems' was unexpected)
>      	from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
> 
> Would it be OK to go with your proposal for now without
> the uniqueItems?

Yes, that syntax should work anyway.

Best regards,
Krzysztof

  reply	other threads:[~2025-11-18 14:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 16:17 [PATCH 1/2] dt-bindings: tegra: pmc: Update aotag as an optional aperture Jon Hunter
2025-11-14 16:17 ` [PATCH 2/2] soc/tegra: pmc: don't fail if "aotag" is not present Jon Hunter
2025-11-15 12:25 ` [PATCH 1/2] dt-bindings: tegra: pmc: Update aotag as an optional aperture Krzysztof Kozlowski
2025-11-18 10:08   ` Jon Hunter
2025-11-18 10:38     ` Krzysztof Kozlowski
2025-11-18 11:11       ` Jon Hunter
2025-11-18 13:08         ` Krzysztof Kozlowski
2025-11-18 14:11           ` Jon Hunter
2025-11-18 14:22             ` Krzysztof Kozlowski [this message]
2025-11-18 14:20           ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6c73b8a-6a73-488e-8520-1df30ec1006b@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=pshete@nvidia.com \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox