Devicetree
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>, devicetree@vger.kernel.org
Cc: Ram Chandrasekar <rkumbako@codeaurora.org>,
	ilina@codeaurora.org, Zhang Rui <rui.zhang@intel.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: of: Allow selection of thermal governor in DT
Date: Mon, 5 Mar 2018 22:11:12 +0100	[thread overview]
Message-ID: <e6c78c81-f18d-c811-925d-5b1dd427fb65@linaro.org> (raw)
In-Reply-To: <3b80853abb45a9e067cf7a16754b07bb67712457.1520274879.git.amit.kucheria@linaro.org>

On 05/03/2018 19:36, Amit Kucheria wrote:
> From: Ram Chandrasekar <rkumbako@codeaurora.org>
> 
> There is currently no way for the governor to be selected for each thermal
> zone in devicetree. This results in the default governor being used for all
> thermal zones even though no such restriction exists in the core code.
> 
> Add support for specifying the thermal governor to be used for a thermal
> zone in the devicetree. The devicetree config should specify the governor
> name as a string that matches any available governors. If not specified, we
> maintain the current behaviour of using the default governor.
> 
> Signed-off-by: Ram Chandrasekar <rkumbako@codeaurora.org>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

Why not create a kernel parameter (eg. thermal.governor=) ? So everyone
can gain benefit of this feature. And in order to specify that from the
DT, add the 'chosen' node and bootargs with the desired kernel parameter?




-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  parent reply	other threads:[~2018-03-05 21:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1520274879.git.amit.kucheria@linaro.org>
2018-03-05 18:36 ` [PATCH] thermal: of: Allow selection of thermal governor in DT Amit Kucheria
2018-03-05 20:08   ` Rob Herring
2018-03-06  5:38     ` Amit Kucheria
2018-03-05 21:11   ` Daniel Lezcano [this message]
2018-03-06  5:48     ` Amit Kucheria
2018-03-06 15:43       ` Daniel Lezcano
2018-03-06 12:32   ` Sudeep Holla
2018-03-07 10:59     ` Amit Kucheria
2018-03-08  4:49       ` Viresh Kumar
2018-03-08  5:35         ` Amit Kucheria
2018-03-08  5:42           ` Viresh Kumar
2018-03-08 12:41       ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6c78c81-f18d-c811-925d-5b1dd427fb65@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=amit.kucheria@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=edubezval@gmail.com \
    --cc=ilina@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rkumbako@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox