From: Marc Zyngier <maz@kernel.org>
To: "Biwen Li (OSS)" <biwen.li@oss.nxp.com>
Cc: linux@rasmusvillemoes.dk, shawnguo@kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
Leo Li <leoyang.li@nxp.com>, "Z.q. Hou" <zhiqiang.hou@nxp.com>,
tglx@linutronix.de, jason@lakedaemon.net,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiafei Pan <jiafei.pan@nxp.com>, Xiaobo Xie <xiaobo.xie@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v2 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt
Date: Tue, 27 Oct 2020 10:43:16 +0000 [thread overview]
Message-ID: <e6cd6eecb0221742548e657faf211733@kernel.org> (raw)
In-Reply-To: <HE1PR0401MB2444AA759104F4A34F91B61F8F160@HE1PR0401MB2444.eurprd04.prod.outlook.com>
On 2020-10-27 10:35, Biwen Li (OSS) wrote:
>>
>> On 2020-10-27 04:46, Biwen Li wrote:
>> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>> >
>> > Add an new IRQ chip declaration for LS1043A and LS1088A
>> > - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A.
>> > SCFG_INTPCR[31:0]
>> > of these SoCs is stored/read as SCFG_INTPCR[0:31] defaultly(bit
>> > reverse)
>> > - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA
>> >
>> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
>>
>> You clearly couldn't be bothered to read what I wrote in my earlier
>> replies. I'm
>> thus ignoring this series...
> Okay, got it.
>>
>> > ---
>> > Change in v2:
>> > - add despcription of bit reverse
>> > - update copyright
>> >
>> > drivers/irqchip/irq-ls-extirq.c | 10 +++++++++-
>> > 1 file changed, 9 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/irqchip/irq-ls-extirq.c
>> > b/drivers/irqchip/irq-ls-extirq.c index 4d1179fed77c..9587bc2607fc
>> > 100644
>> > --- a/drivers/irqchip/irq-ls-extirq.c
>> > +++ b/drivers/irqchip/irq-ls-extirq.c
>> > @@ -1,5 +1,8 @@
>> > // SPDX-License-Identifier: GPL-2.0
>> > -
>> > +/*
>> > + * Author: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>> > + * Copyright 2020 NXP
>>
>> ... specially when you keep attributing someone else's copyright to
>> NXP.
> Then I don't know how to add the copyright, any suggestions?
Simple. You don't add anything. NXP's copyright doesn't apply to this
file before this patch, and your changes are so trivial that they don't
really warrant a mention. Furthermore, the git history already keeps
track
of who did what.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-10-27 10:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 4:46 [v2 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt Biwen Li
2020-10-27 4:46 ` [v2 02/11] arm64: dts: ls1043a: add DT node for external interrupt lines Biwen Li
2020-10-27 4:46 ` [v2 03/11] arm64: dts: ls1046a: " Biwen Li
2020-10-27 4:46 ` [v2 04/11] arm64: dts: ls1046ardb: Add interrupt line for RTC node Biwen Li
2020-10-27 4:46 ` [v2 05/11] arm64: dts: ls1088a: add DT node for external interrupt lines Biwen Li
2020-10-27 4:46 ` [v2 06/11] arm64: dts: ls1088ardb: fix interrupt line for RTC node Biwen Li
2020-10-27 4:46 ` [v2 07/11] arm64: dts: ls208xa: add DT node for external interrupt lines Biwen Li
2020-10-27 4:46 ` [v2 08/11] arm64: dts: ls208xa-rdb: add interrupt line for RTC node Biwen Li
2020-10-27 4:46 ` [v2 09/11] arm64: dts: lx2160a: add DT node for external interrupt lines Biwen Li
2020-10-27 4:46 ` [v2 10/11] arm64: dts: lx2160ardb: fix interrupt line for RTC node Biwen Li
2020-10-27 4:46 ` [v2 11/11] dt-bindings: interrupt-controller: update bindings for supporting more SoCs Biwen Li
2020-10-27 7:40 ` [v2 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt Rasmus Villemoes
2020-10-27 7:48 ` [EXT] " Biwen Li
2020-10-27 21:30 ` Leo Li
2020-11-02 6:14 ` Biwen Li (OSS)
2020-11-02 21:22 ` Leo Li
2020-11-03 8:02 ` Rasmus Villemoes
2020-11-05 23:03 ` Leo Li
2020-11-24 1:33 ` Li Yang
2020-11-30 1:38 ` Biwen Li (OSS)
2020-10-27 9:33 ` Marc Zyngier
2020-10-27 10:35 ` Biwen Li (OSS)
2020-10-27 10:43 ` Marc Zyngier [this message]
2020-10-27 10:55 ` Biwen Li (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6cd6eecb0221742548e657faf211733@kernel.org \
--to=maz@kernel.org \
--cc=biwen.li@oss.nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=jiafei.pan@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=xiaobo.xie@nxp.com \
--cc=zhiqiang.hou@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).