[PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK

[PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK

[leqi via B4 Relay]

From: leqi <leqi@qti.qualcomm.com>

This patch adds initial audio codec support for the Hamoa-IOT-EVK board,
including WCD9385 configuration, micbias voltage settings, GPIO reset,
and power supply bindings. It enables basic audio functionality for
further development. Basic test is good in Hamoa-IOT-EVK board.

Signed-off-by: leqi <leqi@qti.qualcomm.com>
---
Changes in v2:
- Updated author email address to leqi@qti.qualcomm.com.
- Clarified that audio is validated with this change.
- Link to v1: https://lore.kernel.org/all/20250723-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-v1-1-816991701952@quicinc.com/
---
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 232 +++++++++++++++++++++++++++++
 1 file changed, 232 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
index 843f39c9d59286a9303a545411b2518d7649a059..91618e22e86c46c698b3639f60bc19314705b391 100644
--- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
+++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
@@ -124,6 +124,94 @@ pmic_glink_ss2_con_sbu_in: endpoint {
 		};
 	};
 
+	sound {
+		compatible = "qcom,x1e80100-sndcard";
+		model = "X1E80100-EVK";
+		audio-routing = "WooferLeft IN", "WSA WSA_SPK1 OUT",
+				"TweeterLeft IN", "WSA WSA_SPK2 OUT",
+				"WooferRight IN", "WSA2 WSA_SPK2 OUT",
+				"TweeterRight IN", "WSA2 WSA_SPK2 OUT",
+				"IN1_HPHL", "HPHL_OUT",
+				"IN2_HPHR", "HPHR_OUT",
+				"AMIC2", "MIC BIAS2",
+				"VA DMIC0", "MIC BIAS3",
+				"VA DMIC1", "MIC BIAS3",
+				"VA DMIC2", "MIC BIAS1",
+				"VA DMIC3", "MIC BIAS1",
+				"VA DMIC0", "VA MIC BIAS3",
+				"VA DMIC1", "VA MIC BIAS3",
+				"VA DMIC2", "VA MIC BIAS1",
+				"VA DMIC3", "VA MIC BIAS1",
+				"TX SWR_INPUT1", "ADC2_OUTPUT";
+
+		wcd-playback-dai-link {
+			link-name = "WCD Playback";
+
+			cpu {
+				sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>;
+			};
+
+			codec {
+				sound-dai = <&wcd938x 0>, <&swr1 0>, <&lpass_rxmacro 0>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+
+		wcd-capture-dai-link {
+			link-name = "WCD Capture";
+
+			cpu {
+				sound-dai = <&q6apmbedai TX_CODEC_DMA_TX_3>;
+			};
+
+			codec {
+				sound-dai = <&wcd938x 1>, <&swr2 1>, <&lpass_txmacro 0>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+
+		wsa-dai-link {
+			link-name = "WSA Playback";
+
+			cpu {
+				sound-dai = <&q6apmbedai WSA_CODEC_DMA_RX_0>;
+			};
+
+			codec {
+				sound-dai = <&left_woofer>, <&left_tweeter>,
+					    <&swr0 0>, <&lpass_wsamacro 0>,
+					    <&right_woofer>, <&right_tweeter>,
+					    <&swr3 0>, <&lpass_wsa2macro 0>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+
+		va-dai-link {
+			link-name = "VA Capture";
+
+			cpu {
+				sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
+			};
+
+			codec {
+				sound-dai = <&lpass_vamacro 0>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+	};
+
 	vph_pwr: regulator-vph-pwr {
 		compatible = "regulator-fixed";
 
@@ -353,6 +441,33 @@ vreg_wwan: regulator-wwan {
 		regulator-boot-on;
 	};
 
+	wcd938x: audio-codec {
+		compatible = "qcom,wcd9385-codec";
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&wcd_default>;
+
+		reset-gpios = <&tlmm 191 GPIO_ACTIVE_LOW>;
+
+		qcom,micbias1-microvolt = <1800000>;
+		qcom,micbias2-microvolt = <1800000>;
+		qcom,micbias3-microvolt = <1800000>;
+		qcom,micbias4-microvolt = <1800000>;
+		qcom,mbhc-buttons-vthreshold-microvolt = <75000 150000 237000 500000
+							  500000 500000 500000 500000>;
+		qcom,mbhc-headset-vthreshold-microvolt = <1700000>;
+		qcom,mbhc-headphone-vthreshold-microvolt = <50000>;
+		qcom,rx-device = <&wcd_rx>;
+		qcom,tx-device = <&wcd_tx>;
+
+		vdd-buck-supply = <&vreg_l15b_1p8>;
+		vdd-rxtx-supply = <&vreg_l15b_1p8>;
+		vdd-io-supply = <&vreg_l15b_1p8>;
+		vdd-mic-bias-supply = <&vreg_bob1>;
+
+		#sound-dai-cells = <1>;
+	};
+
 	wcn7850-pmu {
 		compatible = "qcom,wcn7850-pmu";
 
@@ -572,6 +687,32 @@ retimer_ss1_con_sbu_out: endpoint {
 	};
 };
 
+&lpass_tlmm {
+	spkr_01_sd_n_active: spkr-01-sd-n-active-state {
+		pins = "gpio12";
+		function = "gpio";
+		drive-strength = <16>;
+		bias-disable;
+		output-low;
+	};
+
+	spkr_23_sd_n_active: spkr-23-sd-n-active-state {
+		pins = "gpio13";
+		function = "gpio";
+		drive-strength = <16>;
+		bias-disable;
+		output-low;
+	};
+};
+
+&lpass_vamacro {
+	pinctrl-0 = <&dmic01_default>, <&dmic23_default>;
+	pinctrl-names = "default";
+
+	vdd-micb-supply = <&vreg_l1b_1p8>;
+	qcom,dmic-sample-rate = <4800000>;
+};
+
 &pcie6a {
 	vddpe-3v3-supply = <&vreg_nvme>;
 };
@@ -645,6 +786,90 @@ &smb2360_2_eusb2_repeater {
 	vdd3-supply = <&vreg_l8b_3p0>;
 };
 
+&swr0 {
+	status = "okay";
+
+	pinctrl-0 = <&wsa_swr_active>, <&spkr_01_sd_n_active>;
+	pinctrl-names = "default";
+
+	/* WSA8845, Left Woofer */
+	left_woofer: speaker@0,0 {
+		compatible = "sdw20217020400";
+		reg = <0 0>;
+		reset-gpios = <&lpass_tlmm 12 GPIO_ACTIVE_LOW>;
+		#sound-dai-cells = <0>;
+		sound-name-prefix = "WooferLeft";
+		vdd-1p8-supply = <&vreg_l15b_1p8>;
+		vdd-io-supply = <&vreg_l12b_1p2>;
+		qcom,port-mapping = <1 2 3 7 10 13>;
+	};
+
+	/* WSA8845, Left Tweeter */
+	left_tweeter: speaker@0,1 {
+		compatible = "sdw20217020400";
+		reg = <0 1>;
+		reset-gpios = <&lpass_tlmm 12 GPIO_ACTIVE_LOW>;
+		#sound-dai-cells = <0>;
+		sound-name-prefix = "TweeterLeft";
+		vdd-1p8-supply = <&vreg_l15b_1p8>;
+		vdd-io-supply = <&vreg_l12b_1p2>;
+		qcom,port-mapping = <4 5 6 7 11 13>;
+	};
+};
+
+&swr1 {
+	status = "okay";
+
+	/* WCD9385 RX */
+	wcd_rx: codec@0,4 {
+		compatible = "sdw20217010d00";
+		reg = <0 4>;
+		qcom,rx-port-mapping = <1 2 3 4 5>;
+	};
+};
+
+&swr2 {
+	status = "okay";
+
+	/* WCD9385 TX */
+	wcd_tx: codec@0,3 {
+		compatible = "sdw20217010d00";
+		reg = <0 3>;
+		qcom,tx-port-mapping = <2 2 3 4>;
+	};
+};
+
+&swr3 {
+	status = "okay";
+
+	pinctrl-0 = <&wsa2_swr_active>, <&spkr_23_sd_n_active>;
+	pinctrl-names = "default";
+
+	/* WSA8845, Right Woofer */
+	right_woofer: speaker@0,0 {
+		compatible = "sdw20217020400";
+		reg = <0 0>;
+		reset-gpios = <&lpass_tlmm 13 GPIO_ACTIVE_LOW>;
+		#sound-dai-cells = <0>;
+		sound-name-prefix = "WooferRight";
+		vdd-1p8-supply = <&vreg_l15b_1p8>;
+		vdd-io-supply = <&vreg_l12b_1p2>;
+		qcom,port-mapping = <1 2 3 7 10 13>;
+	};
+
+	/* WSA8845, Right Tweeter */
+	right_tweeter: speaker@0,1 {
+		compatible = "sdw20217020400";
+		reg = <0 1>;
+		reset-gpios = <&lpass_tlmm 13 GPIO_ACTIVE_LOW>;
+		#sound-dai-cells = <0>;
+		sound-name-prefix = "TweeterRight";
+		vdd-1p8-supply = <&vreg_l15b_1p8>;
+		vdd-io-supply = <&vreg_l12b_1p2>;
+		qcom,port-mapping = <4 5 6 7 11 13>;
+	};
+};
+
 &tlmm {
 	eusb3_reset_n: eusb3-reset-n-state {
 		pins = "gpio6";
@@ -733,6 +958,13 @@ usb2_pwr_3p3_reg_en: usb2-pwr-3p3-reg-en-state {
 		bias-disable;
 	};
 
+	wcd_default: wcd-reset-n-active-state {
+		pins = "gpio191";
+		function = "gpio";
+		drive-strength = <16>;
+		bias-disable;
+		output-low;
+	};
 
 	wcn_bt_en: wcn-bt-en-state {
 		pins = "gpio116";

---
base-commit: 3b28da3245e8c43f3f5948513b4e859a3d0fa820
change-id: 20250725-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-cb268fd5c654

Best regards,
-- 
leqi <leqi@qti.qualcomm.com>

Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK

[Dmitry Baryshkov]

On Mon, Jul 28, 2025 at 03:16:13PM +0800, leqi via B4 Relay wrote:
> From: leqi <leqi@qti.qualcomm.com>

This is not your name. Please fix your git setup and reset author (and
update the SoB tag) before sending this patch next time.

> 
> This patch adds initial audio codec support for the Hamoa-IOT-EVK board,

See Documentation/process/submitting-patches.rst. Please rephrase your
commit message.

> including WCD9385 configuration, micbias voltage settings, GPIO reset,
> and power supply bindings. It enables basic audio functionality for
> further development. Basic test is good in Hamoa-IOT-EVK board.

What does this mean?

> 
> Signed-off-by: leqi <leqi@qti.qualcomm.com>
> ---
> Changes in v2:
> - Updated author email address to leqi@qti.qualcomm.com.
> - Clarified that audio is validated with this change.
> - Link to v1: https://lore.kernel.org/all/20250723-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-v1-1-816991701952@quicinc.com/
> ---
>  arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 232 +++++++++++++++++++++++++++++
>  1 file changed, 232 insertions(+)
> 

-- 
With best wishes
Dmitry

Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK

[Krzysztof Kozlowski]

On 28/07/2025 09:16, leqi via B4 Relay wrote:
> From: leqi <leqi@qti.qualcomm.com>
> 
> This patch adds initial audio codec support for the Hamoa-IOT-EVK board,
> including WCD9385 configuration, micbias voltage settings, GPIO reset,
> and power supply bindings. It enables basic audio functionality for
> further development. Basic test is good in Hamoa-IOT-EVK board.
> 
> Signed-off-by: leqi <leqi@qti.qualcomm.com>
> ---
> Changes in v2:
> - Updated author email address to leqi@qti.qualcomm.com.
> - Clarified that audio is validated with this change.
> - Link to v1: https://lore.kernel.org/all/20250723-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-v1-1-816991701952@quicinc.com/
> ---
>  arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 232 +++++++++++++++++++++++++++++
>  1 file changed, 232 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> index 843f39c9d59286a9303a545411b2518d7649a059..91618e22e86c46c698b3639f60bc19314705b391 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> @@ -124,6 +124,94 @@ pmic_glink_ss2_con_sbu_in: endpoint {


This was not merged, was it? Same comment as other patch, when you have
entire code ready send entire board. Not chunk by chunk.

You are not following properly release early, release often.

Best regards,
Krzysztof

Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK

[Alexey Klimov]

On Mon Jul 28, 2025 at 8:16 AM BST, leqi via B4 Relay wrote:
> From: leqi <leqi@qti.qualcomm.com>
>
> This patch adds initial audio codec support for the Hamoa-IOT-EVK board,
> including WCD9385 configuration, micbias voltage settings, GPIO reset,
> and power supply bindings. It enables basic audio functionality for
> further development. Basic test is good in Hamoa-IOT-EVK board.
>
> Signed-off-by: leqi <leqi@qti.qualcomm.com>
> ---
> Changes in v2:
> - Updated author email address to leqi@qti.qualcomm.com.
> - Clarified that audio is validated with this change.
> - Link to v1: https://lore.kernel.org/all/20250723-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-v1-1-816991701952@quicinc.com/
> ---
>  arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 232 +++++++++++++++++++++++++++++
>  1 file changed, 232 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> index 843f39c9d59286a9303a545411b2518d7649a059..91618e22e86c46c698b3639f60bc19314705b391 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> @@ -124,6 +124,94 @@ pmic_glink_ss2_con_sbu_in: endpoint {
>  		};
>  	};
>  
> +	sound {
> +		compatible = "qcom,x1e80100-sndcard";
> +		model = "X1E80100-EVK";
> +		audio-routing = "WooferLeft IN", "WSA WSA_SPK1 OUT",
> +				"TweeterLeft IN", "WSA WSA_SPK2 OUT",
> +				"WooferRight IN", "WSA2 WSA_SPK2 OUT",
> +				"TweeterRight IN", "WSA2 WSA_SPK2 OUT",

Could you please check/confirm that above routing path
"WooferRight IN" -> "WSA2 WSA_SPK2 OUT" is correct?

Left path get input from both WSA_SPK{1,2} while the right one only uses
WSA_SPK2.


> +				"IN1_HPHL", "HPHL_OUT",
> +				"IN2_HPHR", "HPHR_OUT",
> +				"AMIC2", "MIC BIAS2",
> +				"VA DMIC0", "MIC BIAS3",
> +				"VA DMIC1", "MIC BIAS3",
> +				"VA DMIC2", "MIC BIAS1",
> +				"VA DMIC3", "MIC BIAS1",
> +				"VA DMIC0", "VA MIC BIAS3",
> +				"VA DMIC1", "VA MIC BIAS3",
> +				"VA DMIC2", "VA MIC BIAS1",
> +				"VA DMIC3", "VA MIC BIAS1",
> +				"TX SWR_INPUT1", "ADC2_OUTPUT";
> +
> +		wcd-playback-dai-link {
> +			link-name = "WCD Playback";
> +
> +			cpu {
> +				sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>;
> +			};
> +
> +			codec {
> +				sound-dai = <&wcd938x 0>, <&swr1 0>, <&lpass_rxmacro 0>;
> +			};
> +
> +			platform {
> +				sound-dai = <&q6apm>;
> +			};
> +		};

Please sort subnodes alphabetically here and below.

> +		wcd-capture-dai-link {
> +			link-name = "WCD Capture";
> +
> +			cpu {
> +				sound-dai = <&q6apmbedai TX_CODEC_DMA_TX_3>;
> +			};
> +
> +			codec {
> +				sound-dai = <&wcd938x 1>, <&swr2 1>, <&lpass_txmacro 0>;
> +			};
> +
> +			platform {
> +				sound-dai = <&q6apm>;
> +			};
> +		};
> +

[...]

Best regards,
Alexey

Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK

[Krzysztof Kozlowski]

On 28/07/2025 13:08, Krzysztof Kozlowski wrote:
> On 28/07/2025 09:16, leqi via B4 Relay wrote:
>> From: leqi <leqi@qti.qualcomm.com>
>>
>> This patch adds initial audio codec support for the Hamoa-IOT-EVK board,
>> including WCD9385 configuration, micbias voltage settings, GPIO reset,
>> and power supply bindings. It enables basic audio functionality for
>> further development. Basic test is good in Hamoa-IOT-EVK board.
>>
>> Signed-off-by: leqi <leqi@qti.qualcomm.com>
>> ---
>> Changes in v2:
>> - Updated author email address to leqi@qti.qualcomm.com.
>> - Clarified that audio is validated with this change.
>> - Link to v1: https://lore.kernel.org/all/20250723-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-v1-1-816991701952@quicinc.com/
>> ---
>>  arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 232 +++++++++++++++++++++++++++++
>>  1 file changed, 232 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>> index 843f39c9d59286a9303a545411b2518d7649a059..91618e22e86c46c698b3639f60bc19314705b391 100644
>> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>> @@ -124,6 +124,94 @@ pmic_glink_ss2_con_sbu_in: endpoint {
> 
> 
> This was not merged, was it? Same comment as other patch, when you have
> entire code ready send entire board. Not chunk by chunk.
> 
> You are not following properly release early, release often.

Why this is still not included in initial submission which happens now?
Either you work Linux style (release early) or, if you decide to wait
till everything is ready, you submit board as one patch, not everything
as 100 different patches.

Best regards,
Krzysztof

Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK

[Quill Qi]

From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Thursday, August 14, 2025 4:41 PM
To: Quill Qi <leqi@qti.qualcomm.com>; Konrad Dybcio <konradybcio@kernel.org>; Bjorn Andersson <andersson@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org <linux-arm-msm@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK


>On 28/07/2025 13:08, Krzysztof Kozlowski wrote:
>>On 28/07/2025 09:16, leqi via B4 Relay wrote:
>>>From: leqi <leqi@qti.qualcomm.com>
>>>
>>>This patch adds initial audio codec support for the Hamoa-IOT-EVK board,
>>>including WCD9385 configuration, micbias voltage settings, GPIO reset,
>>>and power supply bindings. It enables basic audio functionality for
>>>further development. Basic test is good in Hamoa-IOT-EVK board.
>>>
>>>Signed-off-by: leqi <leqi@qti.qualcomm.com>
>>>---
>>>Changes in v2:
>>>- Updated author email address to leqi@qti.qualcomm.com.
>>>- Clarified that audio is validated with this change.
>>>- Link to v1: https://lore.kernel.org/all/20250723-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-v1-1-816991701952@quicinc.com/
>>>---
>>> arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 232 +++++++++++++++++++++++++++++
>>> 1 file changed, 232 insertions(+)
>>>
>>>diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>index 843f39c9d59286a9303a545411b2518d7649a059..91618e22e86c46c698b3639f60bc19314705b391 100644
>>>--- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>+++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>@@ -124,6 +124,94 @@ pmic_glink_ss2_con_sbu_in: endpoint {
>>
>>
>>This was not merged, was it? Same comment as other patch, when you have
>>entire code ready send entire board. Not chunk by chunk.
>>
>>You are not following properly release early, release often.
>
>Why this is still not included in initial submission which happens now?
>Either you work Linux style (release early) or, if you decide to wait
>till everything is ready, you submit board as one patch, not everything
>as 100 different patches.

Hi Krzysztof, this audio change initial test is good with sound output and record fine. But with further test in Ubuntu gui only
2 speakers have sound output. I am still seeing why this issue is happening. I thought to solve the issues before replying
and merging this, thanks.

>Best regards,
>Krzysztof

--
BR
Quill

Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK

[Krzysztof Kozlowski]

On 14/08/2025 11:48, Quill Qi wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Thursday, August 14, 2025 4:41 PM
> To: Quill Qi <leqi@qti.qualcomm.com>; Konrad Dybcio <konradybcio@kernel.org>; Bjorn Andersson <andersson@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org <linux-arm-msm@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK
> 
> 
>> On 28/07/2025 13:08, Krzysztof Kozlowski wrote:
>>> On 28/07/2025 09:16, leqi via B4 Relay wrote:
>>>> From: leqi <leqi@qti.qualcomm.com>
>>>>
>>>> This patch adds initial audio codec support for the Hamoa-IOT-EVK board,
>>>> including WCD9385 configuration, micbias voltage settings, GPIO reset,
>>>> and power supply bindings. It enables basic audio functionality for
>>>> further development. Basic test is good in Hamoa-IOT-EVK board.
>>>>
>>>> Signed-off-by: leqi <leqi@qti.qualcomm.com>
>>>> ---
>>>> Changes in v2:
>>>> - Updated author email address to leqi@qti.qualcomm.com.
>>>> - Clarified that audio is validated with this change.
>>>> - Link to v1: https://lore.kernel.org/all/20250723-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-v1-1-816991701952@quicinc.com/
>>>> ---
>>>> arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 232 +++++++++++++++++++++++++++++
>>>> 1 file changed, 232 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>> index 843f39c9d59286a9303a545411b2518d7649a059..91618e22e86c46c698b3639f60bc19314705b391 100644
>>>> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>> @@ -124,6 +124,94 @@ pmic_glink_ss2_con_sbu_in: endpoint {
>>>
>>>
>>> This was not merged, was it? Same comment as other patch, when you have
>>> entire code ready send entire board. Not chunk by chunk.
>>>
>>> You are not following properly release early, release often.
>>
>> Why this is still not included in initial submission which happens now?
>> Either you work Linux style (release early) or, if you decide to wait
>> till everything is ready, you submit board as one patch, not everything
>> as 100 different patches.
> 
> Hi Krzysztof, this audio change initial test is good with sound output and record fine. But with further test in Ubuntu gui only
> 2 speakers have sound output. I am still seeing why this issue is happening. I thought to solve the issues before replying
> and merging this, thanks.

Does not look like problem with kernel, though. If arecord and aplay, as
you imply in your first sentence, work then the code is fine and should
be squashed here.

Best regards,
Krzysztof

Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK

[Quill Qi]

From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Thursday, August 14, 2025 7:17 PM
To: Quill Qi <leqi@qti.qualcomm.com>; Konrad Dybcio <konradybcio@kernel.org>; Bjorn Andersson <andersson@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org <linux-arm-msm@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK


>On 14/08/2025 11:48, Quill Qi wrote:
>>From: Krzysztof Kozlowski <krzk@kernel.org>
>>Sent: Thursday, August 14, 2025 4:41 PM
>>To: Quill Qi <leqi@qti.qualcomm.com>; Konrad Dybcio <konradybcio@kernel.org>; Bjorn Andersson <andersson@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>
>>Cc: linux-arm-msm@vger.kernel.org <linux-arm-msm@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
>>Subject: Re: [PATCH v2] arm64: dts: qcom: Add initial audio support for Hamoa-IOT-EVK
>>
>>>>On 28/07/2025 13:08, Krzysztof Kozlowski wrote:
>>>>>On 28/07/2025 09:16, leqi via B4 Relay wrote:
>>>>>>From: leqi <leqi@qti.qualcomm.com>
>>>>>>
>>>>>>This patch adds initial audio codec support for the Hamoa-IOT-EVK board,
>>>>>>including WCD9385 configuration, micbias voltage settings, GPIO reset,
>>>>>>and power supply bindings. It enables basic audio functionality for
>>>>>>further development. Basic test is good in Hamoa-IOT-EVK board.
>>>>>>
>>>>>>Signed-off-by: leqi <leqi@qti.qualcomm.com>
>>>>>>---
>>>>>>Changes in v2:
>>>>>>- Updated author email address to leqi@qti.qualcomm.com.
>>>>>>- Clarified that audio is validated with this change.
>>>>>>- Link to v1: https://lore.kernel.org/all/20250723-initial_audio_support_for_qualcomm_hamoa_iot_evk_board-v1-1-816991701952@quicinc.com/
>>>>>>---
>>>>>> arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 232 +++++++++++++++++++++++++++++
>>>>>> 1 file changed, 232 insertions(+)
>>>>>>
>>>>>>diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>>>>index 843f39c9d59286a9303a545411b2518d7649a059..91618e22e86c46c698b3639f60bc19314705b391 100644
>>>>>>--- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>>>>+++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>>>>>>@@ -124,6 +124,94 @@ pmic_glink_ss2_con_sbu_in: endpoint {
>>>
>>>
>>>This was not merged, was it? Same comment as other patch, when you have
>>>entire code ready send entire board. Not chunk by chunk.
>>>
>>>You are not following properly release early, release often.
>>
>>Why this is still not included in initial submission which happens now?
>>Either you work Linux style (release early) or, if you decide to wait
>>till everything is ready, you submit board as one patch, not everything
>>as 100 different patches.
>>
>>Hi Krzysztof, this audio change initial test is good with sound output and record fine. But with further test in Ubuntu gui only
>>2 speakers have sound output. I am still seeing why this issue is happening. I thought to solve the issues before replying
>>and merging this, thanks.
>
>Does not look like problem with kernel, though. If arecord and aplay, as
>you imply in your first sentence, work then the code is fine and should
>be squashed here.

Hi Krzysztof, when running aplay only 2 speakers have sound output. I will try to merge this after issue is solved.
For now this is not good to merge this, thank you.

>Best regards,
>Krzysztof

--
BR
Quill