From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <varada@hu-varada-blr.qualcomm.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org,
dmitry.baryshkov@linaro.org, quic_varada@quicinc.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] regulator: qcom_smd: Add LDO5 MP5496 regulator
Date: Tue, 28 Nov 2023 09:52:41 +0100 [thread overview]
Message-ID: <e6f77480-749b-4ffb-93dd-764451e3f5fb@linaro.org> (raw)
In-Reply-To: <3aa2dad7f9927dd34ab46d8fb6d1c9df4ebff7d6.1701160842.git.varada@hu-varada-blr.qualcomm.com>
On 28/11/2023 09:46, Varadarajan Narayanan wrote:
> From: Varadarajan Narayanan <quic_varada@quicinc.com>
>
> Add support for LDO5 regulator. This is used by IPQ9574 USB.
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> drivers/regulator/qcom_smd-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 09c471a0ba2e..d1be9568025e 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -796,6 +796,7 @@ static const struct rpm_regulator_data rpm_mp5496_regulators[] = {
> { "s1", QCOM_SMD_RPM_SMPA, 1, &mp5496_smps, "s1" },
> { "s2", QCOM_SMD_RPM_SMPA, 2, &mp5496_smps, "s2" },
> { "l2", QCOM_SMD_RPM_LDOA, 2, &mp5496_ldoa2, "l2" },
> + { "l5", QCOM_SMD_RPM_LDOA, 5, &mp5496_ldoa2, "l5" },
Binding says there is no l5 (neither l2...), so please update it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-28 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 8:46 [PATCH v1 0/2] ipq9574: Fix USB 'vdda-pll-supply' Varadarajan Narayanan
2023-11-28 8:46 ` [PATCH v1 1/2] regulator: qcom_smd: Add LDO5 MP5496 regulator Varadarajan Narayanan
2023-11-28 8:52 ` Krzysztof Kozlowski [this message]
2023-11-28 8:46 ` [PATCH v1 2/2] arm64: dts: qcom: ipq9574: Fix USB 'vdda-pll-supply' Varadarajan Narayanan
2023-11-28 8:51 ` Krzysztof Kozlowski
2023-11-28 10:14 ` Varadarajan Narayanan
2023-11-28 14:01 ` Krzysztof Kozlowski
2023-12-06 11:38 ` Varadarajan Narayanan
2023-12-06 12:31 ` Krzysztof Kozlowski
2023-12-06 12:33 ` Krzysztof Kozlowski
2023-12-07 4:12 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6f77480-749b-4ffb-93dd-764451e3f5fb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_varada@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=varada@hu-varada-blr.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).