From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A840CC433FE for ; Wed, 9 Nov 2022 09:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbiKIJ5L (ORCPT ); Wed, 9 Nov 2022 04:57:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230079AbiKIJ5K (ORCPT ); Wed, 9 Nov 2022 04:57:10 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36884248FE for ; Wed, 9 Nov 2022 01:57:07 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id v7so10456023wmn.0 for ; Wed, 09 Nov 2022 01:57:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Hsfhxs1hYrONLDNG0hq6h1vR8M+W0oashll6Jl8JPxI=; b=lNxoH6I6bNsajHKLUCqLi8yzFj+xh/SJ9Jm0xwLFtM1a4+vh/pKpBOq7bD5zrQ0DWa QDh/od+nbvxdulmA/f4sitrLQ92IZV1lb7P/VhT4qi7IiHf87lmivZBEMlXu6vVP+Q5q MlCpoYKk+XcMfQLU1AZlxaZGU/VSzjTwnGw7OvLPX57pZlGwI4iv3jsk6hIqqd9xvVNV EjQ3EOzaOSKJAd5hRdo1Rnqk6MygyFYIc6VDqROoyLeC2INOy5eiJmUNnrYF3hkuilUf 4OKYJqryGmZqNXuy8o55rPxjozhGmlJfhZ/V07cmoaNlrudgORnzGWyE7bysb4y704WW OwbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hsfhxs1hYrONLDNG0hq6h1vR8M+W0oashll6Jl8JPxI=; b=6ebz0frRxW4ml/vwv1t6A8SE/dEw8/0EVunEWiPOImujTrvD9dWccN6+fqed5mEs/b P8Z0R+MrlCzN5+MNfjmv4oW9/21p5oX6ZEgxHm4/0Gqpow6Vwy0RcZ59BKCzC8i/IbSj jW40Z58K3VR+lEP763TG1LP7XOzAFWlAHHWBZfevpkXwabxy8O7FswW4ldq9QX/DlVq+ olRxqOWI8CTgXFuww/b9AXXxWb4cHU7aa3wNf7LapmtQtQoqQ1UUleKlgewat6IISq1U LQ4gGrJr/jkcvmKGbBYKlbdLutZTo8mfdorJbJPoNA6W3k7PAVv2Ay8VtlEwgWbu5TMY SX9w== X-Gm-Message-State: ACrzQf32PfwN5pTHmG+e6BQjm9SmzsU1EFpmyNXKLB/A2IM9lDBotot8 IP1JKqnE6q3icQp8TGNYwmXggw== X-Google-Smtp-Source: AMsMyM66qL6/Z5tH6JpI1VqRleHOIsZAYvyin14QrXAPew92l2qjEFHEDpwMfYhbJrYWDZqb4k1TYw== X-Received: by 2002:a05:600c:1609:b0:3cf:4dc4:5a99 with SMTP id m9-20020a05600c160900b003cf4dc45a99mr40114474wmn.67.1667987826262; Wed, 09 Nov 2022 01:57:06 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id t17-20020a05600c199100b003b4fdbb6319sm1094033wmq.21.2022.11.09.01.57.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 01:57:05 -0800 (PST) Message-ID: Date: Wed, 9 Nov 2022 09:57:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 1/3] dt-bindings: slimbus: convert bus description to DT schema To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Rob Herring References: <20221026164315.39038-1-krzysztof.kozlowski@linaro.org> <20221026164315.39038-2-krzysztof.kozlowski@linaro.org> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20221026164315.39038-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/10/2022 17:43, Krzysztof Kozlowski wrote: > Convert the SLIMbus bus description bindings to DT Schema. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Rob Herring Applied all thanks, --srini > --- > .../devicetree/bindings/slimbus/bus.txt | 60 ------------ > .../bindings/slimbus/slim-ngd-qcom-ctrl.txt | 2 - > .../bindings/slimbus/slim-qcom-ctrl.txt | 3 - > .../devicetree/bindings/slimbus/slimbus.yaml | 95 +++++++++++++++++++ > 4 files changed, 95 insertions(+), 65 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/slimbus/bus.txt > create mode 100644 Documentation/devicetree/bindings/slimbus/slimbus.yaml > > diff --git a/Documentation/devicetree/bindings/slimbus/bus.txt b/Documentation/devicetree/bindings/slimbus/bus.txt > deleted file mode 100644 > index bbe871f82a8b..000000000000 > --- a/Documentation/devicetree/bindings/slimbus/bus.txt > +++ /dev/null > @@ -1,60 +0,0 @@ > -SLIM(Serial Low Power Interchip Media Bus) bus > - > -SLIMbus is a 2-wire bus, and is used to communicate with peripheral > -components like audio-codec. > - > -Required property for SLIMbus controller node: > -- compatible - name of SLIMbus controller > - > -Child nodes: > -Every SLIMbus controller node can contain zero or more child nodes > -representing slave devices on the bus. Every SLIMbus slave device is > -uniquely determined by the enumeration address containing 4 fields: > -Manufacturer ID, Product code, Device index, and Instance value for > -the device. > -If child node is not present and it is instantiated after device > -discovery (slave device reporting itself present). > - > -In some cases it may be necessary to describe non-probeable device > -details such as non-standard ways of powering up a device. In > -such cases, child nodes for those devices will be present as > -slaves of the SLIMbus controller, as detailed below. > - > -Required property for SLIMbus child node if it is present: > -- reg - Should be ('Device index', 'Instance ID') from SLIMbus > - Enumeration Address. > - Device Index Uniquely identifies multiple Devices within > - a single Component. > - Instance ID Is for the cases where multiple Devices of the > - same type or Class are attached to the bus. > - > -- compatible -"slimMID,PID". The textual representation of Manufacturer ID, > - Product Code, shall be in lower case hexadecimal with leading > - zeroes suppressed > - > -Optional property for SLIMbus child node if it is present: > -- slim-ifc-dev - Should be phandle to SLIMBus Interface device. > - Required for devices which deal with streams. > - > -SLIMbus example for Qualcomm's slimbus manager component: > - > - slim@28080000 { > - compatible = "qcom,apq8064-slim", "qcom,slim"; > - reg = <0x28080000 0x2000>, > - interrupts = <0 33 0>; > - clocks = <&lcc SLIMBUS_SRC>, <&lcc AUDIO_SLIMBUS_CLK>; > - clock-names = "iface", "core"; > - #address-cells = <2>; > - #size-cell = <0>; > - > - codec_ifd: ifd@0,0{ > - compatible = "slim217,60"; > - reg = <0 0>; > - }; > - > - codec: wcd9310@1,0{ > - compatible = "slim217,60"; > - reg = <1 0>; > - slim-ifc-dev = <&codec_ifd>; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/slimbus/slim-ngd-qcom-ctrl.txt b/Documentation/devicetree/bindings/slimbus/slim-ngd-qcom-ctrl.txt > index e94a2ad3a710..7c3d9eb6af5d 100644 > --- a/Documentation/devicetree/bindings/slimbus/slim-ngd-qcom-ctrl.txt > +++ b/Documentation/devicetree/bindings/slimbus/slim-ngd-qcom-ctrl.txt > @@ -5,8 +5,6 @@ with SLIMBus slaves directly over the bus using messaging interface and > communicating with master component residing on ADSP for bandwidth and > data-channel management > > -Please refer to slimbus/bus.txt for details of the common SLIMBus bindings. > - > - compatible: > Usage: required > Value type: > diff --git a/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt b/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt > index 922dcb8ff24a..6d955e129f90 100644 > --- a/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt > +++ b/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt > @@ -4,9 +4,6 @@ master component. > > Required properties: > > - - #address-cells - refer to Documentation/devicetree/bindings/slimbus/bus.txt > - - #size-cells - refer to Documentation/devicetree/bindings/slimbus/bus.txt > - > - reg : Offset and length of the register region(s) for the device > - reg-names : Register region name(s) referenced in reg above > Required register resource entries are: > diff --git a/Documentation/devicetree/bindings/slimbus/slimbus.yaml b/Documentation/devicetree/bindings/slimbus/slimbus.yaml > new file mode 100644 > index 000000000000..22513fb7c59a > --- /dev/null > +++ b/Documentation/devicetree/bindings/slimbus/slimbus.yaml > @@ -0,0 +1,95 @@ > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/slimbus/slimbus.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: SLIM (Serial Low Power Interchip Media) bus > + > +maintainers: > + - Srinivas Kandagatla > + > +description: > + SLIMbus is a 2-wire bus, and is used to communicate with peripheral > + components like audio-codec. > + > +properties: > + $nodename: > + pattern: "^slim(@.*|-[0-9a-f])*$" > + > + "#address-cells": > + const: 2 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^.*@[0-9a-f]+,[0-9a-f]+$": > + type: object > + description: | > + Every SLIMbus controller node can contain zero or more child nodes > + representing slave devices on the bus. Every SLIMbus slave device is > + uniquely determined by the enumeration address containing 4 fields:: > + Manufacturer ID, Product code, Device index, and Instance value for the > + device. > + > + If child node is not present and it is instantiated after device > + discovery (slave device reporting itself present). > + > + In some cases it may be necessary to describe non-probeable device > + details such as non-standard ways of powering up a device. In such cases, > + child nodes for those devices will be present as slaves of the SLIMbus > + controller. > + > + properties: > + compatible: > + pattern: "^slim[0-9a-f]+,[0-9a-f]+$" > + > + reg: > + maxItems: 1 > + description: | > + Pair of (device index, instande ID), where:: > + - Device index, which uniquely identifies multiple devices within a > + single component. > + - Instance ID, can be used for the cases where multiple devices of > + the same type or class are attached to the bus. > + > + required: > + - compatible > + - reg > + > + additionalProperties: true > + > +required: > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: true > + > +examples: > + - | > + #include > + #include > + #include > + > + soc { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + slim@28080000 { > + compatible = "qcom,apq8064-slim", "qcom,slim"; > + reg = <0x28080000 0x2000>, <0x80207c 4>; > + reg-names = "ctrl", "slew"; > + interrupts = ; > + clocks = <&lcc SLIMBUS_SRC>, <&lcc AUDIO_SLIMBUS_CLK>; > + clock-names = "iface", "core"; > + #address-cells = <2>; > + #size-cells = <0>; > + > + audio-codec@1,0 { > + compatible = "slim217,60"; > + reg = <1 0>; > + }; > + }; > + };