From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org Subject: Re: [PATCH V3 1/3] vfio, platform: add support for ACPI while detecting the reset driver Date: Tue, 29 Mar 2016 06:59:15 -0400 Message-ID: References: <1459172124-6730-1-git-send-email-okaya@codeaurora.org> <1459172124-6730-2-git-send-email-okaya@codeaurora.org> <98854818.NJS35fvhsb@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <98854818.NJS35fvhsb@wuerfel> Sender: linux-arm-msm-owner@vger.kernel.org To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, eric.auger@linaro.org, mark.rutland@arm.com, devicetree@vger.kernel.org, Baptiste Reynal , vikrams@codeaurora.org, marc.zyngier@arm.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vinod.koul@intel.com, Alex Williamson , agross@codeaurora.org, Dan Carpenter , shankerd@codeaurora.org List-Id: devicetree@vger.kernel.org On 2016-03-29 05:25, Arnd Bergmann wrote: > On Monday 28 March 2016 09:35:22 Sinan Kaya wrote: >> The code is using the compatible DT string to associate a reset driv= er=20 >> with >> the actual device itself. The compatible string does not exist on AC= PI >> based systems. HID is the unique identifier for a device driver=20 >> instead. >> The change allows a driver to register with DT compatible string or=20 >> ACPI >> HID and then match the object with one of these conditions. >>=20 >> Rules for loading the reset driver are as follow: >> - ACPI HID needs match for ACPI systems >> - DT compat needs to match for OF systems >>=20 >> Tested-by: Eric Auger (device tree only) >> Tested-by: Shanker Donthineni (ACPI only) >> Signed-off-by: Sinan Kaya >>=20 >=20 >=20 > This really feels wrong for two reasons: >=20 > * device assignment of non-PCI devices is really special and doesn't > seem to make sense on general purpose servers that would be the=20 > target > for ACPI normally Why is it special? Acpi is not equal to pci. Platform devices are first= =20 class devices too. Especially, _cls was introduced for this reason. >=20 > * If there is indeed a requirement for ACPI to handle something like=20 > this, > it should be part of the ACPI spec, with a well-defined method of=20 > handling > reset, rather than having to add a device specific hack for each > device separately. >=20 I see. Normally, this is done by calling _rst method. AFAIK, Linux=20 doesn=E2=80=99t support _rst. I can check its presence and call it if i= t is=20 there. > Arnd