Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Krzysztof Kozlowski <krzk@kernel.org>]

On 19/11/2025 08:00, Dragan Simic wrote:
> Hello Michael,
> 
> On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
>> which are SBCs based on the Rockchip 3566 SoC.
>>
>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
>> and a "mask ROM" DIP switch to the "3" version.
>>
>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>
>> ---
>>
>> Changes in V3:
>>
>> - Remove this Acked-by as the binding code changed substantially:
>>   Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 6aceaa8acbb2..800c11323a4f 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -86,6 +86,13 @@ properties:
>>            - const: asus,rk3288-tinker-s
>>            - const: rockchip,rk3288
>>  
>> +      - description: Asus Tinker Board 3/3S
>> +        items:
>> +          - enum:
>> +              - asus,rk3566-tinker-board-3
>> +              - asus,rk3566-tinker-board-3s
>> +          - const: rockchip,rk3566
>> +
>>        - description: Beelink A1
>>          items:
>>            - const: azw,beelink-a1
> 
> Please see my delayed response in the v2. [1]  I think that would be
> a better approach.
> 
> [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
> 

Your reviews are not helpful. You nitpick irrelevant things and propose
solutions which later reverse leading to wasted effort on contributors side.

Michael implemented what you asked here:

https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/

This patch implements exactly what you wanted. On v4 you will ask to
reverse back to v1?

Now you claim that you want back v2. Really, you are NOT HELPING. It is
clear you do not understand what you are proposing and this is not
helping ion the process. Please refrain from such confusing reviews.



Best regards,
Krzysztof