From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8065D130495 for ; Mon, 12 Aug 2024 11:32:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723462336; cv=none; b=Rz0SZjGls8rKxcD9XT4ecPAoS/BCPMrz+q4UvsdkAW07TUdiZwMeuMoeyztCpuhgHMyEGj7ZTqVjO51ZKvaxBdRkorN2TxC5aBHZB0Lz/0wp5WzHfMO+87IG9TxHSZDI2UJBSof9Uw1gNMf6QCnSiYa9dVkgjLjdbq99oA4dPF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723462336; c=relaxed/simple; bh=Sn9icOhMEkpoF0A6tI3yE7WA9lul1v5onDCX2r2+Qrk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Vd3x7fv1owoI222U++tvaU2YZuMgk2nl8FbVviOUtxQhoywoRZEAujN/8rGTjLM+H5SWyWNLMVMXcu9WW/uWIySFQ1F4VRKFLNJufObVXdGHnUVMNh2r5wParehX+pNytgKDvRfu9vpXLDTYelP1U4w5je7hsxeu6JicAm2VzbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dS781GUs; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dS781GUs" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-36bb2047bf4so2875901f8f.2 for ; Mon, 12 Aug 2024 04:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723462333; x=1724067133; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pcyTK/oFMaR/LKJwL+lhFRbctKc9N7kd/DA0SliDqNw=; b=dS781GUsOJpq/5SPqVVB60Ti90hTdYQZEfWn90Ul/xJzZp0drpkmPJf30f5VEKKphU aSle2ZnKdc9DLiP3XgICnWzzh2u/9ceeRvR4pHs05A9Tk7uigBhn9cVjMza+fgNGHcZb wNy+yY9uIheV/5u0It4vqdzx+zVBCwYIXWdj32wvTs02MMxkpXB0VB/8jNhpmm9wnkOX q9roSdAkYntSq7X9JZhupgJiZmS4ol8fSX1d1PoXY3PkwkdRLIafH2eHFOsvKkkY7sGv DoOZVkSEX9lJHtzMDIinS1ukDLu+jcgmig5z1K43om4tENRPcU7pS+PpAUcfZ634yCvG umVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723462333; x=1724067133; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pcyTK/oFMaR/LKJwL+lhFRbctKc9N7kd/DA0SliDqNw=; b=OoydnBsskrCqAtiRr/5rAW/dqCCyIgsGgqjiWkriqm+44K3d3KUlj6leUXYHhZ1yhn BPL73xDBoVbPmvGn4P6u4zcFGv5bkB+G/G5O84p8QxTcz1Hwh5E2MO8kxgkC1ICYAXSw Mo6X1avlq/Jr3CvXpCB8sURGuBQVqgbeYfC+GsX7Zu7jkmLwsLfPDEVIlJdkYHal7wdG DZa0d5eLxScmln8ltRkCKseEvJ4Dk/GzBmYT5oI+/I0NXR5OO0CI0CFNYjl1xxkgpSSJ 2sNs9ObU3lnC4whF3geWPSknnnYVE2IogdGGq2WAzgoWTYaWwPj/Sq6tX5rzRGYnM2jL wiCw== X-Forwarded-Encrypted: i=1; AJvYcCUOJM8kSgMoO8yG4N3CRaBdoslyUGC6U9P2BBFfV+TdqS5mNv7Sj0HVvLRC+TSptWFdL3uErHyEHHzX@vger.kernel.org X-Gm-Message-State: AOJu0YxcUF8HixMiZWPn5Qqgv9hEVgXmDzTjtUpvqB2FHvDjDf+ndVAs jS1VysxGvxwBize6BbJuVckbgc3E5nqaTYIuv4BFxPEBzJN89Cbp1cTumgNOmJE= X-Google-Smtp-Source: AGHT+IFKMt3nGJr3TmBQHVfbwLzP7ID+7QLqJpZ8Bb1C7l06gp6nyMd4PGALNfePozuyllzfm0jwZg== X-Received: by 2002:a5d:4ad1:0:b0:362:8ec2:53d6 with SMTP id ffacd0b85a97d-36d61cd3550mr8292553f8f.61.1723462332792; Mon, 12 Aug 2024 04:32:12 -0700 (PDT) Received: from [192.168.0.25] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4c937b6esm7261016f8f.32.2024.08.12.04.32.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Aug 2024 04:32:12 -0700 (PDT) Message-ID: Date: Mon, 12 Aug 2024 12:32:10 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/13] media: qcom: camss: csiphy: Add an init callback to CSI PHY devices To: Depeng Shao , Vladimir Zapolskiy , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: quic_eberman@quicinc.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: <20240709160656.31146-1-quic_depengs@quicinc.com> <20240709160656.31146-5-quic_depengs@quicinc.com> <6dfc2c79-fc6d-4eed-bf3f-94396130cb4f@linaro.org> <4426c0e0-f877-409c-b2d2-a5aac5e8c645@linaro.org> <1226d080-d1fc-4e06-ac81-84e93cb314e0@quicinc.com> <8f935a7d-87b5-479c-a98e-c95671dbe259@linaro.org> <7c03280f-908d-435d-acef-b6bf4f865029@quicinc.com> <3241cc15-c920-4c88-ac53-005903baf9e7@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <3241cc15-c920-4c88-ac53-005903baf9e7@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/08/2024 15:02, Depeng Shao wrote: > I'm updating the code based on above comments, but I meet crash issue if > I move the offset assignment to csiphy_gen2_config_lanes, since the > csiphy->res->hw_ops->reset(csiphy) is called earlier than > csiphy_gen2_config_lanes, so if we don't have the .init interface, we > only can move this offset value to `struct csiphy_subdev_resources`, but > if we add the offset to `struct csiphy_subdev_resources`, then below two > patches are also can be dropped. > > > [PATCH 05/13] media: qcom: camss: csiphy-3ph: Move CSIPHY variables to > data field inside csiphy struct > [PATCH 06/13] media: qcom: camss: csiphy-3ph: Use an offset variable to > find common control regs > > > Could you please comment on if I need to add the CSI_COMMON_CTR offset > to res directly? > Or add back the .init interface? Ah, I hadn't recalled why the .init was added -> because sequencing. Lets retain the patch but expand the commit log to explain why the init is being added, instead of jumping through hoops to restructure to get rid of it. --- bod