From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19FFB3DA5B6 for ; Tue, 28 Apr 2026 09:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777369822; cv=none; b=A999/b/5SwAqFrEshyOaSEWd0GN/sNZncZGonji4knOjaPPQe4s5Q0iBCZQ58sCSNmwGnjUuMrLDOPtvIsX2psl22wNHBAb4sen9UeiqEnGpfYekF6DNydK0feE0Gk6n0hreGriI7a2cQw8vUDIefebZ05RIa/LR4kZXUk1Thdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777369822; c=relaxed/simple; bh=xJHqPBiTn94yBzMImM4YOFZy7uS41sjz0uqcdavPIHw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PqEqLKH3zJWHNJRiXAMN3G7IO3hfpRRhWyCBYs6WE4TlDo4ebXHVok5djmdaxwWXb8VkhtPKG9+I9MBaOLtswb5Z5BcxHVAZe2b5FypDy1HbkM68P34f3ywJynOMf97+KYTEO9llclounomy0lQyI8uFNF2TFsT2fSHYULJErnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FcizD0zR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PDFUrll7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FcizD0zR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PDFUrll7" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63S54Cbi429172 for ; Tue, 28 Apr 2026 09:50:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rSgFwP34wCo85AXhGbCR+4Z8PnplijHqeQr5lFbp24E=; b=FcizD0zRNxc6cpHg 57cp96c0X25V4Dg1/329BfSZWxMwjav9fnBsOhuvrLjRGlirvmTJgyxdzfEzU6aH CmH9V1X6eiZoBbOm9uvewtLkESS3c2Qlr20WZQ0BEvEpHqfaabvVYzq5dHjehO2z kPyD83i6EfmB5A+IiXuDh4LjbzYDjzVcfxWBuuntAx6drxwRwYpRHtiYjuDF0miz p8owDTw1csDLaJV6VpPFMMo7y3nKmz7JzG7jyDWkPf7YYMiYuCW9XQqS6BNp2yRu +pYwUNxn5uTZVyoJGNZCEPBBFzPTYJcELIyDyFabnwm33FUv3w8GFc4pypy75gC1 v8CCgw== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dt7x34f14-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Apr 2026 09:50:19 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8b026c4497fso21709986d6.2 for ; Tue, 28 Apr 2026 02:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777369818; x=1777974618; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rSgFwP34wCo85AXhGbCR+4Z8PnplijHqeQr5lFbp24E=; b=PDFUrll7DcQ8/zHxh5ZIoyNvbqxP3o7PPcXaAYyswwFWmFCnaaVksDiRVy0JqwvY+n Ub+JiEzs/wrxFuVCZL60nf7OzbtasJbHEOXH7vvBUrLko8CcDtGBrkCvlbsAwMy+dYzS bz2NKtMTISHoUCOZ64y14B+oNLo9LOsxoC8IB95DTHTXPf/miw5PunP3viYkjaLC9VuP vadMt91hpqVUobQXAft25qkyATMKfwGKP1GAA6HSYRDw4JQ29TljTR/k2T979zLsEkEY MsyXkL5Bh/rn+RP5+wSsXWS5IxliIjVn4f8vIq83ioWG9wLeIhXIIib7zQmSK2KszsVi Pt9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777369818; x=1777974618; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rSgFwP34wCo85AXhGbCR+4Z8PnplijHqeQr5lFbp24E=; b=n8xnPyleRqQyiQk1qy6j0ao59SgpDJGrkh1jJGH3keYgOOzY/pmtH9u4nR2ujFWIY7 M1Cv1HJWpb+1cOkthM1rCyPNcBc9jJJaV6oEt8kes0orxaKZf30WenIWbnUXHAl0EsNF Eta499DeRUfZI8OIg4XFYALPkCYSDGDgBeOyaFfCKf9x7gayYB8WFWov1nj1PLfZT+QL YjCfwZo15Nictno1z/Wr+A0J4JfQ4BaO0NprO1cZNaPbefgohg8NT8JgIXuT/yDMlbQX V5JilTSUWJVeO9tqLROat7RObeBS8vLL5JETB4xrwRN4uAL2q55vrEJUV+RKzviOV4Wx Uneg== X-Forwarded-Encrypted: i=1; AFNElJ/Hcz1csB/u8v6h6YCl+65Itx7xd9tYEyemVPQ92Gn0v16t1x24JHhIzw9lMrehpcg9uwNNpVoX3SP4@vger.kernel.org X-Gm-Message-State: AOJu0YxLHVgtJJn+53OHOZeip8lc/BYcs+n5z41Um0m9W8ymNry/JA8x ioJD0WdYi1emcRdsRsgiS9alteZ4dKX+2Q+cgNPqVABA9Fl7bZhw8NzF+QenF9zPs9iuNnY2102 jnUWSyGrZ1xilebvVSM0AHOQtlJbg4i8oRH4aVZqYf13LiiNwkUfXg+9l9LihHrd4 X-Gm-Gg: AeBDiev81CHEiGiom6I43S+9frqmH41Mgs1f2wiDglE6RHcq2k3BC47TTrtGp+VLKFy YqLNjYMJghPRVoc2h6nljQGhWA6vL9sxmBrkPqTR8+0zFgpExijqD3QzTAGnYTyaREw12h9aLEN PM/kOXecOl5kubWHop8qcrDzt3RKTwfPMqvOk88zbCQoh7pr+mv6UGbVd6eyNV42FgPGEFOi2rz mP0k6D6SI+1wucRUXm99xniXZHH+hQ7eMBkEYwtGfAUQHVJftSqm6/gTFP0fkOfQ4LC+4KFyS01 b3lG2gWwyGQ0RcFf1nItlRptF0cgTmcdBwJErWE7DOpVyAVN2IjP2FBdHniKexQCXbM7yGy4k9E +WU7QJ//CeJhpVyce4+6nKwbfJBJmAQaR0c4kkbQTSkx2YEaBUa+R/G7jMhtS99uT7SCjEnG56r k470yLEPPvGEKjfg== X-Received: by 2002:a05:6214:caf:b0:89c:e371:2b42 with SMTP id 6a1803df08f44-8b3e283bb10mr30341416d6.2.1777369818284; Tue, 28 Apr 2026 02:50:18 -0700 (PDT) X-Received: by 2002:a05:6214:caf:b0:89c:e371:2b42 with SMTP id 6a1803df08f44-8b3e283bb10mr30341026d6.2.1777369817780; Tue, 28 Apr 2026 02:50:17 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bb80853e641sm77209466b.10.2026.04.28.02.50.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 02:50:16 -0700 (PDT) Message-ID: Date: Tue, 28 Apr 2026 11:50:13 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/14] dt-bindings: media: qcom,qcm2290-camss: Add OPE ISP subnode To: Krzysztof Kozlowski , Loic Poulain Cc: Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Kees Cook , "Gustavo A. R. Silva" , Bryan O'Donoghue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, devicetree@vger.kernel.org, laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com References: <20260427-camss-isp-ope-v2-0-f430e7485009@oss.qualcomm.com> <20260427-camss-isp-ope-v2-11-f430e7485009@oss.qualcomm.com> <20260428-demonic-albatross-of-enrichment-aa6f26@quoll> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260428-demonic-albatross-of-enrichment-aa6f26@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI4MDA4NSBTYWx0ZWRfX5PYU4v/oOeaT JG6q0CP3lCp4xli6EZyKF1QFJVfR96bWVjw0ZYc+BsUCy6MLE0jIcNi5l+iYfQlQtHicxqTQC7M 5uMk0Q9+itZoU6TPcBKXH68TxRwyfJu1kwtZVEbx+XgVaNFisiDtk6Zjs5om6esA2WO4Y/tWMUL 2DRr7AFpK1FczWPmaIVd8ARnGMnqh79R5JDfYoc0bczG+G3XXeOExRSGtI4WePzo2qJmAsy0e7P sP2a6dfUkeXt+CbfplIXUHkwd2KeXCOh4BqVtHC0lemKeQsXe6CJ5DYSv5KabhbiOacp4lSCkAv wNQlCPhvFveksAuzo1q1VHJjDszKl5HRteG2YnKPpVCl/nqg2UG25QoupEsks+Hvj5yDQKrOVUJ uWkXCYuoe2hjuf5pcS6SkpCVjQjiOvoqrNUSI4jWVn9SAHVtX5bEzjIV3O77muKKfGHTbTEsaWY ewZwJkH/S4BvsQxG2Yg== X-Proofpoint-ORIG-GUID: V-X4n86_gPg0BMRBzW7IY8dZjILLHQyt X-Authority-Analysis: v=2.4 cv=AJEsYPsu c=1 sm=1 tr=0 ts=69f082db cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=axVsYsM61IUpGc0LCtEA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-GUID: V-X4n86_gPg0BMRBzW7IY8dZjILLHQyt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_02,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280085 On 4/28/26 8:35 AM, Krzysztof Kozlowski wrote: > On Mon, Apr 27, 2026 at 02:43:38PM +0200, Loic Poulain wrote: >> Extend the qcm2290 CAMSS binding to describe CAMSS as a simple bus by >> allowing child ISP nodes. Add the required address and size cells, as >> well as ranges, and validate ISP subnodes against the existing >> qcom,qcm2290-camss-ope schema. >> >> On qcm2290 the OPE (Offline Processing Engine) is a memory-to-memory >> ISP (Image Signal Processor). >> >> Signed-off-by: Loic Poulain >> --- >> .../devicetree/bindings/media/qcom,qcm2290-camss.yaml | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml >> index 391d0f6f67ef5fdfea31dd3683477561516b1556..d8b356028e24c3c5b2e9b7f20e220db7d491ad68 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml >> @@ -52,6 +52,14 @@ properties: >> - const: vfe1 >> - const: vfe1_cphy_rx >> >> + '#address-cells': > > Please use consistent quotes, either ' or " > >> + const: 2 > > This means the child will use 64-bit addressing, but does it need that? > Or do you need that to have 36-bit DMA addressing? If there are true no > needs for above, usually recommendation is to use narrowe address space > for children, so only 32-bit. I can't find data for this platform, but on e.g. Hamoa, most camera components can address 36b Konrad