From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4481033CF for ; Thu, 15 Feb 2024 07:23:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707981814; cv=none; b=f8rWnjKmI/D50w3NnALXfpS/tvqQGYWj9g6kPrI9tiOXHAvz1FT7l7nHL6bLV8UXIP1KN+c6uqYu4L83kJ7+TZEHuaveTB+6cgY1zrX2pifzb6kw+vDtUuxcdqILEOJsULXA243lKXBqo8sItjPk5Qpm9FIaRyePSKbEceh4yzM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707981814; c=relaxed/simple; bh=z698GAzx2SjZip44MgXj+QQQv6m+ThWhoR0dgUQId58=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PiOyZF0mT61+4kzzL5bHoidxzJFUK34Kc4EVz8GawEXB14rsLKRMcezQgBcM/iSU59pZFG1uUZNgPzBCl9MnnVjRokJhlC+0v4WkcZULvxIZfzXLGnSFUudFAM3SoOoWk7IVFMcSK7jsqZnvXbQpMvtkmUB5oLxmTc04E67XE+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=XcIyjK68; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="XcIyjK68" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2d107900457so7693131fa.1 for ; Wed, 14 Feb 2024 23:23:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707981809; x=1708586609; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B5j39bQM+ZSv0KF1DL/osRnC1kF9C4R9FA/78T8kPLk=; b=XcIyjK68LtLnjhOwckArgxqJQL3fnKpwobRv8c1UqbQ4JfmUlRzwwHAo1XDucQrhXh p40SESpYZfHIHJ9SNQ6/cMT5WSaWpJKKXOb5NBqTWSeLrttNLAZlKZwwfzpog3jLS0m4 SGsm1685GQRXxWpTTeLMcvsiGoa3KCG13bH+zoFrR2sT44koy4+VxhkJ9csw+9ic8/xb wlQBb7hPs6V7c6iLC5hW4dpjniUovgWDv5t+XNW6yaIvx/wvSABL8/NsM/GRD/RGq+Gt HmTScFC7R21XUfkS6RtZYI+nQuottZX1OFwdZ9+bHfm6JT/OtRDEL+vz7LEbUIUqfXEt 8Esw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707981809; x=1708586609; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B5j39bQM+ZSv0KF1DL/osRnC1kF9C4R9FA/78T8kPLk=; b=X0jTtBXoe+3Zjxynkh7NcHmQFNldiHgLtgKYEO+MWzkQRpsC2Ku8QYtDkvqpkwt+rm voMU0JkFZJOrHyp6bVGTouPpn8VYfmKT89JFLqjjfvlyDnMDqsp/XbsKQC8FnPQEpBUX sXh/5QYBnOdaEaXI6CZDfBAkQAGLXsdeF8I4qARJJDD9mBfGLq6nY4mP5mMRu/QxF4A0 S50EMYrqxWLYUaZljDFxFNUhMB4acqf/rGHHmbZi/W+qS80GZJO6oA4lYJGgCWCBhlx0 3BufrF5dr2UTed/D5kfyGxPNEv808sE7Z4dRPLuQVQStX3homj9tO+PStul+AX6TzVSI F89w== X-Forwarded-Encrypted: i=1; AJvYcCVROWo1ry13UMF+hiyCggYB9zofHPPj5oLDZFiZZIBSVbydXfU+xWrhwbhavQqpt0Is44JYl1H+xow2a/ZVeo7GlDbUApux+DXdBg== X-Gm-Message-State: AOJu0Yx/lfmAj9NYFVTFvcmoEO6PH1FC57hef11N3WUyheh0td3Vw+Nb 3hOekH5lM1wNKptRuW8+A9BmchSMz7/cXJWrneJZuCNXrr5AoZfT8ETk3aCZy7g= X-Google-Smtp-Source: AGHT+IGXHb+0Z1Joaep8niCFInUiNo8NuldJAF+qLlv8gxIAEhkjjL4fZwcnw35WdmxR0HHYHNbbSA== X-Received: by 2002:a05:651c:1a0b:b0:2d2:f0c:623b with SMTP id by11-20020a05651c1a0b00b002d20f0c623bmr102224ljb.4.1707981809044; Wed, 14 Feb 2024 23:23:29 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.20]) by smtp.gmail.com with ESMTPSA id fm12-20020a05600c0c0c00b0041209136d50sm1025017wmb.39.2024.02.14.23.23.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Feb 2024 23:23:28 -0800 (PST) Message-ID: Date: Thu, 15 Feb 2024 09:23:26 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] ARM: dts: microchip: sama7g54_curiosity: Add initial device tree of the board Content-Language: en-US To: Mihai Sain , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, andre.przywara@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: cristian.birsan@microchip.com References: <20240214080348.7540-1-mihai.sain@microchip.com> <20240214080348.7540-4-mihai.sain@microchip.com> From: claudiu beznea In-Reply-To: <20240214080348.7540-4-mihai.sain@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14.02.2024 10:03, Mihai Sain wrote: > Add initial device tree of the SAMA7G54 Curiosity board. > > Signed-off-by: Mihai Sain > --- > arch/arm/boot/dts/microchip/Makefile | 4 +- > .../dts/microchip/at91-sama7g54_curiosity.dts | 487 ++++++++++++++++++ > 2 files changed, 490 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/boot/dts/microchip/at91-sama7g54_curiosity.dts > > diff --git a/arch/arm/boot/dts/microchip/Makefile b/arch/arm/boot/dts/microchip/Makefile > index efde9546c8f4..29b2a788748f 100644 > --- a/arch/arm/boot/dts/microchip/Makefile > +++ b/arch/arm/boot/dts/microchip/Makefile > @@ -12,6 +12,7 @@ DTC_FLAGS_at91-sama5d3_eds := -@ > DTC_FLAGS_at91-sama5d3_xplained := -@ > DTC_FLAGS_at91-sama5d4_xplained := -@ > DTC_FLAGS_at91-sama7g5ek := -@ > +DTC_FLAGS_at91-sama7g54_curiosity := -@ Alphanumerical sort, thus DTC_FLAGS_at91-sama7g54_curiosity comes before DTC_FLAGS_at91-sama7g5ek > dtb-$(CONFIG_SOC_AT91RM9200) += \ > at91rm9200ek.dtb \ > mpa1600.dtb > @@ -87,7 +88,8 @@ dtb-$(CONFIG_SOC_SAM_V7) += \ > at91-sama5d4ek.dtb \ > at91-vinco.dtb > dtb-$(CONFIG_SOC_SAMA7G5) += \ > - at91-sama7g5ek.dtb > + at91-sama7g5ek.dtb \ > + at91-sama7g54_curiosity.dtb Same here. > > dtb-$(CONFIG_SOC_LAN966) += \ > lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb \ > diff --git a/arch/arm/boot/dts/microchip/at91-sama7g54_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sama7g54_curiosity.dts > new file mode 100644 > index 000000000000..a6504c3781f4 > --- /dev/null > +++ b/arch/arm/boot/dts/microchip/at91-sama7g54_curiosity.dts > @@ -0,0 +1,487 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * at91-sama7g54_curiosity.dts - Device Tree file for SAMA7G54 Curiosity Board > + * > + * Copyright (C) 2024 Microchip Technology Inc. and its subsidiaries > + * > + * Author: Mihai Sain > + * > + */ > +/dts-v1/; > +#include "sama7g5-pinfunc.h" > +#include "sama7g5.dtsi" > +#include > +#include > +#include > +#include > + > +/ { > + model = "Microchip SAMA7G54 Curiosity"; > + compatible = "microchip,sama7g54-curiosity", "microchip,sama7g5", "microchip,sama7"; > + > + aliases { > + serial0 = &uart3; > + i2c0 = &i2c10; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_key_gpio_default>; > + > + button-user { > + label = "user-button"; > + gpios = <&pioA PIN_PD19 GPIO_ACTIVE_LOW>; > + linux,code = ; > + wakeup-source; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_led_gpio_default>; > + > + led-red { > + color = ; > + function = LED_FUNCTION_POWER; > + gpios = <&pioA PIN_PD13 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + }; > + > + led-green { > + color = ; > + function = LED_FUNCTION_BOOT; > + gpios = <&pioA PIN_PD14 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + }; > + > + led-blue { > + color = ; > + function = LED_FUNCTION_CPU; > + gpios = <&pioA PIN_PB15 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > + memory@60000000 { > + device_type = "memory"; > + reg = <0x60000000 0x10000000>; // 256 MiB DDR3L-1066 16-bit > + }; > +}; > + > +&adc { > + vddana-supply = <&vddout25>; > + vref-supply = <&vddout25>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_mikrobus1_an_default &pinctrl_mikrobus2_an_default>; > + status = "okay"; > +}; > + > +&cpu0 { > + cpu-supply = <&vddcpu>; > +}; > + > +&dma0 { > + status = "okay"; > +}; > + > +&dma1 { > + status = "okay"; > +}; > + > +&dma2 { > + status = "okay"; > +}; > + > +&ebi { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_nand_default>; > + status = "okay"; > + > + nand_controller: nand-controller { > + status = "okay"; > + > + nand@3 { > + reg = <0x3 0x0 0x800000>; > + atmel,rb = <0>; > + nand-bus-width = <8>; > + nand-ecc-mode = "hw"; > + nand-ecc-strength = <8>; > + nand-ecc-step-size = <512>; > + nand-on-flash-bbt; > + label = "nand"; > + > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + at91bootstrap@0 { > + label = "nand: at91bootstrap"; > + reg = <0x0 0x40000>; > + }; > + > + bootloader@40000 { > + label = "nand: u-boot"; > + reg = <0x40000 0x100000>; > + }; > + > + bootloaderenv@140000 { > + label = "nand: u-boot env"; > + reg = <0x140000 0x40000>; > + }; > + > + dtb@180000 { > + label = "nand: device tree"; > + reg = <0x180000 0x80000>; > + }; > + > + kernel@200000 { > + label = "nand: kernel"; > + reg = <0x200000 0x600000>; > + }; > + > + rootfs@800000 { > + label = "nand: rootfs"; > + reg = <0x800000 0x1f800000>; > + }; > + }; > + }; > + }; > +}; > + > +&flx3 { > + atmel,flexcom-mode = ; > + status = "okay"; > + > + uart3: serial@200 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flx3_default>; > + status = "okay"; > + }; > +}; > + > +&flx10 { > + atmel,flexcom-mode = ; > + status = "okay"; > + > + i2c10: i2c@600 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flx10_default>; > + i2c-analog-filter; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <35>; > + status = "okay"; > + > + adc@1f { > + compatible = "microchip,pac1934"; There is no driver for this one in the upstream Linux and the compatible is not documented. I would remove the node until the driver lands in mainline Linux. > + reg = <0x1f>; > + }; > + > + eeprom@51 { > + compatible = "atmel,24c02"; > + reg = <0x51>; > + pagesize = <16>; > + size = <256>; > + vcc-supply = <&vdd_3v3>; > + }; > + > + pmic@5b { > + compatible = "microchip,mcp16502"; > + reg = <0x5b>; > + > + regulators { > + vdd_3v3: VDD_IO { > + regulator-name = "VDD_IO"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <3300000>; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-mode = <4>; > + }; > + }; > + > + vddioddr: VDD_DDR { > + regulator-name = "VDD_DDR"; > + regulator-min-microvolt = <1350000>; > + regulator-max-microvolt = <1350000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <1350000>; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <1350000>; > + regulator-mode = <4>; > + }; > + }; > + > + vddcore: VDD_CORE { > + regulator-name = "VDD_CORE"; > + regulator-min-microvolt = <1150000>; > + regulator-max-microvolt = <1150000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-suspend-voltage = <1150000>; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-mode = <4>; > + }; > + }; > + > + vddcpu: VDD_OTHER { > + regulator-name = "VDD_OTHER"; > + regulator-min-microvolt = <1050000>; > + regulator-max-microvolt = <1250000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-ramp-delay = <3125>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-suspend-voltage = <1050000>; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-mode = <4>; > + }; > + }; > + > + vldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-suspend-voltage = <1800000>; > + regulator-on-in-suspend; > + }; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vldo2: LDO2 { > + regulator-name = "LDO2"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-suspend-voltage = <3300000>; > + regulator-on-in-suspend; > + }; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + }; > + }; > + }; > +}; > + > +&main_xtal { > + clock-frequency = <24000000>; > +}; > + > +&qspi1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_qspi1_default>; > + status = "okay"; > + > + flash@0 { > + compatible = "jedec,spi-nor"; > + reg = <0x0>; > + spi-max-frequency = <100000000>; > + spi-tx-bus-width = <4>; > + spi-rx-bus-width = <4>; > + m25p,fast-read; > + }; > +}; > + > +&pioA { > + pinctrl_flx3_default: flx3-default { > + pinmux = , > + ; > + bias-pull-up; > + }; > + > + pinctrl_flx10_default: flx10-default { > + pinmux = , > + ; > + bias-pull-up; > + }; > + > + pinctrl_key_gpio_default: key-gpio-default { > + pinmux = ; > + bias-pull-up; > + }; > + > + pinctrl_led_gpio_default: led-gpio-default { > + pinmux = , > + , > + ; > + bias-pull-up; > + }; > + > + pinctrl_mikrobus1_an_default: mikrobus1-an-default { > + pinmux = ; > + bias-disable; > + }; > + > + pinctrl_mikrobus2_an_default: mikrobus2-an-default { > + pinmux = ; > + bias-disable; > + }; > + > + pinctrl_nand_default: nand-default { > + pinmux = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + bias-disable; > + slew-rate = <0>; > + }; > + > + pinctrl_qspi1_default: qspi1-default { > + pinmux = , > + , > + , > + , > + , > + ; > + bias-pull-up; > + slew-rate = <0>; > + }; > + > + pinctrl_sdmmc0_default: sdmmc0-default { > + pinmux = , > + , > + , > + , > + , > + , > + ; > + bias-pull-up; > + slew-rate = <0>; > + }; > + > + pinctrl_sdmmc1_default: sdmmc1-default { > + pinmux = , > + , > + , > + , > + , > + , > + ; > + bias-pull-up; > + slew-rate = <0>; > + }; > +}; > + > +&rtt { > + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; > +}; > + > +// M.2 slot for wireless card Use C style comment instead /* */ > +&sdmmc0 { > + bus-width = <4>; > + cd-gpios = <&pioA 31 GPIO_ACTIVE_LOW>; > + disable-wp; > + sdhci-caps-mask = <0x0 0x00200000>; > + vmmc-supply = <&vdd_3v3>; > + vqmmc-supply = <&vdd_3v3>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sdmmc0_default>; > + status = "okay"; > +}; > + > +// micro SD socket > +&sdmmc1 { > + bus-width = <4>; > + disable-wp; > + sdhci-caps-mask = <0x0 0x00200000>; > + vmmc-supply = <&vdd_3v3>; > + vqmmc-supply = <&vdd_3v3>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sdmmc1_default>; > + status = "okay"; > +}; > + > +&slow_xtal { > + clock-frequency = <32768>; > +}; > + > +&shdwc { > + debounce-delay-us = <976>; > + status = "okay"; > + > + input@0 { > + reg = <0>; > + }; > +}; > + > +&tcb0 { > + timer0: timer@0 { > + compatible = "atmel,tcb-timer"; > + reg = <0>; > + }; > + > + timer1: timer@1 { > + compatible = "atmel,tcb-timer"; > + reg = <1>; > + }; > +}; > + > +&trng { > + status = "okay"; > +}; > + > +&vddout25 { > + vin-supply = <&vdd_3v3>; > + status = "okay"; > +};