From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6496B22333A for ; Tue, 8 Apr 2025 15:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744125488; cv=none; b=gLqDATltgQEHHe87nI9Utc1WkejG1h1DsKTuclsDLXSUv26EZrkTh1bXPhgACUAINtMJpGXTSlbYM9hlnVY1VfK4+xm1+MxeWQ8uH5FiR74KV1u5NpUrgNvmAPcZwFU6526djil5yzkRBKip8JsGYRvpEZEFj7kRI8T3VaOySvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744125488; c=relaxed/simple; bh=R7gt85kpHUgOXrzFifbXZ9lqyoRD668hCe7Kpfratak=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gyPNQo6fR74aDSZ6qACYPIm0YvKTdtYkmrP8tUDcktivE2uqyvGoDlzoChOY+9ZjpqsaW78f/0/laDv6TKbHWkl5BD+eXvQxnvIiUG2shRfMQT6swGkhBfEQLS6cKqCDolRDOlBrIIjVopErgdPRyiRXpwlps2zpI+y3ncdMvi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=qYN9elIQ; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="qYN9elIQ" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744125482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6A0hK4GqrFidtzfUsz5pZ3otqeWdeUksBm3Ffeph64Q=; b=qYN9elIQgFBvOhzsXh3Ym4aLFX9ciaThNCjNQYCkgf6ZQB63IU9qXvViaXtNZ3HsvQ90R2 bXwC/4E6c8pVQoaCzqtHCDvwW1Y9QVSXLmO7XXnkXVMao7Ct/yZv1K1u/knJG7IlU0EOxa VCPfs97vLfLKyJjO9Ti4Badxnbc5Kjk= Date: Tue, 8 Apr 2025 11:17:52 -0400 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [RFC net-next PATCH 00/13] Add PCS core support To: Daniel Golle , "Christian Marangi (Ansuel)" Cc: Kory Maincent , netdev@vger.kernel.org, Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , linux-kernel@vger.kernel.org, upstream@airoha.com, Heiner Kallweit , Alexandre Belloni , Alexandre Torgue , Christophe Leroy , Clark Wang , Claudiu Beznea , Claudiu Manoil , Conor Dooley , Ioana Ciornei , Jonathan Corbet , Joyce Ooi , Krzysztof Kozlowski , Krzysztof Kozlowski , Li Yang , Madalin Bucur , Madhavan Srinivasan , Maxime Coquelin , Michael Ellerman , Michal Simek , Naveen N Rao , Nicholas Piggin , Nicolas Ferre , Radhey Shyam Pandey , Rob Herring , Rob Herring , Robert Hancock , Saravana Kannan , Shawn Guo , UNGLinuxDriver@microchip.com, Vladimir Oltean , Wei Fang , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linuxppc-dev@lists.ozlabs.org References: <20250403181907.1947517-1-sean.anderson@linux.dev> <20250407182738.498d96b0@kmaincent-XPS-13-7390> <720b6db8-49c5-47e7-98da-f044fc38fc1a@linux.dev> <1aec6dab-ed03-4ca3-8cd1-9cfbb807be10@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 4/7/25 13:25, Daniel Golle wrote: > On Mon, Apr 07, 2025 at 07:21:38PM +0200, Christian Marangi (Ansuel) wrote: >> Il giorno lun 7 apr 2025 alle ore 19:00 Sean Anderson >> > I agree that a "cells" approach would require this, but >> > >> > - There are no in-tree examples of where this is necessary >> > - I think this would be easy to add when necessary >> > >> >> There are no in-tree cause only now we are starting to support >> complex configuration with multiple PCS placed outside the MAC. >> >> I feel it's better to define a standard API for them now before >> we permit even more MAC driver to implement custom property >> and have to address tons of workaround for compatibility. > > Qualcomm's PCS driver will require offering multiple phylink_pcs by a > single device/of_node. So while it's true that there is currently no > in-tree user for that, that very user is already knocking on our doors. > > See > https://patchwork.kernel.org/project/netdevbpf/list/?series=931658&state=* OK, but you have separate nodes for each PCS? So maybe the best thing is to allow customizing the fwnode? E.g. something like pcs_register_fwnode(struct device *dev, struct phylink_pcs *pcs, struct fwnode_handle *fwnode) --Sean