From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Robert Marko <robimarko@gmail.com>
Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node with bindings
Date: Sat, 12 Aug 2023 12:47:56 +0200 [thread overview]
Message-ID: <e784f70f-3232-42e6-bf4c-67075abd210a@linaro.org> (raw)
In-Reply-To: <CAOX2RU6nMvpTkGdwBoLJrES5v0qARnDDT6nCVd-DZid7p3pg6Q@mail.gmail.com>
On 12.08.2023 11:55, Robert Marko wrote:
> On Sat, 12 Aug 2023 at 00:56, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> On 11.08.2023 23:35, Robert Marko wrote:
>>> On Fri, 11 Aug 2023 at 23:28, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>>>
>>>> On 11.08.2023 23:01, Robert Marko wrote:
>>>>> Rename the SPI-NOR node to flash@0, remove #address-cells and #size-cells
>>>>> as they should be under the partitions subnode and use the generic
>>>>> jedec,spi-nor compatible.
>>>>>
>>>>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>>>>> ---
>>>> You can also do "nandmanufacturer,mx25l25635e", "jedec,spi-nor"
>>>
>>> Hi,
>>> I grepped the vendor U-Boot to make sure it's not being triggered off
>>> the mx25l25635e
>>> compatible but the only hit is the IC support itself.
>>> MX25L25635 was just the original NOR IC Qualcomm used on the board so
>>> to me it made
>>> most sense to just use the JEDEC compatible as NOR itself is JEDEC NOR
>>> compatible.
>> OK if dynamic identification works fine
>
> It should work fine, datasheet is clear that its JEDEC compatible.
> That being said, I dont actually have the board, just figured it was
> time for a cleanup as
> OpenWrt has been patching DK01 and DK04 for ages.
Hm. Do we know whether there are still users of this boards?
Konrad
next prev parent reply other threads:[~2023-08-12 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 21:01 [PATCH 1/2] ARM: dts: qcom: ipq4019-ap.dk01.1: use existing labels for nodes Robert Marko
2023-08-11 21:01 ` [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node with bindings Robert Marko
2023-08-11 21:28 ` Konrad Dybcio
2023-08-11 21:35 ` Robert Marko
2023-08-11 22:56 ` Konrad Dybcio
2023-08-12 9:55 ` Robert Marko
2023-08-12 10:47 ` Konrad Dybcio [this message]
2023-08-12 14:07 ` Robert Marko
2023-08-12 14:08 ` Konrad Dybcio
2023-08-12 14:12 ` Robert Marko
2023-08-12 14:15 ` Konrad Dybcio
2023-08-14 10:54 ` Robert Marko
2023-08-11 21:27 ` [PATCH 1/2] ARM: dts: qcom: ipq4019-ap.dk01.1: use existing labels for nodes Konrad Dybcio
2023-08-11 21:38 ` Robert Marko
2024-01-28 17:45 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e784f70f-3232-42e6-bf4c-67075abd210a@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).