From: Yixun Lan <yixun.lan@amlogic.com>
To: Rob Herring <robh@kernel.org>
Cc: yixun.lan@amlogic.com, Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Liang Yang <liang.yang@amlogic.com>,
Qiufang Dai <qiufang.dai@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>,
linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] clk: meson: add DT documentation for emmc clock controller
Date: Fri, 27 Jul 2018 22:14:28 +0800 [thread overview]
Message-ID: <e797412b-55db-6678-82ba-3a10ac99db9f@amlogic.com> (raw)
In-Reply-To: <20180724232917.GA27041@rob-hp-laptop>
HI Rob
On 07/25/2018 07:29 AM, Rob Herring wrote:
> On Thu, Jul 12, 2018 at 09:12:43PM +0000, Yixun Lan wrote:
>> Document the MMC sub clock controller driver, the potential consumer
>> of this driver is MMC or NAND. Also add three clock bindings IDs which
>> provided by this driver.
>>
>> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
>> ---
>> .../bindings/clock/amlogic,mmc-clkc.txt | 31 +++++++++++++++++++
>> .../clock/amlogic,meson-mmc-clkc.h | 16 ++++++++++
>> 2 files changed, 47 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt
>> create mode 100644 include/dt-bindings/clock/amlogic,meson-mmc-clkc.h
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
Thanks for the review!
There is a discussion about dropping "meson-" prefix in the compatible
string[1]
So, I will send another version with the new compatible name adjusted
from "amlogic,meson-axg-mmc-clkc" to "amlogic,axg-mmc-clkc"..
probably also rename the dt-bindings header file to amlogc,mmc-clkc.h
[1] https://lkml.kernel.org/r/7hk1prmg4w.fsf@baylibre.com
Yixun
next prev parent reply other threads:[~2018-07-27 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 21:12 [PATCH v3 0/2] clk: meson: add a sub EMMC clock controller support Yixun Lan
2018-07-12 21:12 ` [PATCH v3 1/2] clk: meson: add DT documentation for emmc clock controller Yixun Lan
2018-07-24 23:29 ` Rob Herring
2018-07-27 14:14 ` Yixun Lan [this message]
2018-07-30 17:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e797412b-55db-6678-82ba-3a10ac99db9f@amlogic.com \
--to=yixun.lan@amlogic.com \
--cc=boris.brezillon@bootlin.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=qiufang.dai@amlogic.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).