From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B43C001DB for ; Wed, 14 Jun 2023 16:44:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235249AbjFNQoJ (ORCPT ); Wed, 14 Jun 2023 12:44:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235419AbjFNQoF (ORCPT ); Wed, 14 Jun 2023 12:44:05 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F9631715 for ; Wed, 14 Jun 2023 09:44:03 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4f6370ddd27so9009925e87.0 for ; Wed, 14 Jun 2023 09:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686761041; x=1689353041; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LoRkuZWKxXpO3J/KC+IKFD8g8mKdOUzqHFsg3wN8y24=; b=OnQ4J+jdcEF8VPuCQDInjVYV4JwdlOb2uvVVI05qtvi/p0SU8D9rnDxfo3GRb2ZtGb LXruHGFdfkWmbo6TJCvIoso9MpI4WYFMboDAMCUI0jWwpSOUFoDIpzZYP5g+eSD4aegP DjIoOAHJy28Nd85oH5LylGUtrLxjdRPfYdcZfCfDaLZEE3zq/42Ome55seVJu3Q+6I6d givuBku+v16WAbkT7HcmejIgL1/etgKHVdWpI1H6LEuKEKIIJh0hNOhK6IF53bOWsE1e 4II6o6MHxr8bjwIYBmA6+HvlEbMVmpN2jcCttVlxTpwHUNUs8Ab9Y7cAukYV3C42tBjg R5Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686761041; x=1689353041; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LoRkuZWKxXpO3J/KC+IKFD8g8mKdOUzqHFsg3wN8y24=; b=WvSAeW1mIZNez3xex1uUR8DTSFNnPPsrQsCThh8a5Ai8Far3zJ2k0aXAZH/+B7Vixt cuBXJD/ToZqLchxI5xrw/gtL6h6q6/thQKh1Kh6oFvETinR+PgCbN8RCEpgCEBqVAV7X hKemxjb4U5z4WFD1u3X2InBIlu59XCwmeboCkzSbbRDtFX3lvBW0Db5ML4mzP7qEyjfy bG+6p+cZgBMFLEvDxuEN3A5mw8ol9tZXduLCj+y9Yxd1GMuJl2QiLTwTyTyDqz9R8UKR bZ9Pxy4wyWC/RLhIREA2h4WpIvK8l0n2t0M7YYaaER9jA5eklLlDSaYosnLzsbsCF9K7 ePvQ== X-Gm-Message-State: AC+VfDxYpgJPEK6EbcNM/wxuKAVfjz9l2EiXnitm4vqX7o0RTDJUuiAV z8vOQZxsmLFmjmHf9JpGRIFFFQ== X-Google-Smtp-Source: ACHHUZ703F8I5NcUh0f3StepCVewSGbe/tDeK2wzqjBWf/RxopRjyygwdOi2PuxGfI4iFdELFB9mHQ== X-Received: by 2002:a19:6d1c:0:b0:4f3:82a8:dcfc with SMTP id i28-20020a196d1c000000b004f382a8dcfcmr7433304lfc.55.1686761041289; Wed, 14 Jun 2023 09:44:01 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id q28-20020ac25a1c000000b004f643664882sm2180612lfn.147.2023.06.14.09.43.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 09:44:00 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 18:43:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v5 01/22] dt-bindings: interconnect: Add Qcom RPM ICC bindings Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Georgi Djakov , Leo Yan , Evan Green , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org References: <20230526-topic-smd_icc-v5-0-eeaa09d0082e@linaro.org> <20230526-topic-smd_icc-v5-1-eeaa09d0082e@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14.06.2023 18:43, Krzysztof Kozlowski wrote: > On 14/06/2023 12:22, Konrad Dybcio wrote: >> The SMD RPM interconnect driver requires different icc tags to the >> RPMh driver. Add bindings to reflect that. >> >> Signed-off-by: Konrad Dybcio >> --- >> include/dt-bindings/interconnect/qcom,rpm-icc.h | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/include/dt-bindings/interconnect/qcom,rpm-icc.h b/include/dt-bindings/interconnect/qcom,rpm-icc.h >> new file mode 100644 >> index 000000000000..2cd56f91e5c5 >> --- /dev/null >> +++ b/include/dt-bindings/interconnect/qcom,rpm-icc.h >> @@ -0,0 +1,13 @@ >> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >> +/* >> + * Copyright (c) 2023, Linaro Limited >> + */ >> + >> +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H >> +#define __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H >> + >> +#define RPM_ACTIVE_TAG (1 << 0) >> +#define RPM_SLEEP_TAG (1 << 1) >> +#define RPM_ALWAYS_TAG (RPM_ACTIVE_TAG | RPM_SLEEP_TAG) > > Where are these used? I don't see any DTS in your patchset. Did you send > it separately? In the driver for now, e.g. patch 19. DTS can only come after the driver is fixed or things will explode! Konrad > > Best regards, > Krzysztof >