RE: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

[Christoph Niedermaier <cniedermaier@dh-electronics.com>]

From: Marek Vasut [mailto:marex@denx.de]
Sent: Wednesday, April 5, 2023 6:25 PM
> On 4/5/23 18:02, Christoph Niedermaier wrote:
> 
> [...]
> 
>> +/ {
>> +     model = "DH electronics i.MX6ULL DHCOR on maveo box";
>> +     compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
>> +                  "fsl,imx6ull";
>> +
>> +     aliases {
>> +             /delete-property/ mmc0; /* Avoid double definitions */
>> +             /delete-property/ mmc1;
>> +             mmc2 = &usdhc2; /* eMMC should be mmc2 */
> 
> Why not mmc0 ?
> 
> Use root=PARTUUID= when booting to avoid any dependency on
> root=/dev/mmcblk2pN enumeration.

This is due to software interchangeability with the DHCOM
i.MX6ULL, where the eMMC is always mmc2.

> 
>> +             spi0 = &ecspi4;
>> +             spi3 = &ecspi1;
>> +     };
> 
> [...]
> 
>> +&iomuxc {
>> +     pinctrl-0 = <&pinctrl_hog_maveo_box>;
>> +     pinctrl-names = "default";
>> +
>> +     pinctrl_hog_maveo_box: hog-maveo-box-grp {
>> +             fsl,pins = <
>> +                     MX6UL_PAD_GPIO1_IO05__GPIO1_IO05        0x400120b0 /* BUTTON_USER */
>> +                     MX6UL_PAD_GPIO1_IO08__GPIO1_IO08        0x400120b0 /* BUTTON_RESET */
>> +                     MX6UL_PAD_CSI_PIXCLK__GPIO4_IO18        0x400120b0 /* LED_G */
>> +                     MX6UL_PAD_CSI_DATA02__GPIO4_IO23        0x400120b0 /* LED_B */
> 
> Should the "SION(1 << 30): Software Input On Field." bit really be set
> on GPIOs which are OUTPUT (like LEDs) ?

I think for INPUT it doesn't matter, but for OUTPUT I then have a feedback.

Regards
Christoph