Re: [PATCH v4 1/4] arm64: dts: qcom: monaco-evk: Extract common EVK hardware into shared dtsi

Dmitry Baryshkov
2026-05-04T23:28:29Z

On Tue, May 05, 2026 at 12:56:15AM +0530, Umang Chheda wrote:
> Hello Dmitry,
>
>
> On 5/5/2026 12:14 AM, Dmitry Baryshkov wrote:
> > On Mon, Apr 27, 2026 at 10:35:02PM +0530, Umang Chheda wrote:
> >> The monaco-ac EVK is a new board variant which shares the majority of
> >> its hardware description with the existing monaco-evk board.
> >
> > No, this is not a good reason. Is there a common PCB? There was a long
> > discussion for it for the Hamoa / Purwa EVK.
>
> PCB is not common for these 2 boards.
>
> Also, not sure if I mis-understood you - You had mentioned to have a
> common file for both the variants [1] in the earlier version of patch
> hence refactored it this way.

There was an explicit question if PCB is the same as a prerequisite for
the unification of DTS

>
> [1]
> https://lore.kernel.org/lkml/7r6373fo56alzqa4e2zzdnsgwfhgdkmbhxe4cvdo4p7fg3zren@eyiml4uedfbn/
>
> >
> >>
> >> In preparation for adding this variant, extract the common hardware
> >> nodes from monaco-evk.dts into a new shared monaco-evk-common.dtsi
> >> include file, and update monaco-evk.dts to include it and keep only
> >> board-specific overrides.
> >>
> >> No functional change intended.
> >>
> >> Signed-off-by: Umang Chheda <umang.chheda@oss.qualcomm.com>
> >> ---
> >
>
> Thanks,
> Umang
>

--
With best wishes
Dmitry