From: Krzysztof Kozlowski <krzk@kernel.org>
To: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sibi Sankar <quic_sibis@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_okukatla@quicinc.com, quic_mdtipton@quicinc.com
Subject: Re: [PATCH 3/3] interconnect: qcom: Add EPSS L3 support on SA8775P
Date: Sat, 26 Oct 2024 13:28:30 +0200 [thread overview]
Message-ID: <e7ce51a1-97a1-4d54-a1d4-0f6d279a9055@kernel.org> (raw)
In-Reply-To: <6b89de85-58c0-4808-9a33-6ee7dc26611d@quicinc.com>
On 25/10/2024 17:38, Raviteja Laggyshetty wrote:
>
>
> On 9/6/2024 10:00 PM, Krzysztof Kozlowski wrote:
>> On 06/09/2024 17:32, Raviteja Laggyshetty wrote:
>>>
>>> On 9/4/2024 11:52 PM, Krzysztof Kozlowski wrote:
>>>> On 04/09/2024 19:12, Raviteja Laggyshetty wrote:
>>>>> +
>>>>> static const struct qcom_osm_l3_desc epss_l3_l3_vote = {
>>>>> .nodes = epss_l3_nodes,
>>>>> .num_nodes = ARRAY_SIZE(epss_l3_nodes),
>>>>> @@ -284,6 +307,10 @@ static const struct of_device_id osm_l3_of_match[] = {
>>>>> { .compatible = "qcom,sm8150-osm-l3", .data = &osm_l3 },
>>>>> { .compatible = "qcom,sc8180x-osm-l3", .data = &osm_l3 },
>>>>> { .compatible = "qcom,sm8250-epss-l3", .data = &epss_l3_perf_state },
>>>>> + { .compatible = "qcom,sa8775p-epss-l3-cl0",
>>>>> + .data = &epss_l3_perf_state },
>>>> Don't grow it but express compatibility.
>>> ok. Will rename compatible from "qcom,sa8775p-epss-l3-cl0" to "qcom,sa8775p-epss-l3".
>>
>> This won't solve the problem. You still grow the table, right?
>
> Falling back to "qcom,epss-l3" won't work because we need to vote into perf state register.
> I am introducing a new fallback compatible "qcom,epss-l3-perf" for perf voting, which can be used for upcoming qcs8300.
Maybe, no clue, this was 1.5 months ago. I don't have original patches
in the inbox anymore.
Just choose something sensible following writing bindings guideline.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-26 11:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 17:12 [PATCH 0/3] Add EPSS L3 provider support on SA8775P SoC Raviteja Laggyshetty
2024-09-04 17:12 ` [PATCH 1/3] dt-bindings: interconnect: Add EPSS L3 compatible for SA8775P Raviteja Laggyshetty
2024-09-04 18:23 ` Krzysztof Kozlowski
2024-10-25 15:36 ` Raviteja Laggyshetty
2024-09-04 17:12 ` [PATCH 2/3] arm64: dts: qcom: sa8775p: add EPSS l3 interconnect provider Raviteja Laggyshetty
2024-09-04 17:12 ` [PATCH 3/3] interconnect: qcom: Add EPSS L3 support on SA8775P Raviteja Laggyshetty
2024-09-04 18:22 ` Krzysztof Kozlowski
[not found] ` <bfcc65b2-97a4-4353-a2fd-dce927c53428@quicinc.com>
2024-09-06 16:30 ` Krzysztof Kozlowski
2024-10-25 15:38 ` Raviteja Laggyshetty
2024-10-26 11:28 ` Krzysztof Kozlowski [this message]
2024-10-26 12:24 ` Konrad Dybcio
2024-10-26 12:26 ` Krzysztof Kozlowski
2024-09-09 11:44 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7ce51a1-97a1-4d54-a1d4-0f6d279a9055@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).