Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property

From: Philippe CORNU <philippe.cornu@st.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Mickael REULIER <mickael.reulier@st.com>,
	Russell King <linux@armlinux.org.uk>,
	Fabien DESSENNE <fabien.dessenne@st.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Vincent ABRIOU <vincent.abriou@st.com>,
	Ludovic BARRE <ludovic.barre@st.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Yannick FERTRE <yannick.fertre@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
	Bhumika Goyal <bhumirks@gmail.com>
Subject: Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
Date: Fri, 27 Oct 2017 14:52:21 +0000	[thread overview]
Message-ID: <e7f46e2c-2cd9-bdd4-221a-109cdc9852b1@st.com> (raw)
In-Reply-To: <20171027143815.evbb7rqkgqiol7yo@rob-hp-laptop>

Hi Rob,

On 10/27/2017 04:38 PM, Rob Herring wrote:
> On Thu, Oct 26, 2017 at 06:12:36PM +0200, Philippe Cornu wrote:
>> Add the DPI/RGB input pixel clock in mandatory properties
>> because it really offers a better preciseness for timing
>> computations.
>> Note: Fix also the DSI panel example where "ref" & "pclk"
>> clocks were swapped.
>>
>> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
>> ---
>>   Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> index 0292522..99823fb 100644
>> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> @@ -28,6 +28,7 @@ Mandatory properties specific to STM32 DSI:
>>   - #size-cells: Should be <0>.
>>   - compatible: "st,stm32-dsi".
>>   - clock-names:
>> +  - DPI/RGB input pixel clock string name, must be "px_clk".
>>     - phy pll reference clock string name, must be "ref".
> 
> Where's pclk?

pclk is described in the generic part 
(Documentation/devicetree/bindings/display/bridge/dw_mipi_dsi.txt) as 
mandatory.

In st,stm32-ltdc.txt (specific part), I have documented that "For all 
mandatory properties & nodes, please refer to the related documentation 
in [5]".

Do you think it is clear enough?

> 
> The new clock should be last to be backwards compatible.
> 

ok.

Many thanks for your review and your support,

Philippe :-)

>>   - resets: see [5].
>>   - reset-names: see [5].
>> @@ -97,8 +98,9 @@ Example 2: DSI panel
>>   			#size-cells = <0>;
>>   			compatible = "st,stm32-dsi";
>>   			reg = <0x40016c00 0x800>;
>> -			clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
>> -			clock-names = "ref", "pclk";
>> +			clocks = <&rcc 1 CLK_F469_DSI>, <&rcc 1 CLK_LCD>,
>> +				 <&clk_hse>;
>> +			clock-names = "pclk", "px_clk", "ref";
>>   			resets = <&rcc STM32F4_APB2_RESET(DSI)>;
>>   			reset-names = "apb";
>>   
>> -- 
>> 1.9.1
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel