* [PATCH 0/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree
@ 2023-12-13 20:33 André Apitzsch
2023-12-13 20:33 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G 4G André Apitzsch
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: André Apitzsch @ 2023-12-13 20:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, André Apitzsch
This dts adds support for Motorola Moto G 4G released in 2013.
Add a device tree with initial support for:
- GPIO keys
- Hall sensor
- SDHCI
- Vibrator
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
André Apitzsch (2):
dt-bindings: arm: qcom: Add Motorola Moto G 4G
ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
arch/arm/boot/dts/qcom/Makefile | 1 +
.../dts/qcom/qcom-msm8926-motorola-peregrine.dts | 297 +++++++++++++++++++++
3 files changed, 299 insertions(+)
---
base-commit: 48e8992e33abf054bcc0bb2e77b2d43bb899212e
change-id: 20231208-peregrine-902ab2fb2cf5
Best regards,
--
André Apitzsch <git@apitzsch.eu>
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G 4G 2023-12-13 20:33 [PATCH 0/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree André Apitzsch @ 2023-12-13 20:33 ` André Apitzsch 2023-12-14 7:32 ` Krzysztof Kozlowski 2023-12-13 20:33 ` [PATCH 2/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree André Apitzsch 2023-12-13 20:44 ` [PATCH 0/2] " Konrad Dybcio 2 siblings, 1 reply; 8+ messages in thread From: André Apitzsch @ 2023-12-13 20:33 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, ~postmarketos/upstreaming, André Apitzsch Document the compatible for the MSM8926-based Motorola Moto G 4G smartphone. Signed-off-by: André Apitzsch <git@apitzsch.eu> --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index c968412d86b8..91dc3205d09e 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -185,6 +185,7 @@ properties: - enum: - microsoft,superman-lte - microsoft,tesla + - motorola,peregrine - const: qcom,msm8926 - const: qcom,msm8226 -- 2.43.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G 4G 2023-12-13 20:33 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G 4G André Apitzsch @ 2023-12-14 7:32 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2023-12-14 7:32 UTC (permalink / raw) To: André Apitzsch, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, ~postmarketos/upstreaming On 13/12/2023 21:33, André Apitzsch wrote: > Document the compatible for the MSM8926-based Motorola Moto G 4G smartphone. > > Signed-off-by: André Apitzsch <git@apitzsch.eu> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree 2023-12-13 20:33 [PATCH 0/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree André Apitzsch 2023-12-13 20:33 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G 4G André Apitzsch @ 2023-12-13 20:33 ` André Apitzsch 2023-12-14 7:33 ` Krzysztof Kozlowski 2023-12-13 20:44 ` [PATCH 0/2] " Konrad Dybcio 2 siblings, 1 reply; 8+ messages in thread From: André Apitzsch @ 2023-12-13 20:33 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, ~postmarketos/upstreaming, André Apitzsch This dts adds support for Motorola Moto G 4G released in 2013. Add a device tree with initial support for: - GPIO keys - Hall sensor - SDHCI - Vibrator Signed-off-by: André Apitzsch <git@apitzsch.eu> --- arch/arm/boot/dts/qcom/Makefile | 1 + .../dts/qcom/qcom-msm8926-motorola-peregrine.dts | 297 +++++++++++++++++++++ 2 files changed, 298 insertions(+) diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile index 0cb272f4fa45..9cc1e14e6cd0 100644 --- a/arch/arm/boot/dts/qcom/Makefile +++ b/arch/arm/boot/dts/qcom/Makefile @@ -35,6 +35,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ qcom-msm8926-htc-memul.dtb \ qcom-msm8926-microsoft-superman-lte.dtb \ qcom-msm8926-microsoft-tesla.dtb \ + qcom-msm8926-motorola-peregrine.dtb \ qcom-msm8960-cdp.dtb \ qcom-msm8960-samsung-expressatt.dtb \ qcom-msm8974-lge-nexus5-hammerhead.dtb \ diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-motorola-peregrine.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-motorola-peregrine.dts new file mode 100644 index 000000000000..3c5256120502 --- /dev/null +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-motorola-peregrine.dts @@ -0,0 +1,297 @@ +// SPDX-License-Identifier: BSD-3-Clause + +/dts-v1/; + +#include "qcom-msm8226.dtsi" +#include "pm8226.dtsi" + +/delete-node/ &smem_region; + +/ { + model = "Motorola Moto G 4G"; + compatible = "motorola,peregrine", "qcom,msm8926", "qcom,msm8226"; + chassis-type = "handset"; + + aliases { + mmc0 = &sdhc_1; /* SDC1 eMMC slot */ + mmc1 = &sdhc_2; /* SDC2 SD card slot */ + }; + + chosen { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + framebuffer0: framebuffer@3200000 { + compatible = "simple-framebuffer"; + reg = <0x03200000 0x800000>; + width = <720>; + height = <1280>; + stride = <(720 * 3)>; + format = "r8g8b8"; + }; + }; + + gpio-hall-sensor { + compatible = "gpio-keys"; + + label = "GPIO Hall Effect Sensor"; + + event-hall-sensor { + label = "Hall Effect Sensor"; + gpios = <&tlmm 51 GPIO_ACTIVE_LOW>; + linux,input-type = <EV_SW>; + linux,code = <SW_LID>; + linux,can-disable; + }; + }; + + gpio-keys { + compatible = "gpio-keys"; + + key-volume-up { + label = "Volume Up"; + gpios = <&tlmm 106 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEUP>; + debounce-interval = <15>; + }; + }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + framebuffer@3200000 { + reg = <0x03200000 0x800000>; + no-map; + }; + + smem_region: smem@fa00000 { + reg = <0x0fa00000 0x100000>; + no-map; + }; + }; +}; + +&blsp1_i2c3 { + status = "okay"; + + sensor@48 { + compatible = "ti,tmp108"; + reg = <0x48>; + }; +}; + +&blsp1_uart3 { + status = "okay"; +}; + +&pm8226_resin { + linux,code = <KEY_VOLUMEDOWN>; + status = "okay"; +}; + +&pm8226_vib { + status = "okay"; +}; + +&rpm_requests { + regulators { + compatible = "qcom,rpm-pm8226-regulators"; + + pm8226_s3: s3 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1300000>; + }; + + pm8226_s4: s4 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2200000>; + }; + + pm8226_s5: s5 { + regulator-min-microvolt = <1150000>; + regulator-max-microvolt = <1150000>; + }; + + pm8226_l1: l1 { + regulator-min-microvolt = <1225000>; + regulator-max-microvolt = <1225000>; + }; + + pm8226_l2: l2 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + }; + + pm8226_l3: l3 { + regulator-min-microvolt = <750000>; + regulator-max-microvolt = <1337500>; + }; + + pm8226_l4: l4 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + }; + + pm8226_l5: l5 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + }; + + pm8226_l6: l6 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-allow-set-load; + }; + + pm8226_l7: l7 { + regulator-min-microvolt = <1850000>; + regulator-max-microvolt = <1850000>; + }; + + pm8226_l8: l8 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8226_l9: l9 { + regulator-min-microvolt = <2050000>; + regulator-max-microvolt = <2050000>; + }; + + pm8226_l10: l10 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8226_l12: l12 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + pm8226_l14: l14 { + regulator-min-microvolt = <2750000>; + regulator-max-microvolt = <2750000>; + }; + + pm8226_l15: l15 { + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + }; + + pm8226_l16: l16 { + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3350000>; + }; + + pm8226_l17: l17 { + regulator-min-microvolt = <2950000>; + regulator-max-microvolt = <2950000>; + }; + + pm8226_l18: l18 { + regulator-min-microvolt = <2950000>; + regulator-max-microvolt = <2950000>; + }; + + pm8226_l19: l19 { + regulator-min-microvolt = <2850000>; + regulator-max-microvolt = <2850000>; + }; + + pm8226_l20: l20 { + regulator-min-microvolt = <3075000>; + regulator-max-microvolt = <3075000>; + }; + + pm8226_l21: l21 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2950000>; + regulator-allow-set-load; + }; + + pm8226_l22: l22 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2950000>; + }; + + pm8226_l23: l23 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2950000>; + }; + + pm8226_l24: l24 { + regulator-min-microvolt = <1300000>; + regulator-max-microvolt = <1350000>; + }; + + pm8226_l25: l25 { + regulator-min-microvolt = <1775000>; + regulator-max-microvolt = <2125000>; + }; + + pm8226_l26: l26 { + regulator-min-microvolt = <1225000>; + regulator-max-microvolt = <1225000>; + }; + + pm8226_l27: l27 { + regulator-min-microvolt = <2050000>; + regulator-max-microvolt = <2050000>; + }; + + pm8226_l28: l28 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3400000>; + regulator-boot-on; + }; + + pm8226_lvs1: lvs1 { + /* Pull-up for I2C lines */ + regulator-always-on; + }; + }; +}; + +&sdhc_1 { + vmmc-supply = <&pm8226_l17>; + vqmmc-supply = <&pm8226_l6>; + + bus-width = <8>; + non-removable; + + status = "okay"; +}; + +&sdhc_2 { + vmmc-supply = <&pm8226_l18>; + vqmmc-supply = <&pm8226_l21>; + + bus-width = <4>; + cd-gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; + + status = "okay"; +}; + +&smbb { + qcom,fast-charge-safe-current = <2000000>; + qcom,fast-charge-current-limit = <1900000>; + qcom,fast-charge-safe-voltage = <4400000>; + qcom,minimum-input-voltage = <4300000>; + + status = "okay"; +}; + +&usb { + extcon = <&smbb>; + dr_mode = "peripheral"; + status = "okay"; +}; + +&usb_hs_phy { + extcon = <&smbb>; + v1p8-supply = <&pm8226_l10>; + v3p3-supply = <&pm8226_l20>; +}; -- 2.43.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree 2023-12-13 20:33 ` [PATCH 2/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree André Apitzsch @ 2023-12-14 7:33 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2023-12-14 7:33 UTC (permalink / raw) To: André Apitzsch, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, ~postmarketos/upstreaming On 13/12/2023 21:33, André Apitzsch wrote: > This dts adds support for Motorola Moto G 4G released in 2013. > > Add a device tree with initial support for: > > - GPIO keys > - Hall sensor > - SDHCI > - Vibrator > > Signed-off-by: André Apitzsch <git@apitzsch.eu> > --- > arch/arm/boot/dts/qcom/Makefile | 1 + > .../dts/qcom/qcom-msm8926-motorola-peregrine.dts | 297 +++++++++++++++++++++ > 2 files changed, 298 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile > index 0cb272f4fa45..9cc1e14e6cd0 100644 > --- a/arch/arm/boot/dts/qcom/Makefile > +++ b/arch/arm/boot/dts/qcom/Makefile > @@ -35,6 +35,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ > qcom-msm8926-htc-memul.dtb \ > qcom-msm8926-microsoft-superman-lte.dtb \ > qcom-msm8926-microsoft-tesla.dtb \ > + qcom-msm8926-motorola-peregrine.dtb \ > qcom-msm8960-cdp.dtb \ > qcom-msm8960-samsung-expressatt.dtb \ > qcom-msm8974-lge-nexus5-hammerhead.dtb \ > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-motorola-peregrine.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-motorola-peregrine.dts > new file mode 100644 > index 000000000000..3c5256120502 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-motorola-peregrine.dts > @@ -0,0 +1,297 @@ > +// SPDX-License-Identifier: BSD-3-Clause > + > +/dts-v1/; > + > +#include "qcom-msm8226.dtsi" > +#include "pm8226.dtsi" > + > +/delete-node/ &smem_region; > + > +/ { > + model = "Motorola Moto G 4G"; > + compatible = "motorola,peregrine", "qcom,msm8926", "qcom,msm8226"; > + chassis-type = "handset"; > + > + aliases { > + mmc0 = &sdhc_1; /* SDC1 eMMC slot */ > + mmc1 = &sdhc_2; /* SDC2 SD card slot */ > + }; > + > + chosen { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + framebuffer0: framebuffer@3200000 { > + compatible = "simple-framebuffer"; > + reg = <0x03200000 0x800000>; > + width = <720>; > + height = <1280>; > + stride = <(720 * 3)>; > + format = "r8g8b8"; > + }; > + }; > + > + gpio-hall-sensor { > + compatible = "gpio-keys"; > + > + label = "GPIO Hall Effect Sensor"; > + > + event-hall-sensor { > + label = "Hall Effect Sensor"; > + gpios = <&tlmm 51 GPIO_ACTIVE_LOW>; > + linux,input-type = <EV_SW>; > + linux,code = <SW_LID>; > + linux,can-disable; > + }; > + }; > + > + gpio-keys { No need to have two nodes for gpio-keys. Combine them. > + compatible = "gpio-keys"; > + > + key-volume-up { > + label = "Volume Up"; Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree 2023-12-13 20:33 [PATCH 0/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree André Apitzsch 2023-12-13 20:33 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G 4G André Apitzsch 2023-12-13 20:33 ` [PATCH 2/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree André Apitzsch @ 2023-12-13 20:44 ` Konrad Dybcio 2023-12-14 8:18 ` André Apitzsch 2 siblings, 1 reply; 8+ messages in thread From: Konrad Dybcio @ 2023-12-13 20:44 UTC (permalink / raw) To: André Apitzsch, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, ~postmarketos/upstreaming On 12/13/23 21:33, André Apitzsch wrote: > This dts adds support for Motorola Moto G 4G released in 2013. I have a similar one in my drawer.. not the 4g kind, titan IIRC? Wasn't this one codenamed thea? Konrad ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree 2023-12-13 20:44 ` [PATCH 0/2] " Konrad Dybcio @ 2023-12-14 8:18 ` André Apitzsch 2023-12-14 18:28 ` Konrad Dybcio 0 siblings, 1 reply; 8+ messages in thread From: André Apitzsch @ 2023-12-14 8:18 UTC (permalink / raw) To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, ~postmarketos/upstreaming Am Mittwoch, dem 13.12.2023 um 21:44 +0100 schrieb Konrad Dybcio: > > > On 12/13/23 21:33, André Apitzsch wrote: > > This dts adds support for Motorola Moto G 4G released in 2013. > I have a similar one in my drawer.. not the 4g kind, titan IIRC? > Wasn't this one codenamed thea? > > Konrad Yes, thea is the 2nd generation of Moto G 4G, released in 2014. pregrine is the first generation, from 2013. Should > model = "Motorola Moto G 4G"; be updated, to reflect that it is 1st gen or should only "thea" (if it is added at all) have an addition in the model name? André ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree 2023-12-14 8:18 ` André Apitzsch @ 2023-12-14 18:28 ` Konrad Dybcio 0 siblings, 0 replies; 8+ messages in thread From: Konrad Dybcio @ 2023-12-14 18:28 UTC (permalink / raw) To: André Apitzsch, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, ~postmarketos/upstreaming On 12/14/23 09:18, André Apitzsch wrote: > Am Mittwoch, dem 13.12.2023 um 21:44 +0100 schrieb Konrad Dybcio: >> >> >> On 12/13/23 21:33, André Apitzsch wrote: >>> This dts adds support for Motorola Moto G 4G released in 2013. >> I have a similar one in my drawer.. not the 4g kind, titan IIRC? >> Wasn't this one codenamed thea? >> >> Konrad > > Yes, thea is the 2nd generation of Moto G 4G, released in 2014. > pregrine is the first generation, from 2013. > > Should >> model = "Motorola Moto G 4G"; > be updated, to reflect that it is 1st gen or should only "thea" (if it > is added at all) have an addition in the model name? I *think* it'd be good to make it "Motorola Moto G 4G (2014)" as I think it's what it was called anyway Konrad ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-12-14 18:28 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-12-13 20:33 [PATCH 0/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree André Apitzsch 2023-12-13 20:33 ` [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G 4G André Apitzsch 2023-12-14 7:32 ` Krzysztof Kozlowski 2023-12-13 20:33 ` [PATCH 2/2] ARM: dts: qcom: msm8926-motorola-peregrine: Add initial device tree André Apitzsch 2023-12-14 7:33 ` Krzysztof Kozlowski 2023-12-13 20:44 ` [PATCH 0/2] " Konrad Dybcio 2023-12-14 8:18 ` André Apitzsch 2023-12-14 18:28 ` Konrad Dybcio
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).