From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Christopher Obbard <chris.obbard@collabora.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Johan Jonker <jbx6244@gmail.com>, Alex Bee <knaerzche@gmail.com>,
Elaine Zhang <zhangqing@rock-chips.com>
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible
Date: Mon, 25 Apr 2022 11:54:48 +0200 [thread overview]
Message-ID: <e7fa738b-774f-0763-ce0b-6a9aa0c28b3a@linaro.org> (raw)
In-Reply-To: <366fe755-6f07-499a-0b19-f046fd03c89a@collabora.com>
On 25/04/2022 11:53, Christopher Obbard wrote:
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> I acked this but Johan pointed out that your intention was different and
>> missing patch context is quite important here. Please explain what
>> exactly you wanted in the patch? Now it looks actually wrong, so my ack
>> is not correct.
>
> Wow - I think i was in weekend mode and forgot to run dtbs_check ;-).
> It will be solved in v2. I have now added the check to my "pre
> send-patch" review checklist.
>
> Just out of interest, I didn't get a mail from Johan and I can't seem to
> find it the archive either. Is that message in public as I'd like to
> address any other concerns at the same time ?
No, it wasn't public. :(
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-25 9:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 13:38 [PATCH 0/3] Rockchip RK3328 VDEC support Christopher Obbard
2022-04-22 13:38 ` [PATCH 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible Christopher Obbard
2022-04-22 16:48 ` Ezequiel Garcia
2022-04-23 11:10 ` Krzysztof Kozlowski
2022-04-23 17:31 ` Krzysztof Kozlowski
2022-04-25 9:53 ` Christopher Obbard
2022-04-25 9:54 ` Krzysztof Kozlowski [this message]
2022-04-22 13:38 ` [PATCH 2/3] arm64: dts: rockchip: Rename vdec_mmu node for RK3328 Christopher Obbard
2022-04-22 17:42 ` Ezequiel Garcia
2022-04-22 13:38 ` [PATCH 3/3] arm64: dts: rockchip: Add vdec support " Christopher Obbard
2022-04-22 17:43 ` Ezequiel Garcia
2022-04-23 17:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7fa738b-774f-0763-ce0b-6a9aa0c28b3a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chris.obbard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kernel@collabora.com \
--cc=knaerzche@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).