From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
"jk@codeconstruct.com.au" <jk@codeconstruct.com.au>,
Brendan Higgins <brendan.higgins@linux.dev>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andrew Jeffery <andrew@aj.id.au>,
Philipp Zabel <p.zabel@pengutronix.de>,
Wolfram Sang <wsa@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Jean Delvare <jdelvare@suse.de>,
William Zhang <william.zhang@broadcom.com>,
Tyrone Ting <kfting@nuvoton.com>,
Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
Conor Dooley <conor.dooley@microchip.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"=linux-kernel@vger.kernel.org" <=linux-kernel@vger.kernel.org>,
Andi Shyti <andi.shyti@kernel.org>
Subject: Re: [PATCH v12 2/2] i2c: aspeed: support ast2600 i2c new register mode driver
Date: Wed, 26 Jul 2023 08:31:54 +0200 [thread overview]
Message-ID: <e7fbf15f-dec3-ecf1-849e-faf0b3f2bc94@linaro.org> (raw)
In-Reply-To: <SEZPR06MB5269B31B3ADC4EDEA113BA99F200A@SEZPR06MB5269.apcprd06.prod.outlook.com>
On 26/07/2023 05:38, Ryan Chen wrote:
>>> +
>>> +static int ast2600_i2c_remove(struct platform_device *pdev) {
>>> + struct ast2600_i2c_bus *i2c_bus = platform_get_drvdata(pdev);
>>> +
>>> + /* Disable everything. */
>>> + writel(0, i2c_bus->reg_base + AST2600_I2CC_FUN_CTRL);
>>> + writel(0, i2c_bus->reg_base + AST2600_I2CM_IER);
>>> +
>>> + i2c_del_adapter(&i2c_bus->adap);
>>
>>> I have doubts that you tested this. I think you have here double free/del of the adapter.
>> Sorry, i can't catch your point for double free the adapter.
>> It should use i2c_del_adapter in driver remove function.
>> All the driver doing this
>> https://github.com/torvalds/linux/blob/master/drivers/i2c/busses/i2c-n
>> pcm7xx.c#L2373
>> https://github.com/torvalds/linux/blob/master/drivers/i2c/busses/i2c-a
>> ltera.c#L473
>>
>> Do you mean it is not necessary?
>
>> Instead of giving you the fish, I think much more learning experience is to teach you how to fish. Please unbind your driver (echo the device name to proper unbind file in sysfs). The best if you build your kernel with KASAN.
>
>> Thanks, will do this test with unbind to understand your point.
> I do my the test with enable kernel config KASAN.
> I don't see any error dump. You can see the following. It use i2c-0 bind/unbind.
> Did I miss some test ??
>
> root@ast2600-default:/sys/bus/platform/drivers/i2c_ast2600# i2cdetect -l
> i2c-0 i2c 1e78a080.i2c-bus I2C adapter
> i2c-1 i2c 1e78a100.i2c-bus I2C adapter
> i2c-2 i2c 1e78a180.i2c-bus I2C adapter
> i2c-3 i2c 1e78a200.i2c-bus I2C adapter
> i2c-4 i2c 1e78a280.i2c-bus I2C adapter
> i2c-5 i2c 1e78a300.i2c-bus I2C adapter
> i2c-6 i2c 1e78a380.i2c-bus I2C adapter
> i2c-7 i2c 1e78a400.i2c-bus I2C adapter
> i2c-8 i2c 1e78a480.i2c-bus I2C adapter
> i2c-9 i2c 1e78a500.i2c-bus I2C adapter
> i2c-12 i2c 1e78a680.i2c-bus I2C adapter
> i2c-13 i2c 1e78a700.i2c-bus I2C adapter
> i2c-14 i2c 1e78a780.i2c-bus I2C adapter
> i2c-15 i2c 1e78a800.i2c-bus I2C adapter
> root@ast2600-default:/sys/bus/platform/drivers/i2c_ast2600# echo 1e78a080.i2c-bus > unbind
It should fail... if it doesn't, maybe you can tell why?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-26 6:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 7:45 [PATCH v12 0/2] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2023-07-14 7:45 ` [PATCH v12 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Ryan Chen
2023-07-14 7:45 ` [PATCH v12 2/2] i2c: aspeed: support ast2600 i2c new register mode driver Ryan Chen
2023-07-14 8:03 ` Krzysztof Kozlowski
2023-07-14 8:08 ` Ryan Chen
2023-07-14 8:56 ` Andy Shevchenko
2023-07-14 8:57 ` Krzysztof Kozlowski
2023-07-14 9:26 ` Ryan Chen
2023-07-26 3:38 ` Ryan Chen
2023-07-26 6:31 ` Krzysztof Kozlowski [this message]
2023-07-26 6:19 ` Ryan Chen
2023-07-14 8:55 ` Andy Shevchenko
2023-08-31 6:04 ` Ryan Chen
2023-08-31 14:18 ` Andy Shevchenko
2023-09-05 6:52 ` Ryan Chen
2023-09-05 11:55 ` Andy Shevchenko
2023-10-05 6:21 ` Ryan Chen
2023-10-05 11:56 ` Andy Shevchenko
2023-10-11 7:36 ` Ryan Chen
2023-10-11 8:17 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7fbf15f-dec3-ecf1-849e-faf0b3f2bc94@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc==linux-kernel@vger.kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andrew@aj.id.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=brendan.higgins@linux.dev \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jdelvare@suse.de \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=william.zhang@broadcom.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).