Devicetree
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>, Lee Jones <lee@kernel.org>,
	Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kees Cook <kees+treewide@kernel.org>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: leds: skyworks,aat1290: Document AAT1270 Current Regulator for Flash LEDs
Date: Tue, 13 Oct 2026 21:37:09 +0200	[thread overview]
Message-ID: <e81313c1-361e-4f27-b578-c99171fb8877@gmail.com> (raw)
In-Reply-To: <20261013181803.496627-2-clamor95@gmail.com>

On 10/13/26 8:18 PM, Svyatoslav Ryhel wrote:
> The AAT1270 Current Regulator for Flash LEDs has a similar configuration
> to the AAT1290, but it uses a different programming model and requires a
> separate compatible.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>   .../devicetree/bindings/leds/skyworks,aat1290.yaml       | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml b/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml
> index 65576dfdca110..7c26bb135c0a7 100644
> --- a/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml
> +++ b/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml
> @@ -19,7 +19,9 @@ description: |
>   
>   properties:
>     compatible:
> -    const: skyworks,aat1290
> +    enum:
> +      - skyworks,aat1290
> +      - skyworks,aat1270
>   
>     enset-gpios:
>       maxItems: 1
> @@ -39,12 +41,13 @@ properties:
>         flash-max-microamp:
>           description: |
>             Maximum flash LED supply current can be calculated using following
> -          formula: I = 1A * 162 kOhm / Rset.
> +          formula: I = 1A * 162 kOhm / Rset (for AAT1290) and
> +          I = 1A * 81 kOhm / Rset (for AAT1270).
>   
>         flash-max-timeout-us:
>           description: |
>             Maximum flash timeout can be calculated using following formula:
> -            T = 8.82 * 10^9 * Ct.
> +          T = 8.82 * 10^9 * Ct (for AAT1290) and T = 21.5 * 10^9 * Ct (for AAT1270).
>   
>       required:
>         - flash-max-microamp

Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

-- 
Best regards,
Jacek Anaszewski


  reply	other threads:[~2026-10-13 19:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 18:18 [PATCH v2 0/3] leds: aat1290: Add support for AAT1270 Svyatoslav Ryhel
2026-10-13 18:18 ` [PATCH v2 1/3] dt-bindings: leds: skyworks,aat1290: Document AAT1270 Current Regulator for Flash LEDs Svyatoslav Ryhel
2026-10-13 19:37   ` Jacek Anaszewski [this message]
2026-10-13 18:18 ` [PATCH v2 2/3] dt-bindings: leds: skyworks,aat1290: Document FLINH pin Svyatoslav Ryhel
2026-10-13 18:18 ` [PATCH v2 3/3] leds: aat1290: Add support for AAT1270 Current Regulator for Flash LEDs Svyatoslav Ryhel
2026-10-13 18:31   ` sashiko-bot
2026-10-13 19:35   ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e81313c1-361e-4f27-b578-c99171fb8877@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kees+treewide@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox