From: Marek Vasut <marex@denx.de>
To: Adam Ford <aford173@gmail.com>, Marco Felsch <m.felsch@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Fabio Estevam <festevam@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Frank Li <Frank.Li@nxp.com>, NXP Linux Team <linux-imx@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>, Peng Fan <peng.fan@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH] arm64: dts: imx8mp: Improve VPU clock configuration
Date: Thu, 10 Aug 2023 15:20:25 +0200 [thread overview]
Message-ID: <e81c74cf-0341-fd11-d7cf-e3f257d1c056@denx.de> (raw)
In-Reply-To: <CAHCN7xKaYS_=jSxuEVNkieMe65KaJrBr+DOFWGa+8hukO8xpmQ@mail.gmail.com>
On 8/10/23 14:46, Adam Ford wrote:
> On Thu, Aug 10, 2023 at 2:42 AM Marco Felsch <m.felsch@pengutronix.de> wrote:
>>
>> Hi Marek,
>>
>> On 23-08-10, Marek Vasut wrote:
>>> Update VPU clock according to reference manual to improve performance.
>>> i.MX 8M Plus Applications Processor Reference Manual, Rev. 1, 06/2021
>>>
>>> Table 5-1. Clock Root Table (continued) reads as follows:
>>> Clock Root ............... Max Freq (MHz)
>>> VPU_BUS_CLK_ROOT ......... 800
>>> VPU_G1_CLK_ROOT .......... 800
>>> VPU_G2_CLK_ROOT .......... 700
>>>
>>> 5.1.5.1 Input Clocks
>>> Input Clock .............. Frequency (MHz)
>>> VPU_PLL_CLK .............. 800
>>
>> Acoording the datasheet not the reference manual, this would be the
>> overdrive mode now. Can we ensure that VDD_SOC is in overdrive state?
>
> Shoot, I explicitly searched the TRM for overdrive, because I remember
> this coming before with either the 8MQ or 8MM, but I couldn't
> remember. I forgot all about the actual datasheet.
Same here, I vaguely recall there might've been a reason why those lower
freqs, but I couldn't find it either.
> The operating-points for the various voltage rails would have to
> increase to get this into overdrive mode. I think this would have to
> be done on a per-board basis if memory serves when this came up
> before. :-(
I don't mind doing it per board. Actually, I don't mind dropping this
patch, since the decoding performance increase is not even an issue in
any of the use cases I care about.
I guess the general agreement here is to go with the "nominal mode" by
default and enable "overdrive mode" per-board , while the NXP downstream
goes full "overdrive mode" all the time ?
prev parent reply other threads:[~2023-08-10 13:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 0:13 [PATCH] arm64: dts: imx8mp: Improve VPU clock configuration Marek Vasut
2023-08-10 2:31 ` Adam Ford
2023-08-10 7:42 ` Marco Felsch
2023-08-10 12:46 ` Adam Ford
2023-08-10 13:20 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e81c74cf-0341-fd11-d7cf-e3f257d1c056@denx.de \
--to=marex@denx.de \
--cc=Frank.Li@nxp.com \
--cc=aford173@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=m.felsch@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).