* [PATCH 0/3] General Purpose clocks and matisse-wifi backlight @ 2023-01-06 11:44 Matti Lehtimäki 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki 2023-01-06 11:44 ` [PATCH 3/3] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Add display backlight Matti Lehtimäki 0 siblings, 2 replies; 9+ messages in thread From: Matti Lehtimäki @ 2023-01-06 11:44 UTC (permalink / raw) To: linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki, Bjorn Andersson, devicetree, Konrad Dybcio, linux-gpio, linux-kernel This series adds support for general purpose clocks found on MSM8226 and enables ti,lp8556 backlight on matisse-wifi which uses general purpose clocks with clk-pwm. Luca Weiss (1): pinctrl: qcom: msm8226: Add General Purpose clocks Matti Lehtimäki (2): dt-bindings: pinctrl: msm8226: Add General Purpose clocks ARM: dts: qcom: apq8026-samsung-matisse-wifi: Add display backlight .../pinctrl/qcom,msm8226-pinctrl.yaml | 4 +- .../dts/qcom-apq8026-samsung-matisse-wifi.dts | 59 +++++++++++++++++++ drivers/pinctrl/qcom/pinctrl-msm8226.c | 11 +++- 3 files changed, 70 insertions(+), 4 deletions(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 11:44 [PATCH 0/3] General Purpose clocks and matisse-wifi backlight Matti Lehtimäki @ 2023-01-06 11:44 ` Matti Lehtimäki 2023-01-06 12:32 ` Krzysztof Kozlowski ` (2 more replies) 2023-01-06 11:44 ` [PATCH 3/3] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Add display backlight Matti Lehtimäki 1 sibling, 3 replies; 9+ messages in thread From: Matti Lehtimäki @ 2023-01-06 11:44 UTC (permalink / raw) To: linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki, Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel Document the general purpose clock functions that are found on MSM8226. Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> --- .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml index 3b79f5be860b..6e3808065845 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml @@ -66,8 +66,8 @@ $defs: enum: [ gpio, cci_i2c0, blsp_uim1, blsp_uim2, blsp_uim3, blsp_uim5, blsp_i2c1, blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_spi1, blsp_spi2, blsp_spi3, blsp_spi5, blsp_uart1, blsp_uart2, - blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, sdc3, - wlan ] + blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, + gp0_clk, gp1_clk, sdc3, wlan ] bias-pull-down: true bias-pull-up: true -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki @ 2023-01-06 12:32 ` Krzysztof Kozlowski 2023-01-06 12:41 ` Matti Lehtimäki 2023-01-06 13:00 ` Krzysztof Kozlowski 2023-01-10 7:57 ` Linus Walleij 2 siblings, 1 reply; 9+ messages in thread From: Krzysztof Kozlowski @ 2023-01-06 12:32 UTC (permalink / raw) To: Matti Lehtimäki, linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel On 06/01/2023 12:44, Matti Lehtimäki wrote: > Document the general purpose clock functions that are found on MSM8226. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > --- > .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > index 3b79f5be860b..6e3808065845 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > @@ -66,8 +66,8 @@ $defs: > enum: [ gpio, cci_i2c0, blsp_uim1, blsp_uim2, blsp_uim3, blsp_uim5, > blsp_i2c1, blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_spi1, > blsp_spi2, blsp_spi3, blsp_spi5, blsp_uart1, blsp_uart2, > - blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, sdc3, > - wlan ] > + blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, > + gp0_clk, gp1_clk, sdc3, wlan ] Driver does not support them (and there is no driver change, unless you cc-ed people selectively...). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 12:32 ` Krzysztof Kozlowski @ 2023-01-06 12:41 ` Matti Lehtimäki 2023-01-06 13:00 ` Krzysztof Kozlowski 0 siblings, 1 reply; 9+ messages in thread From: Matti Lehtimäki @ 2023-01-06 12:41 UTC (permalink / raw) To: Krzysztof Kozlowski, linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel On 6.1.2023 14.32, Krzysztof Kozlowski wrote: > On 06/01/2023 12:44, Matti Lehtimäki wrote: >> + blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, >> cam_mclk1, + gp0_clk, gp1_clk, sdc3, wlan ] > > Driver does not support them (and there is no driver change, unless > you cc-ed people selectively...). The driver changes are in patch number 2 of the series, I used git send-mail with a cc script, which uses get_maintainer.pl to get the needed addresses for each patch, to send the patches. It probably didn't send every patch to everyone and would need some improvement. -Matti ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 12:41 ` Matti Lehtimäki @ 2023-01-06 13:00 ` Krzysztof Kozlowski 0 siblings, 0 replies; 9+ messages in thread From: Krzysztof Kozlowski @ 2023-01-06 13:00 UTC (permalink / raw) To: Matti Lehtimäki, linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel On 06/01/2023 13:41, Matti Lehtimäki wrote: > On 6.1.2023 14.32, Krzysztof Kozlowski wrote: >> On 06/01/2023 12:44, Matti Lehtimäki wrote: >>> + blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, >>> cam_mclk1, + gp0_clk, gp1_clk, sdc3, wlan ] >> >> Driver does not support them (and there is no driver change, unless >> you cc-ed people selectively...). > > The driver changes are in patch number 2 of the series, I used > git send-mail with a cc script, which uses get_maintainer.pl to > get the needed addresses for each patch, to send the patches. It > probably didn't send every patch to everyone and would need some > improvement. Ah, ok, such method is recommended for big patchsets. In regular cases please Cc everyone for all patches. I am using this one: https://pastebin.com/HAjuht68 Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki 2023-01-06 12:32 ` Krzysztof Kozlowski @ 2023-01-06 13:00 ` Krzysztof Kozlowski 2023-01-10 7:57 ` Linus Walleij 2 siblings, 0 replies; 9+ messages in thread From: Krzysztof Kozlowski @ 2023-01-06 13:00 UTC (permalink / raw) To: Matti Lehtimäki, linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel On 06/01/2023 12:44, Matti Lehtimäki wrote: > Document the general purpose clock functions that are found on MSM8226. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > --- > .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki 2023-01-06 12:32 ` Krzysztof Kozlowski 2023-01-06 13:00 ` Krzysztof Kozlowski @ 2023-01-10 7:57 ` Linus Walleij 2 siblings, 0 replies; 9+ messages in thread From: Linus Walleij @ 2023-01-10 7:57 UTC (permalink / raw) To: Matti Lehtimäki Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel On Fri, Jan 6, 2023 at 12:44 PM Matti Lehtimäki <matti.lehtimaki@gmail.com> wrote: > Document the general purpose clock functions that are found on MSM8226. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> Patch applied! Yours, Linus Walleij ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Add display backlight 2023-01-06 11:44 [PATCH 0/3] General Purpose clocks and matisse-wifi backlight Matti Lehtimäki 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki @ 2023-01-06 11:44 ` Matti Lehtimäki 2023-01-07 10:41 ` Konrad Dybcio 1 sibling, 1 reply; 9+ messages in thread From: Matti Lehtimäki @ 2023-01-06 11:44 UTC (permalink / raw) To: linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel Uses ti,lp8556 backlight with clk-pwm. Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> --- .../dts/qcom-apq8026-samsung-matisse-wifi.dts | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts index 15b9590ba07b..848cfda64e5a 100644 --- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts @@ -23,6 +23,14 @@ aliases { display0 = &framebuffer0; }; + backlight_pwm: pwm { + compatible = "clk-pwm"; + #pwm-cells = <2>; + clocks = <&mmcc CAMSS_GP0_CLK>; + pinctrl-names = "default"; + pinctrl-0 = <&backlight_pwm_default_state>; + }; + chosen { #address-cells = <1>; #size-cells = <1>; @@ -80,6 +88,45 @@ key-volume-up { }; }; + i2c-backlight { + compatible = "i2c-gpio"; + sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; + scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; + + pinctrl-names = "default"; + pinctrl-0 = <&backlight_i2c_default_state>; + + i2c-gpio,delay-us = <4>; + + #address-cells = <1>; + #size-cells = <0>; + + backlight@2c { + compatible = "ti,lp8556"; + reg = <0x2c>; + + dev-ctrl = /bits/ 8 <0x80>; + init-brt = /bits/ 8 <0x3f>; + pwm-period = <100000>; + + pwms = <&backlight_pwm 0 100000>; + pwm-names = "lp8556"; + + rom-a0h { + rom-addr = /bits/ 8 <0xa0>; + rom-val = /bits/ 8 <0x44>; + }; + rom-a1h { + rom-addr = /bits/ 8 <0xa1>; + rom-val = /bits/ 8 <0x6c>; + }; + rom-a5h { + rom-addr = /bits/ 8 <0xa5>; + rom-val = /bits/ 8 <0x24>; + }; + }; + }; + reg_tsp_1p8v: regulator-tsp-1p8v { compatible = "regulator-fixed"; regulator-name = "tsp_1p8v"; @@ -418,6 +465,18 @@ accel_int_default_state: accel-int-default-state { bias-disable; }; + backlight_i2c_default_state: backlight-i2c-default-state { + pins = "gpio20", "gpio21"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; + + backlight_pwm_default_state: backlight-pwm-default-state { + pins = "gpio33"; + function = "gp0_clk"; + }; + muic_int_default_state: muic-int-default-state { pins = "gpio67"; function = "gpio"; -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Add display backlight 2023-01-06 11:44 ` [PATCH 3/3] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Add display backlight Matti Lehtimäki @ 2023-01-07 10:41 ` Konrad Dybcio 0 siblings, 0 replies; 9+ messages in thread From: Konrad Dybcio @ 2023-01-07 10:41 UTC (permalink / raw) To: Matti Lehtimäki, linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel On 6.01.2023 12:44, Matti Lehtimäki wrote: > Uses ti,lp8556 backlight with clk-pwm. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > --- > .../dts/qcom-apq8026-samsung-matisse-wifi.dts | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts > index 15b9590ba07b..848cfda64e5a 100644 > --- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts > +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts > @@ -23,6 +23,14 @@ aliases { > display0 = &framebuffer0; > }; > > + backlight_pwm: pwm { This should be sorted alphabetically. > + compatible = "clk-pwm"; > + #pwm-cells = <2>; > + clocks = <&mmcc CAMSS_GP0_CLK>; > + pinctrl-names = "default"; > + pinctrl-0 = <&backlight_pwm_default_state>; > + }; > + > chosen { > #address-cells = <1>; > #size-cells = <1>; > @@ -80,6 +88,45 @@ key-volume-up { > }; > }; > > + i2c-backlight { > + compatible = "i2c-gpio"; > + sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > + scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&backlight_i2c_default_state>; Please reorder these two properties. > + > + i2c-gpio,delay-us = <4>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + backlight@2c { > + compatible = "ti,lp8556"; > + reg = <0x2c>; > + > + dev-ctrl = /bits/ 8 <0x80>; > + init-brt = /bits/ 8 <0x3f>; > + pwm-period = <100000>; > + > + pwms = <&backlight_pwm 0 100000>; > + pwm-names = "lp8556"; > + > + rom-a0h { > + rom-addr = /bits/ 8 <0xa0>; > + rom-val = /bits/ 8 <0x44>; > + }; Please add a newline between each subnode. Otherwise I think this looks good.. Konrad > + rom-a1h { > + rom-addr = /bits/ 8 <0xa1>; > + rom-val = /bits/ 8 <0x6c>; > + }; > + rom-a5h { > + rom-addr = /bits/ 8 <0xa5>; > + rom-val = /bits/ 8 <0x24>; > + }; > + }; > + }; > + > reg_tsp_1p8v: regulator-tsp-1p8v { > compatible = "regulator-fixed"; > regulator-name = "tsp_1p8v"; > @@ -418,6 +465,18 @@ accel_int_default_state: accel-int-default-state { > bias-disable; > }; > > + backlight_i2c_default_state: backlight-i2c-default-state { > + pins = "gpio20", "gpio21"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + backlight_pwm_default_state: backlight-pwm-default-state { > + pins = "gpio33"; > + function = "gp0_clk"; > + }; > + > muic_int_default_state: muic-int-default-state { > pins = "gpio67"; > function = "gpio"; ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-01-10 7:59 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-01-06 11:44 [PATCH 0/3] General Purpose clocks and matisse-wifi backlight Matti Lehtimäki 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki 2023-01-06 12:32 ` Krzysztof Kozlowski 2023-01-06 12:41 ` Matti Lehtimäki 2023-01-06 13:00 ` Krzysztof Kozlowski 2023-01-06 13:00 ` Krzysztof Kozlowski 2023-01-10 7:57 ` Linus Walleij 2023-01-06 11:44 ` [PATCH 3/3] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Add display backlight Matti Lehtimäki 2023-01-07 10:41 ` Konrad Dybcio
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).