From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A98A52AF1C; Fri, 29 Nov 2024 02:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732846703; cv=none; b=m1jR4kb2xKpJrGo6olTwhd4TGN9u1sNUXJO2Lg3GUT4Fzy/KlnEMYE9/4r4DjeSMHPzamBEieuiSdTnctnfOKmSdWlkHCjiaHLjKtZAvZxPe4SbIO9j3YftTbB6OPZM1eS0ftM61cTNcyWLjSDgR6FX7JtHARZriBoNJGgdBRKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732846703; c=relaxed/simple; bh=jymtloSEHcxZ9gSFH8IBlLYpP+cbohL8+8HpbYQTTc4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=GHE4bx/KnNRsMS4WkG2UHgwMYag6dcmsCKPsv0oAKVd9++kyyR1I6t1K/B8UAdJfprIGpowkYzMRQ+e0FKtja5CwqV6Kwa1V6mEV2OMLOmvSwMLhlS+XWRd+LEzvOq3uz+quuVsp0nzpWNUetMwmk8VNDMVJ/WOp/xnBe5oFcc0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=nQy4Ag8e; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="nQy4Ag8e" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4ASMkUE6013915; Fri, 29 Nov 2024 02:18:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j8/PNTldqPRcndVcg7eQG0Pz6bx/tQTBm1s6UZTlxx0=; b=nQy4Ag8e8c8c1drW a9/Av1lLUtw2yTkagoIwv3CZEMzNnGQ4nSfjGCM6/U3InllqVXU+zQn0dmtWOCf0 dIs5JpOE6kDFraq26772wcOJJDO1MrvDWM0gwLOErUcHTdzYCH7ugeHdMDnwo/Kv YpTbDCAc3lUj7z9fQWMiTV9EEBNQh2p/Urg/nH/DyUp2CHeeap9LQnXZfzeZg6mN 3LYC1/7joqqGR1lQ4Fr9ZdiA5O92DhlBO3Fldbi9gBHUmpyqo0cVulGsitEJbfti Mk1arTU3humMw/o9ShqmXewR3S8eE7i69FyynqH9ZWhUw9tAum3FsOY6G0ZTSPlK eh+7HA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4366xvv5bf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Nov 2024 02:18:11 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4AT2IBBm029648 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Nov 2024 02:18:11 GMT Received: from [10.233.21.53] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 28 Nov 2024 18:18:07 -0800 Message-ID: Date: Fri, 29 Nov 2024 10:18:05 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: add base QCS8300 RIDE board To: Krzysztof Kozlowski , Andrew Lunn CC: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , , , , , References: <20241128-qcs8300_initial_dtsi-v3-0-26aa8a164914@quicinc.com> <20241128-qcs8300_initial_dtsi-v3-4-26aa8a164914@quicinc.com> Content-Language: en-US From: Jingyi Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: te8u0cfBIHWfRn1uUIhPuHmjV-ej8KcG X-Proofpoint-ORIG-GUID: te8u0cfBIHWfRn1uUIhPuHmjV-ej8KcG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 mlxscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 phishscore=0 suspectscore=0 clxscore=1011 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2411290017 On 11/29/2024 1:40 AM, Krzysztof Kozlowski wrote: > On 28/11/2024 17:49, Andrew Lunn wrote: >> On Thu, Nov 28, 2024 at 04:44:46PM +0800, Jingyi Wang wrote: >>> Add initial support for Qualcomm QCS8300 RIDE board which enables DSPs, >>> UFS and booting to shell with uart console. >>> >>> Written with help from Tingguo Cheng (added rpmhpd nodes) and Xin Liu >>> (added ufs, adsp and gpdsp nodes). >>> >>> Reviewed-by: Krzysztof Kozlowski >>> Signed-off-by: Jingyi Wang >>> --- >>> arch/arm64/boot/dts/qcom/Makefile | 2 +- >>> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 267 ++++++++++++++++++++++++++++++ >>> 2 files changed, 268 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >>> index 9bb8b191aeb5..d9545743606a 100644 >>> --- a/arch/arm64/boot/dts/qcom/Makefile >>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>> @@ -114,7 +114,7 @@ dtb-$(CONFIG_ARCH_QCOM) += qcm6490-shift-otter.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb >>> -dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += qcs8300-ride.dtb >> >> It would be good to add a comment to the commit message about why you >> are removing qcs8550-aim300-aiot.dtb from the Makefile. > > Especially that it was not in v2 (which I reviewed) and nothing in the > changelog explains this removal. > sorry it was a typo, will fix that > Best regards, > Krzysztof