From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D99E2C0015E for ; Tue, 11 Jul 2023 06:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231452AbjGKGWs (ORCPT ); Tue, 11 Jul 2023 02:22:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229641AbjGKGWq (ORCPT ); Tue, 11 Jul 2023 02:22:46 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B7DFE6B for ; Mon, 10 Jul 2023 23:22:45 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-51e5da802afso1675795a12.3 for ; Mon, 10 Jul 2023 23:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689056563; x=1691648563; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tpO/kRGXZrcaHH/p3Ai9d1x5JI3iV2cFdsOiX0dHBSw=; b=j4Vz6XpJVEuaD4v2PFmw+Dztx/NfSOnFHz21bQjCzlcPhk5Zgygngj8YH9FAK8EG5l szqMWG4qHGtHQ/3YpukKC0qy3jP05GVhqbf8k8mZMBqbZWM0ZG7j/FgPqZEUMzVwcVzg pW9gxmGBD9MbdqGbcOqdU4PFixr6WPj/q73BOrVuCIrxZvJ04pLzHaHvHvKIvSFCfX36 QzRToBLjYwqxKjIYddHc/1b64bV8clPa3dS6xv//9mUnrv46qFSXnzIkHh+xKPaz3u1A NE73oy9uGJxYe8Mdzfg3FZn9zmIegt79wuoNN5FMhQOx3XJqKGPakEi+HZQQHNp0mzb5 ZQ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689056563; x=1691648563; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tpO/kRGXZrcaHH/p3Ai9d1x5JI3iV2cFdsOiX0dHBSw=; b=ek6QogeLP3c09mM60xQV5opDXpMloVEDBIWdGfkyi//esSVlMUXRveFuCspgYokFjm 3jbGe9Cg9/Kr9GkRH4svoWt7GIxLSD+ivLlKL3X5Z6TCE3z4+H7I1SrRGtcZxbD5sBzr dRbvpPrB+c8qs5S4gUIvB6oKSJZE2tu0avcIBFSGuuZ7mOTPnAKiYfwVt7DWmh0LsxZ1 d18m+A0xOGASpgyRfDA9T/j3V2zZV/a+K3c25ZcQP5TOPh7LrYcAg1aZsynPG+2O57od 4adGynISdwiKjlU33I7Jm2l+yLVWtiYaDKT5SRhTO5wYUlG7M/J8qltzJElzRd/3iryS Y/xw== X-Gm-Message-State: ABy/qLZUtlGDgoGj3qcCv1OJ3ndkg9ranOTlR2zkjfnajGSy/jx9wxIw 6clUy0EJPlOHe8rhHssPwkf3gw== X-Google-Smtp-Source: APBJJlG75Gj08t8cXGFBsFAzicMXDCqYemy05g+dTkjLYyu1nb6WZo82rIl6WLtRpu3GiQylcUEMIA== X-Received: by 2002:a17:906:dc:b0:98e:4c96:6e16 with SMTP id 28-20020a17090600dc00b0098e4c966e16mr15367855eji.5.1689056563685; Mon, 10 Jul 2023 23:22:43 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id f26-20020a1709062c5a00b0098242730348sm696748ejh.72.2023.07.10.23.22.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jul 2023 23:22:43 -0700 (PDT) Message-ID: Date: Tue, 11 Jul 2023 08:22:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes Content-Language: en-US To: Rohit Agarwal , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1689054169-10800-1-git-send-email-quic_rohiagar@quicinc.com> <1689054169-10800-2-git-send-email-quic_rohiagar@quicinc.com> <2040226e-9b45-b409-3edd-a5b86d86daa8@linaro.org> <8a3124ce-a11d-2491-eaee-1695cec70b17@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <8a3124ce-a11d-2491-eaee-1695cec70b17@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/07/2023 08:17, Rohit Agarwal wrote: > > On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote: >> On 11/07/2023 07:42, Rohit Agarwal wrote: >>> Add Generic RPMh Power Domain indexes that can be used >>> for all the Qualcomm SoC henceforth. >>> >>> Signed-off-by: Rohit Agarwal >>> Suggested-by: Konrad Dybcio >>> --- >>> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >>> >>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h >>> new file mode 100644 >>> index 0000000..4da2e04 >>> --- /dev/null >>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h >> Filename based on compatible. > This is not specific for SDX75. These are generic ones that should be > used for all other targets. > Konrad suggested in v1 to avoid target specific prefixes everytime and > to create a new generic > dt-bindings that can be reused. >>> @@ -0,0 +1,30 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>> +/* >>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. >>> + */ >>> + >>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>> + >>> +/* Generic RPMH Power Domain Indexes */ >>> +#define CX 0 >> These are very generic names, usually not used in global headers. Please >> use some reasonable prefix. > This was based on the suggestion from Konrad in v2 to drop the RPMHPD > prefix and we can go only with names like CX, etc. I don't think having so generic name in tree-wide header is good idea. CX can mean anything. Best regards, Krzysztof