From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Ajit Pandey <ajitp@codeaurora.org>,
broonie@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header
Date: Mon, 18 May 2020 10:22:50 +0100 [thread overview]
Message-ID: <e8859fcf-fc00-01fc-b64e-dba086c8155b@linaro.org> (raw)
On 14/05/2020 17:38, Ajit Pandey wrote:
> Add header defining dai-id and mclk id for SC7180 lpass soc.
>
> Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
> ---
> include/dt-bindings/sound/sc7180-lpass.h | 10 ++++++++++
Why not reuse or rename include/dt-bindings/sound/apq8016-lpass.h to
include/dt-bindings/sound/lpass.h and reuse across all the LPASS variants?
--srini
> 1 file changed, 10 insertions(+)
> create mode 100644 include/dt-bindings/sound/sc7180-lpass.h
>
> diff --git a/include/dt-bindings/sound/sc7180-lpass.h b/include/dt-bindings/sound/sc7180-lpass.h
> new file mode 100644
> index 0000000..7d988f6
> --- /dev/null
> +++ b/include/dt-bindings/sound/sc7180-lpass.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __DT_SC7180_LPASS_H
> +#define __DT_SC7180_LPASS_H
> +
> +#define MI2S_PRIMARY 0
> +#define MI2S_SECONDARY 1
> +
> +#define LPASS_MCLK0 0
> +
> +#endif /* __DT_APQ8016_LPASS_H */
>
next reply other threads:[~2020-05-18 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 9:22 Srinivas Kandagatla [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-16 18:14 [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header Ajit Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8859fcf-fc00-01fc-b64e-dba086c8155b@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=ajitp@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).