From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: gregkh@linuxfoundation.org, broonie@kernel.org,
alsa-devel@alsa-project.org, sdharia@codeaurora.org, bp@suse.de,
poeschel@lemonage.de, treding@nvidia.com,
andreas.noever@gmail.com, alan@linux.intel.com,
mathieu.poirier@linaro.org, daniel@ffwll.ch, jkosina@suse.cz,
sharon.dvir1@mail.huji.ac.il, joe@perches.com,
davem@davemloft.net, james.hogan@imgtec.com,
michael.opdenacker@free-electrons.com, pawel.moll@arm.com,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
vinod.koul@intel.com, arnd@arndb.de
Subject: Re: [PATCH v8 10/13] dt-bindings: Add qcom slimbus controller bindings
Date: Tue, 5 Dec 2017 22:03:04 +0000 [thread overview]
Message-ID: <e8914c67-1a5d-b164-52f5-9bf1392ed422@linaro.org> (raw)
In-Reply-To: <20171204212829.bmcp5dktc5w46rom@rob-hp-laptop>
On 04/12/17 21:28, Rob Herring wrote:
> On Thu, Nov 30, 2017 at 05:41:57PM +0000, srinivas.kandagatla@linaro.org wrote:
>> From: Sagar Dharia <sdharia@codeaurora.org>
>>
>> This patch add device tree bindings for Qualcomm slimbus controller.
>>
>> Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> .../devicetree/bindings/slimbus/slim-qcom-ctrl.txt | 39 ++++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt
>>
>> + - clocks : Interface and core clocks used by this SLIMbus controller
>> + - clock-names : Required clock-name entries are:
>> + "iface_clk" : Interface clock for this controller
>> + "core_clk" : Interrupt for controller core's BAM
>
> Doesn't match the example. You should drop the '_clk'. With that,
>
Thanks for the Reviewed-by tag, I will fix the above in next version.
> Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2017-12-05 22:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 17:41 [PATCH v8 00/13] Introduce framework for SLIMbus device driver srinivas.kandagatla
2017-11-30 17:41 ` [PATCH v8 01/13] Documentation: Add SLIMbus summary srinivas.kandagatla
2017-12-01 10:27 ` Jonathan Neuschäfer
2017-12-05 22:01 ` Srinivas Kandagatla
2017-11-30 17:41 ` [PATCH v8 02/13] dt-bindings: Add SLIMbus bindings srinivas.kandagatla
2017-11-30 17:41 ` [PATCH v8 03/13] slimbus: Add SLIMbus bus type srinivas.kandagatla
2017-11-30 17:41 ` [PATCH v8 04/13] slimbus: core: Add slim controllers support srinivas.kandagatla
2017-11-30 17:41 ` [PATCH v8 05/13] slimbus: core: add support to device tree helper srinivas.kandagatla
2017-11-30 17:41 ` [PATCH v8 06/13] slimbus: Add messaging APIs to slimbus framework srinivas.kandagatla
2017-11-30 17:41 ` [PATCH v8 07/13] slimbus: Add support for 'clock-pause' feature srinivas.kandagatla
2017-11-30 19:25 ` Philippe Ombredanne
2017-12-01 9:51 ` Greg Kroah-Hartman
2017-12-01 9:54 ` Srinivas Kandagatla
2017-11-30 17:41 ` [PATCH v8 08/13] regmap: add SLIMbus support srinivas.kandagatla
2017-11-30 17:41 ` [PATCH v8 09/13] slimbus: core: add common defines required for controllers srinivas.kandagatla
2017-11-30 17:41 ` [PATCH v8 10/13] dt-bindings: Add qcom slimbus controller bindings srinivas.kandagatla
[not found] ` <20171130174200.6684-11-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-04 21:28 ` Rob Herring
2017-12-05 22:03 ` Srinivas Kandagatla [this message]
2017-11-30 17:41 ` [PATCH v8 11/13] slimbus: qcom: Add Qualcomm Slimbus controller driver srinivas.kandagatla
2017-11-30 17:41 ` [PATCH v8 12/13] slimbus: qcom: Add runtime-pm support using clock-pause srinivas.kandagatla
2017-11-30 17:42 ` [PATCH v8 13/13] MAINTAINERS: Add SLIMbus maintainer srinivas.kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8914c67-1a5d-b164-52f5-9bf1392ed422@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andreas.noever@gmail.com \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.hogan@imgtec.com \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=michael.opdenacker@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=poeschel@lemonage.de \
--cc=robh@kernel.org \
--cc=sdharia@codeaurora.org \
--cc=sharon.dvir1@mail.huji.ac.il \
--cc=treding@nvidia.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).