From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86A3A3C1979; Tue, 17 Mar 2026 13:21:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773753690; cv=none; b=Mrl9MV1ibkGeIAYaxtdbe6UPJIrYJtBRb2Hi10qxkm4cIRD07fnflk65bDRvvtDY3te4k/UrlmFGAojlT1HrLTa02OIAuDu/fuXXy+LEJobHH45PElQoXT4sPoN19c9Q3xfNbTc+Xm4ll9UZbPpo2g6wfDSxAJGk72fYQcxCvxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773753690; c=relaxed/simple; bh=hTN1TNlOZL26JxiO/N2w3PZRC4OyzRSiRbthnRGcI0I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XqlAHIIPe6ntjjptBSZZZTmH4OjWa8a01iJ3aClT2xP8lMWC/gSLTWS9o097O0wGYYwMzDcMMaKsvzHTKVGuEO2oRiJNJO/yrq6Cyk6r1wj98Yv32TKyvMr1TJwIzQ/kWLT4+cHKgA1WNRVZa6fWnl/E30Hgel6z8xblykAfHPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=e3Wo5w1g; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="e3Wo5w1g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1773753682; bh=hTN1TNlOZL26JxiO/N2w3PZRC4OyzRSiRbthnRGcI0I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=e3Wo5w1g48wmRF4VftZVxkCP6WO42t2NEdAxgAgcbg73QSnJPPXkHZXTmPnrIEwGM g4EfshV3wE3ZbE3QLdmmaTGH5N2hY/gpqcfiAAs9IbvJ6CUE+59IrqS6g3oO0YbC/A FwdqhZBos8+ItXxhieyZ6z6IOlsXuftcfHXIR6rVYdklpDI0LrrhQFQiA259+QO9up fzB5FZbYlOJV7PTs5YwhxwI1gFwoOvxAxI18eVV83ixh9Z/wA1/E58JupvozFswG9C LXQazlhooyzrZ/DdRnNn+7CWEJr1uBIEzd/3qGEdHc1RfNPagIwLMS248CGhO4KoHY 6OMIzOpw/1D/A== Received: from [10.40.0.100] (185-67-175-126.lampert.tv [185.67.175.126]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mriesch) by bali.collaboradmins.com (Postfix) with ESMTPSA id 68CC517E0E3F; Tue, 17 Mar 2026 14:21:21 +0100 (CET) Message-ID: Date: Tue, 17 Mar 2026 14:21:20 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/9] media: rockchip: rkcif: add support for rk3588 vicap mipi capture To: Mehdi Djait Cc: Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Jagan Teki , =?UTF-8?B?0JrRg9C30L3QtdGG0L7QsiDQnNC40YXQsNC40Ls=?= , Sebastian Reichel , Nicolas Dufresne , Collabora Kernel Team , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250430-rk3588-vicap-v2-0-77de5ee9048e@collabora.com> <20250430-rk3588-vicap-v2-3-77de5ee9048e@collabora.com> Content-Language: en-US From: Michael Riesch In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Mehdi, On 3/17/26 14:08, Mehdi Djait wrote: > Hi Michael, > > Thank you for this nice patch! > > On Tue, Mar 17, 2026 at 10:32:21AM +0100, Michael Riesch via B4 Relay wrote: >> From: Michael Riesch >> >> The RK3588 Video Capture (VICAP) unit features a Digital Video Port >> (DVP) and six MIPI CSI-2 capture interfaces. Add initial support >> for this variant to the rkcif driver and enable the MIPI CSI-2 >> capture interfaces. >> >> Signed-off-by: Michael Riesch > > [...] > >> static inline unsigned int rkcif_mipi_get_reg(struct rkcif_interface *interface, >> unsigned int index) >> { >> @@ -631,6 +765,8 @@ static int rkcif_mipi_start_streaming(struct rkcif_stream *stream) >> rkcif_mipi_stream_write(stream, RKCIF_MIPI_CTRL1, ctrl1); >> rkcif_mipi_stream_write(stream, RKCIF_MIPI_CTRL0, ctrl0); >> >> + rkcif_mipi_write(interface, RKCIF_MIPI_CTRL, RKCIF_MIPI_CTRL_CAP_EN); >> + > > while this is the correct solution for rk3588, for the rk3568 vicap this > will write 0x1 to the VICAP_MIPI_CTRL : 0x00A0 which will enable the water line. nice catch ;-) However, the TRM (at least my version) claims that this bit has a reset value of 0x1, so the bit in question should be already set in the first place. Thus I decided to *not* make variant specific code paths. Do you see problems in your setup? > > -- > Kind Regards > Mehdi Djait Best regards, Michael