From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Robert Marko <robimarko@gmail.com>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
quic_gurus@quicinc.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_mojha@quicinc.com
Cc: computersforpeace@gmail.com
Subject: Re: [PATCH v3 2/4] firmware: qcom_scm: disable SDI if required
Date: Wed, 16 Aug 2023 19:33:14 +0200 [thread overview]
Message-ID: <e89b4a5a-e634-45b5-a8dc-cf7d1a968ccc@linaro.org> (raw)
In-Reply-To: <20230816164641.3371878-2-robimarko@gmail.com>
On 16.08.2023 18:45, Robert Marko wrote:
> IPQ5018 has SDI (Secure Debug Image) enabled by TZ by default, and that
> means that WDT being asserted or just trying to reboot will hang the board
> in the debug mode and only pulling the power and repowering will help.
> Some IPQ4019 boards like Google WiFI have it enabled as well.
>
> Luckily, SDI can be disabled via an SCM call.
>
> So, lets use the boolean DT property to identify boards that have SDI
> enabled by default and use the SCM call to disable SDI during SCM probe.
> It is important to disable it as soon as possible as we might have a WDT
> assertion at any time which would then leave the board in debug mode,
> thus disabling it during SCM removal is not enough.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
[...]
> + /*
> + * Disable SDI if indicated by DT that it is enabled by default.
> + */
> + if (of_property_read_bool(pdev->dev.of_node, "qcom,sdi-enabled"))
> + qcom_scm_disable_sdi();
Should we care about the return value?
Konrad
next prev parent reply other threads:[~2023-08-16 17:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 16:45 [PATCH v3 1/4] dt-bindings: firmware: qcom,scm: support indicating SDI default state Robert Marko
2023-08-16 16:45 ` [PATCH v3 2/4] firmware: qcom_scm: disable SDI if required Robert Marko
2023-08-16 17:02 ` Guru Das Srinagesh
2023-08-16 17:33 ` Konrad Dybcio [this message]
2023-08-21 10:14 ` Robert Marko
2023-08-22 15:37 ` Mukesh Ojha
2023-08-25 9:41 ` Robert Marko
2023-08-25 21:42 ` Brian Norris
2023-08-31 14:43 ` Mukesh Ojha
2023-09-07 6:32 ` Sricharan Ramabadhran
2023-09-11 13:22 ` Mukesh Ojha
2023-08-16 16:45 ` [PATCH v3 3/4] dt-bindings: firmware: qcom,scm: document IPQ5018 compatible Robert Marko
2023-08-16 16:45 ` [PATCH v3 4/4] arm64: dts: qcom: ipq5018: indicate that SDI should be disabled Robert Marko
2023-08-17 3:35 ` [PATCH v3 1/4] dt-bindings: firmware: qcom,scm: support indicating SDI default state Brian Norris
2023-08-19 14:04 ` Krzysztof Kozlowski
2023-08-22 16:55 ` Mukesh Ojha
2023-09-20 18:15 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e89b4a5a-e634-45b5-a8dc-cf7d1a968ccc@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_gurus@quicinc.com \
--cc=quic_mojha@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).