* [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example
@ 2023-04-28 16:02 Jianhua Lu
2023-05-01 7:18 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jianhua Lu @ 2023-04-28 16:02 UTC (permalink / raw)
To: Jianhua Lu, Lee Jones, Daniel Thompson, Jingoo Han, Pavel Machek,
Rob Herring, Krzysztof Kozlowski
Cc: dri-devel, linux-leds, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
The kinetic,ktz8866 is a I2C driver, so add the missing reg property.
And update example to make it clear.
Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
.../leds/backlight/kinetic,ktz8866.yaml | 29 ++++++++++++-------
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
index e1191453c2f0..6ec40cce3f11 100644
--- a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
@@ -21,6 +21,9 @@ properties:
compatible:
const: kinetic,ktz8866
+ reg:
+ maxItems: 1
+
vddpos-supply:
description: positive boost supply regulator.
@@ -53,6 +56,7 @@ properties:
required:
- compatible
+ - reg
- vddpos-supply
- vddneg-supply
- enable-gpios
@@ -63,14 +67,19 @@ examples:
- |
#include <dt-bindings/gpio/gpio.h>
- backlight {
- compatible = "kinetic,ktz8866";
-
- vddpos-supply = <&bl_vddpos_5p5>;
- vddneg-supply = <&bl_vddneg_5p5>;
- enable-gpios = <&tlmm 139 GPIO_ACTIVE_HIGH>;
- current-num-sinks = <5>;
- kinetic,current-ramp-delay-ms = <128>;
- kinetic,led-enable-ramp-delay-ms = <1>;
- kinetic,enable-lcd-bias;
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ backlight@11 {
+ compatible = "kinetic,ktz8866";
+ reg = <0x11>;
+ vddpos-supply = <&bl_vddpos_5p5>;
+ vddneg-supply = <&bl_vddneg_5p5>;
+ enable-gpios = <&tlmm 139 GPIO_ACTIVE_HIGH>;
+ current-num-sinks = <5>;
+ kinetic,current-ramp-delay-ms = <128>;
+ kinetic,led-enable-ramp-delay-ms = <1>;
+ kinetic,enable-lcd-bias;
+ };
};
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example
2023-04-28 16:02 [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example Jianhua Lu
@ 2023-05-01 7:18 ` Krzysztof Kozlowski
2023-05-02 11:17 ` Daniel Thompson
2023-05-15 13:17 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-01 7:18 UTC (permalink / raw)
To: Jianhua Lu, Lee Jones, Daniel Thompson, Jingoo Han, Pavel Machek,
Rob Herring, Krzysztof Kozlowski
Cc: dri-devel, linux-leds, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 28/04/2023 18:02, Jianhua Lu wrote:
> The kinetic,ktz8866 is a I2C driver, so add the missing reg property.
> And update example to make it clear.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example
2023-04-28 16:02 [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example Jianhua Lu
2023-05-01 7:18 ` Krzysztof Kozlowski
@ 2023-05-02 11:17 ` Daniel Thompson
2023-05-15 13:17 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Thompson @ 2023-05-02 11:17 UTC (permalink / raw)
To: Jianhua Lu
Cc: Lee Jones, Jingoo Han, Pavel Machek, Rob Herring,
Krzysztof Kozlowski, dri-devel, linux-leds, devicetree,
linux-kernel, ~postmarketos/upstreaming, phone-devel
On Sat, Apr 29, 2023 at 12:02:46AM +0800, Jianhua Lu wrote:
> The kinetic,ktz8866 is a I2C driver, so add the missing reg property.
> And update example to make it clear.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example
2023-04-28 16:02 [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example Jianhua Lu
2023-05-01 7:18 ` Krzysztof Kozlowski
2023-05-02 11:17 ` Daniel Thompson
@ 2023-05-15 13:17 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2023-05-15 13:17 UTC (permalink / raw)
To: Jianhua Lu
Cc: Daniel Thompson, Jingoo Han, Pavel Machek, Rob Herring,
Krzysztof Kozlowski, dri-devel, linux-leds, devicetree,
linux-kernel, ~postmarketos/upstreaming, phone-devel
On Sat, 29 Apr 2023, Jianhua Lu wrote:
> The kinetic,ktz8866 is a I2C driver, so add the missing reg property.
> And update example to make it clear.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
> .../leds/backlight/kinetic,ktz8866.yaml | 29 ++++++++++++-------
> 1 file changed, 19 insertions(+), 10 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-15 13:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-28 16:02 [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example Jianhua Lu
2023-05-01 7:18 ` Krzysztof Kozlowski
2023-05-02 11:17 ` Daniel Thompson
2023-05-15 13:17 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).