* [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: constrain required-opps
@ 2023-01-19 13:00 Krzysztof Kozlowski
2023-01-19 13:00 ` [PATCH 2/2] dt-bindings: opp: " Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-19 13:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Viresh Kumar,
Nishanth Menon, Ilia Lin, Vladimir Zapolskiy, linux-arm-msm,
linux-clk, devicetree, linux-kernel, linux-pm
Cc: Krzysztof Kozlowski
Be specific how many required-opps are allowed.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
This change is independent, although logically is connected with my
dtschema pull:
https://github.com/devicetree-org/dt-schema/pull/95
---
Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
index a52a83fe2831..87ae74166807 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
@@ -32,6 +32,7 @@ properties:
A phandle and PM domain specifier for the MMCX power domain.
required-opps:
+ maxItems: 1
description:
A phandle to an OPP node describing required MMCX performance point.
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/2] dt-bindings: opp: constrain required-opps
2023-01-19 13:00 [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: constrain required-opps Krzysztof Kozlowski
@ 2023-01-19 13:00 ` Krzysztof Kozlowski
2023-01-20 4:38 ` Viresh Kumar
2023-01-20 22:15 ` [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: " Stephen Boyd
2023-01-23 21:18 ` Rob Herring
2 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-19 13:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Viresh Kumar,
Nishanth Menon, Ilia Lin, Vladimir Zapolskiy, linux-arm-msm,
linux-clk, devicetree, linux-kernel, linux-pm
Cc: Krzysztof Kozlowski
Be specific how many required-opps are allowed.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
This change is independent, although logically is connected with my
dtschema pull:
https://github.com/devicetree-org/dt-schema/pull/95
---
Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 1 +
Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
index 47e6f36b7637..9b141a409191 100644
--- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
+++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
@@ -202,6 +202,7 @@ patternProperties:
for the functioning of the current device at the current OPP (where
this property is present).
$ref: /schemas/types.yaml#/definitions/phandle-array
+ maxItems: 1
items:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml b/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml
index b4947b326773..438880db1872 100644
--- a/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml
+++ b/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml
@@ -59,7 +59,8 @@ patternProperties:
clock-latency-ns: true
- required-opps: true
+ required-opps:
+ maxItems: 1
required:
- opp-hz
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] dt-bindings: opp: constrain required-opps
2023-01-19 13:00 ` [PATCH 2/2] dt-bindings: opp: " Krzysztof Kozlowski
@ 2023-01-20 4:38 ` Viresh Kumar
2023-01-20 6:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Viresh Kumar @ 2023-01-20 4:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Viresh Kumar,
Nishanth Menon, Ilia Lin, Vladimir Zapolskiy, linux-arm-msm,
linux-clk, devicetree, linux-kernel, linux-pm
On 19-01-23, 14:00, Krzysztof Kozlowski wrote:
> Be specific how many required-opps are allowed.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> This change is independent, although logically is connected with my
> dtschema pull:
> https://github.com/devicetree-org/dt-schema/pull/95
> ---
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 1 +
> Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> index 47e6f36b7637..9b141a409191 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> @@ -202,6 +202,7 @@ patternProperties:
> for the functioning of the current device at the current OPP (where
> this property is present).
> $ref: /schemas/types.yaml#/definitions/phandle-array
> + maxItems: 1
I may not under this property very well. What exactly does this line
say ? Asking as required-properties can have an array of phandles as
well.
> items:
> maxItems: 1
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml b/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml
> index b4947b326773..438880db1872 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml
> @@ -59,7 +59,8 @@ patternProperties:
>
> clock-latency-ns: true
>
> - required-opps: true
> + required-opps:
> + maxItems: 1
>
> required:
> - opp-hz
> --
> 2.34.1
--
viresh
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] dt-bindings: opp: constrain required-opps
2023-01-20 4:38 ` Viresh Kumar
@ 2023-01-20 6:27 ` Krzysztof Kozlowski
2023-01-20 6:41 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 6:27 UTC (permalink / raw)
To: Viresh Kumar
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Viresh Kumar,
Nishanth Menon, Ilia Lin, Vladimir Zapolskiy, linux-arm-msm,
linux-clk, devicetree, linux-kernel, linux-pm
On 20/01/2023 05:38, Viresh Kumar wrote:
> On 19-01-23, 14:00, Krzysztof Kozlowski wrote:
>> Be specific how many required-opps are allowed.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> This change is independent, although logically is connected with my
>> dtschema pull:
>> https://github.com/devicetree-org/dt-schema/pull/95
>> ---
>> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 1 +
>> Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml | 3 ++-
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> index 47e6f36b7637..9b141a409191 100644
>> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> @@ -202,6 +202,7 @@ patternProperties:
>> for the functioning of the current device at the current OPP (where
>> this property is present).
>> $ref: /schemas/types.yaml#/definitions/phandle-array
>> + maxItems: 1
>
> I may not under this property very well. What exactly does this line
> say ? Asking as required-properties can have an array of phandles as
> well.
>
It says we can have maximum one item in "required-opps" in "opp" node
and you are right that we could have here more. I'll fix it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] dt-bindings: opp: constrain required-opps
2023-01-20 6:27 ` Krzysztof Kozlowski
@ 2023-01-20 6:41 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 6:41 UTC (permalink / raw)
To: Viresh Kumar
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Viresh Kumar,
Nishanth Menon, Ilia Lin, Vladimir Zapolskiy, linux-arm-msm,
linux-clk, devicetree, linux-kernel, linux-pm
On 20/01/2023 07:27, Krzysztof Kozlowski wrote:
> On 20/01/2023 05:38, Viresh Kumar wrote:
>> On 19-01-23, 14:00, Krzysztof Kozlowski wrote:
>>> Be specific how many required-opps are allowed.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> ---
>>>
>>> This change is independent, although logically is connected with my
>>> dtschema pull:
>>> https://github.com/devicetree-org/dt-schema/pull/95
>>> ---
>>> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 1 +
>>> Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml | 3 ++-
>>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>>> index 47e6f36b7637..9b141a409191 100644
>>> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>>> @@ -202,6 +202,7 @@ patternProperties:
>>> for the functioning of the current device at the current OPP (where
>>> this property is present).
>>> $ref: /schemas/types.yaml#/definitions/phandle-array
>>> + maxItems: 1
>>
>> I may not under this property very well. What exactly does this line
>> say ? Asking as required-properties can have an array of phandles as
>> well.
>>
>
> It says we can have maximum one item in "required-opps" in "opp" node
> and you are right that we could have here more. I'll fix it.
OK, this patch can be actually dropped. The dtschema will bring
constraints of 1-8 number of items here, which should cover all cases
for both opps - v2 and v2-kryo-cpu.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: constrain required-opps
2023-01-19 13:00 [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: constrain required-opps Krzysztof Kozlowski
2023-01-19 13:00 ` [PATCH 2/2] dt-bindings: opp: " Krzysztof Kozlowski
@ 2023-01-20 22:15 ` Stephen Boyd
2023-01-21 18:59 ` Krzysztof Kozlowski
2023-01-23 21:18 ` Rob Herring
2 siblings, 1 reply; 9+ messages in thread
From: Stephen Boyd @ 2023-01-20 22:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Ilia Lin, Konrad Dybcio,
Krzysztof Kozlowski, Krzysztof Kozlowski, Michael Turquette,
Nishanth Menon, Rob Herring, Viresh Kumar, Vladimir Zapolskiy,
devicetree, linux-arm-msm, linux-clk, linux-kernel, linux-pm
Cc: Krzysztof Kozlowski
Quoting Krzysztof Kozlowski (2023-01-19 05:00:27)
> Be specific how many required-opps are allowed.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> This change is independent, although logically is connected with my
> dtschema pull:
> https://github.com/devicetree-org/dt-schema/pull/95
Do you want to take it through dt tree?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: constrain required-opps
2023-01-20 22:15 ` [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: " Stephen Boyd
@ 2023-01-21 18:59 ` Krzysztof Kozlowski
2023-01-25 20:32 ` Stephen Boyd
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-21 18:59 UTC (permalink / raw)
To: Stephen Boyd, Andy Gross, Bjorn Andersson, Ilia Lin,
Konrad Dybcio, Krzysztof Kozlowski, Michael Turquette,
Nishanth Menon, Rob Herring, Viresh Kumar, Vladimir Zapolskiy,
devicetree, linux-arm-msm, linux-clk, linux-kernel, linux-pm
On 20/01/2023 23:15, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2023-01-19 05:00:27)
>> Be specific how many required-opps are allowed.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> This change is independent, although logically is connected with my
>> dtschema pull:
>> https://github.com/devicetree-org/dt-schema/pull/95
>
> Do you want to take it through dt tree?
I think it would be better if you take it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: constrain required-opps
2023-01-21 18:59 ` Krzysztof Kozlowski
@ 2023-01-25 20:32 ` Stephen Boyd
0 siblings, 0 replies; 9+ messages in thread
From: Stephen Boyd @ 2023-01-25 20:32 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Ilia Lin, Konrad Dybcio,
Krzysztof Kozlowski, Krzysztof Kozlowski, Michael Turquette,
Nishanth Menon, Rob Herring, Viresh Kumar, Vladimir Zapolskiy,
devicetree, linux-arm-msm, linux-clk, linux-kernel, linux-pm
Quoting Krzysztof Kozlowski (2023-01-21 10:59:21)
> On 20/01/2023 23:15, Stephen Boyd wrote:
> > Quoting Krzysztof Kozlowski (2023-01-19 05:00:27)
> >> Be specific how many required-opps are allowed.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >> ---
> >>
> >> This change is independent, although logically is connected with my
> >> dtschema pull:
> >> https://github.com/devicetree-org/dt-schema/pull/95
> >
> > Do you want to take it through dt tree?
>
> I think it would be better if you take it.
>
Ok, applied to clk-next.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: constrain required-opps
2023-01-19 13:00 [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: constrain required-opps Krzysztof Kozlowski
2023-01-19 13:00 ` [PATCH 2/2] dt-bindings: opp: " Krzysztof Kozlowski
2023-01-20 22:15 ` [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: " Stephen Boyd
@ 2023-01-23 21:18 ` Rob Herring
2 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2023-01-23 21:18 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Stephen Boyd, Krzysztof Kozlowski,
Viresh Kumar, linux-kernel, Rob Herring, Vladimir Zapolskiy,
devicetree, linux-pm, Ilia Lin, linux-clk, Nishanth Menon,
Andy Gross, linux-arm-msm, Michael Turquette
On Thu, 19 Jan 2023 14:00:27 +0100, Krzysztof Kozlowski wrote:
> Be specific how many required-opps are allowed.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> This change is independent, although logically is connected with my
> dtschema pull:
> https://github.com/devicetree-org/dt-schema/pull/95
> ---
> Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-01-25 20:32 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-19 13:00 [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: constrain required-opps Krzysztof Kozlowski
2023-01-19 13:00 ` [PATCH 2/2] dt-bindings: opp: " Krzysztof Kozlowski
2023-01-20 4:38 ` Viresh Kumar
2023-01-20 6:27 ` Krzysztof Kozlowski
2023-01-20 6:41 ` Krzysztof Kozlowski
2023-01-20 22:15 ` [PATCH 1/2] dt-bindings: clock: qcom,sm8450-camcc: " Stephen Boyd
2023-01-21 18:59 ` Krzysztof Kozlowski
2023-01-25 20:32 ` Stephen Boyd
2023-01-23 21:18 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).