From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 3/3] soc: qcom: Add AOSS QMP genpd provider
Date: Tue, 27 Nov 2018 16:20:37 +0530 [thread overview]
Message-ID: <e8b74746-23a4-67fe-9b6d-060f77a0a043@codeaurora.org> (raw)
In-Reply-To: <20181112080557.22698-4-bjorn.andersson@linaro.org>
Hi Bjorn,
On 11/12/2018 1:35 PM, Bjorn Andersson wrote:
> The AOSS QMP genpd provider implements control over power-related
> resources related to low-power state associated with the remoteprocs in
> the system as well as control over a set of clocks related to debug
> hardware in the SoC.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
One more issue is that amba bus probe fails and coresight(qdss) does not
work with these because of clocks being modeled as power-domain.
Below is the log snippet:
[ 4.580715] coresight-etm4x: probe of 7040000.etm failed with error -2
[ 4.588087] coresight-etm4x: probe of 7140000.etm failed with error -2
[ 4.595407] coresight-etm4x: probe of 7240000.etm failed with error -2
[ 4.602796] coresight-etm4x: probe of 7340000.etm failed with error -2
[ 4.610108] coresight-etm4x: probe of 7440000.etm failed with error -2
[ 4.617453] coresight-etm4x: probe of 7540000.etm failed with error -2
[ 4.624831] coresight-etm4x: probe of 7640000.etm failed with error -2
[ 4.632190] coresight-etm4x: probe of 7740000.etm failed with error -2
This is because Amba bus probe has amba_get_enable_pclk() which gets
apb_pclk and returns error if it can't get that clk.
Just for testing, I ignored amba_get_enable_pclk() in probe and
coresight seems to work fine.
Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
prev parent reply other threads:[~2018-11-27 10:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 8:05 [PATCH 0/3] Qualcomm AOSS QMP side channel binding and driver Bjorn Andersson
2018-11-12 8:05 ` [PATCH 1/3] dt-bindings: soc: qcom: Add AOSS QMP binding Bjorn Andersson
2018-12-03 23:51 ` Rob Herring
2018-12-10 23:56 ` Doug Anderson
2018-11-12 8:05 ` [PATCH 2/3] soc: qcom: Add AOSS QMP communication driver Bjorn Andersson
2018-11-20 12:22 ` Arun Kumar Neelakantam
2018-12-26 20:28 ` Bjorn Andersson
2019-01-03 17:48 ` Arun Kumar Neelakantam
2018-11-12 8:05 ` [PATCH 3/3] soc: qcom: Add AOSS QMP genpd provider Bjorn Andersson
2018-11-27 3:31 ` Sai Prakash Ranjan
2018-12-26 20:30 ` Bjorn Andersson
2018-11-27 10:50 ` Sai Prakash Ranjan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8b74746-23a4-67fe-9b6d-060f77a0a043@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).