* [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15
@ 2021-09-27 11:45 Olivier Moysan
2021-09-29 11:18 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Olivier Moysan @ 2021-09-27 11:45 UTC (permalink / raw)
To: Alexandre Torgue, Marek Vasut, Maxime Coquelin, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-stm32,
Olivier Moysan
Fix SAI2B pin muxing for AV96 board on STM32MP15.
The label "sai2a-4" is defined twice. Change redundant label to "sai2b-4".
Fixes: dcf185ca8175 ("ARM: dts: stm32: Add alternate pinmux for SAI2 pins on stm32mp15")
Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
---
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
index 5b60ecbd718f..b9cc9e0dd4fc 100644
--- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
@@ -1235,7 +1235,7 @@
};
};
- sai2b_pins_c: sai2a-4 {
+ sai2b_pins_c: sai2b-4 {
pins1 {
pinmux = <STM32_PINMUX('F', 11, AF10)>; /* SAI2_SD_B */
bias-disable;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15
2021-09-27 11:45 [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15 Olivier Moysan
@ 2021-09-29 11:18 ` Marek Vasut
2021-09-30 8:47 ` Alexandre TORGUE
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2021-09-29 11:18 UTC (permalink / raw)
To: Olivier Moysan, Alexandre Torgue, Maxime Coquelin, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-stm32
On 9/27/21 1:45 PM, Olivier Moysan wrote:
> Fix SAI2B pin muxing for AV96 board on STM32MP15.
> The label "sai2a-4" is defined twice. Change redundant label to "sai2b-4".
>
> Fixes: dcf185ca8175 ("ARM: dts: stm32: Add alternate pinmux for SAI2 pins on stm32mp15")
>
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> index 5b60ecbd718f..b9cc9e0dd4fc 100644
> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> @@ -1235,7 +1235,7 @@
> };
> };
>
> - sai2b_pins_c: sai2a-4 {
> + sai2b_pins_c: sai2b-4 {
> pins1 {
> pinmux = <STM32_PINMUX('F', 11, AF10)>; /* SAI2_SD_B */
> bias-disable;
This mp1 pinmuxing is a total mess, sigh.
Can you please also fix sai1a-4 and sai1a-5, which should really be
sai1a-2 and sai1a-sleep-2 ? Same as the sai2b-4 and sai2b-5 should be
sai2b-2 and sai2b-sleep-2 .
With that, it would be perfect, thank you.
[...]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15
2021-09-29 11:18 ` Marek Vasut
@ 2021-09-30 8:47 ` Alexandre TORGUE
2021-09-30 10:26 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Alexandre TORGUE @ 2021-09-30 8:47 UTC (permalink / raw)
To: Marek Vasut, Olivier Moysan, Maxime Coquelin, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-stm32
Hi Marek
On 9/29/21 1:18 PM, Marek Vasut wrote:
> On 9/27/21 1:45 PM, Olivier Moysan wrote:
>> Fix SAI2B pin muxing for AV96 board on STM32MP15.
>> The label "sai2a-4" is defined twice. Change redundant label to
>> "sai2b-4".
>>
>> Fixes: dcf185ca8175 ("ARM: dts: stm32: Add alternate pinmux for SAI2
>> pins on stm32mp15")
>>
>> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
>> ---
>> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>> b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>> index 5b60ecbd718f..b9cc9e0dd4fc 100644
>> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>> @@ -1235,7 +1235,7 @@
>> };
>> };
>> - sai2b_pins_c: sai2a-4 {
>> + sai2b_pins_c: sai2b-4 {
>> pins1 {
>> pinmux = <STM32_PINMUX('F', 11, AF10)>; /* SAI2_SD_B */
>> bias-disable;
>
> This mp1 pinmuxing is a total mess, sigh.
What is the issue here ?
> Can you please also fix sai1a-4 and sai1a-5, which should really be
> sai1a-2 and sai1a-sleep-2 ? Same as the sai2b-4 and sai2b-5 should be
> sai2b-2 and sai2b-sleep-2 .
>
> With that, it would be perfect, thank you.
>
> [...]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15
2021-09-30 8:47 ` Alexandre TORGUE
@ 2021-09-30 10:26 ` Marek Vasut
2021-09-30 15:05 ` Alexandre TORGUE
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2021-09-30 10:26 UTC (permalink / raw)
To: Alexandre TORGUE, Olivier Moysan, Maxime Coquelin, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-stm32
On 9/30/21 10:47 AM, Alexandre TORGUE wrote:
> Hi Marek
>
> On 9/29/21 1:18 PM, Marek Vasut wrote:
>> On 9/27/21 1:45 PM, Olivier Moysan wrote:
>>> Fix SAI2B pin muxing for AV96 board on STM32MP15.
>>> The label "sai2a-4" is defined twice. Change redundant label to
>>> "sai2b-4".
>>>
>>> Fixes: dcf185ca8175 ("ARM: dts: stm32: Add alternate pinmux for SAI2
>>> pins on stm32mp15")
>>>
>>> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
>>> ---
>>> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>> b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>> index 5b60ecbd718f..b9cc9e0dd4fc 100644
>>> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>> @@ -1235,7 +1235,7 @@
>>> };
>>> };
>>> - sai2b_pins_c: sai2a-4 {
>>> + sai2b_pins_c: sai2b-4 {
>>> pins1 {
>>> pinmux = <STM32_PINMUX('F', 11, AF10)>; /* SAI2_SD_B */
>>> bias-disable;
>>
>> This mp1 pinmuxing is a total mess, sigh.
>
> What is the issue here ?
The same-old discussion about where to place the pinmux nodes, whether
we should have these clusters of pre-defined options in ...pinctrl.dtsi,
or whether we should do more nxp-like per-board configuration.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15
2021-09-30 10:26 ` Marek Vasut
@ 2021-09-30 15:05 ` Alexandre TORGUE
2021-09-30 15:13 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Alexandre TORGUE @ 2021-09-30 15:05 UTC (permalink / raw)
To: Marek Vasut, Olivier Moysan, Maxime Coquelin, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-stm32
On 9/30/21 12:26 PM, Marek Vasut wrote:
> On 9/30/21 10:47 AM, Alexandre TORGUE wrote:
>> Hi Marek
>>
>> On 9/29/21 1:18 PM, Marek Vasut wrote:
>>> On 9/27/21 1:45 PM, Olivier Moysan wrote:
>>>> Fix SAI2B pin muxing for AV96 board on STM32MP15.
>>>> The label "sai2a-4" is defined twice. Change redundant label to
>>>> "sai2b-4".
>>>>
>>>> Fixes: dcf185ca8175 ("ARM: dts: stm32: Add alternate pinmux for SAI2
>>>> pins on stm32mp15")
>>>>
>>>> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
>>>> ---
>>>> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>> b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>> index 5b60ecbd718f..b9cc9e0dd4fc 100644
>>>> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>> @@ -1235,7 +1235,7 @@
>>>> };
>>>> };
>>>> - sai2b_pins_c: sai2a-4 {
>>>> + sai2b_pins_c: sai2b-4 {
>>>> pins1 {
>>>> pinmux = <STM32_PINMUX('F', 11, AF10)>; /* SAI2_SD_B */
>>>> bias-disable;
>>>
>>> This mp1 pinmuxing is a total mess, sigh.
>>
>> What is the issue here ?
>
> The same-old discussion about where to place the pinmux nodes, whether
> we should have these clusters of pre-defined options in ...pinctrl.dtsi,
> or whether we should do more nxp-like per-board configuration.
ok it's a bit more precise. Honestly I don't understand why the current
topology is an issue here. Maybe pinctrl SAI nodes names are not well
chosen or are not enough explicit. Concerning our topology and the NXP
ones both exists and both have advantages and drawbacks. For ST boards
(DK/EV) we want to keep all configs in the same place.
As I prefer to not re open this topic again and again, feel free to add
your pin config in your dts board file, I'll accept it.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15
2021-09-30 15:05 ` Alexandre TORGUE
@ 2021-09-30 15:13 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2021-09-30 15:13 UTC (permalink / raw)
To: Alexandre TORGUE, Olivier Moysan, Maxime Coquelin, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-stm32
On 9/30/21 5:05 PM, Alexandre TORGUE wrote:
> On 9/30/21 12:26 PM, Marek Vasut wrote:
>> On 9/30/21 10:47 AM, Alexandre TORGUE wrote:
>>> Hi Marek
>>>
>>> On 9/29/21 1:18 PM, Marek Vasut wrote:
>>>> On 9/27/21 1:45 PM, Olivier Moysan wrote:
>>>>> Fix SAI2B pin muxing for AV96 board on STM32MP15.
>>>>> The label "sai2a-4" is defined twice. Change redundant label to
>>>>> "sai2b-4".
>>>>>
>>>>> Fixes: dcf185ca8175 ("ARM: dts: stm32: Add alternate pinmux for
>>>>> SAI2 pins on stm32mp15")
>>>>>
>>>>> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
>>>>> ---
>>>>> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>>> b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>>> index 5b60ecbd718f..b9cc9e0dd4fc 100644
>>>>> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>>> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
>>>>> @@ -1235,7 +1235,7 @@
>>>>> };
>>>>> };
>>>>> - sai2b_pins_c: sai2a-4 {
>>>>> + sai2b_pins_c: sai2b-4 {
>>>>> pins1 {
>>>>> pinmux = <STM32_PINMUX('F', 11, AF10)>; /* SAI2_SD_B */
>>>>> bias-disable;
>>>>
>>>> This mp1 pinmuxing is a total mess, sigh.
>>>
>>> What is the issue here ?
>>
>> The same-old discussion about where to place the pinmux nodes, whether
>> we should have these clusters of pre-defined options in
>> ...pinctrl.dtsi, or whether we should do more nxp-like per-board
>> configuration.
>
> ok it's a bit more precise. Honestly I don't understand why the current
> topology is an issue here. Maybe pinctrl SAI nodes names are not well
> chosen or are not enough explicit. Concerning our topology and the NXP
> ones both exists and both have advantages and drawbacks. For ST boards
> (DK/EV) we want to keep all configs in the same place.
>
> As I prefer to not re open this topic again and again, feel free to add
> your pin config in your dts board file, I'll accept it.
Yes, let's not reopen it. I'm sorry if my grumbling came across as too
strong.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-30 15:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-27 11:45 [PATCH 1/1] ARM: dts: stm32: fix AV96 board SAI2B pin muxing on stm32mp15 Olivier Moysan
2021-09-29 11:18 ` Marek Vasut
2021-09-30 8:47 ` Alexandre TORGUE
2021-09-30 10:26 ` Marek Vasut
2021-09-30 15:05 ` Alexandre TORGUE
2021-09-30 15:13 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).