From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD1BC433EF for ; Thu, 26 May 2022 06:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346206AbiEZGtp (ORCPT ); Thu, 26 May 2022 02:49:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242922AbiEZGto (ORCPT ); Thu, 26 May 2022 02:49:44 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 567EB34BA3 for ; Wed, 25 May 2022 23:49:43 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id i40so675766eda.7 for ; Wed, 25 May 2022 23:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=7Bp9SA/1hFvtEI6hsrX+GVTXLacAaxb75saSLRSbPUs=; b=lZ0UFWMJZR/ScahCDhnrsdiqEMBsXhaUmxwPQYz8kGSkmNB/cfqAcxnwTVkp9xj0aE lsCoXp+eBgAG94q60rWQbm2Ev46NKSs7L0YuVDnsOuzPOSZw4gGFoRmjwrwitLfc/Q1u th3CE0lwu0KKph3kbzIli9VSAOxfe3FBTYhkQfWCArBTLj/bSslh3I5HWo53/4LUlp2Y EFr6Ux9jj1yIdsZLQ2Z0OF4eeKYkdllzrL3pr3b5ZFiR05utU1Q22S/gN01NaCibu8uA QiX4cooIXHCpWZc2KVRtRA0YzG91KtsCjTK6OcNFkVXfJD9Gs0VagoIP14zE/x1qcvgX f50Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7Bp9SA/1hFvtEI6hsrX+GVTXLacAaxb75saSLRSbPUs=; b=Tnu2L1ya0MqXo6IG7FMdyVbfQWywVw9wDkbsqmArKKCb3iwhwliY4KKO9GPzdzTqNj pzuauKJdel6jResFlKn+zCKFvNM3Gg424fO6GRtPUwC0fyFuJoJoRH2RSwWceCgKhUEo IIuhJZ18B5/DYzFvWaZp/bCJ0CReNvWTfYDvpZdwu4LIm+yxLQBYgxUM+UUhhLRoH7eA h9S/E0bXV699rk0zf7HqZHuYqRCFRAT6PwWpZUFUv74wZdOxq/5cZCjv83US0qJbWqkg KwmzItAydyYGR0Peg+WyFY2ZP68tffYgP0qMrakXxWv4tOCD8l7MsdiaYKpDvlKCONbc Pk5w== X-Gm-Message-State: AOAM532Qpmrfzzutl+WXhZWp1cEubo3vCuZxs7rxCw6AVMYt8lFsrL3x QPoU3XHapS3w3dMAkHzLunx3Bg== X-Google-Smtp-Source: ABdhPJwr6AzAilZdcZEXaEVY/WvgakJfBGOFvOc7ZLnxseNZb9svTt9d2Rn3vt0YkLTvjnYO5aqOqg== X-Received: by 2002:aa7:c4d0:0:b0:42a:ce47:e9c5 with SMTP id p16-20020aa7c4d0000000b0042ace47e9c5mr37950139edr.224.1653547781831; Wed, 25 May 2022 23:49:41 -0700 (PDT) Received: from [192.168.0.177] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id kq21-20020a170906abd500b006f3ef214e0csm225570ejb.114.2022.05.25.23.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 23:49:41 -0700 (PDT) Message-ID: Date: Thu, 26 May 2022 08:49:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Mark Brown Cc: kernel@collabora.com, AngeloGioacchino Del Regno , Jiaxin Yu , Krzysztof Kozlowski , Liam Girdwood , Matthias Brugger , Rob Herring , Shane Chien , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20220509205847.607076-1-nfraprado@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20220509205847.607076-1-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/05/2022 22:58, Nícolas F. R. A. Prado wrote: > The Mediatek AFE PCM controller for MT8192 allows two I2S interfaces to > share the same clock and act as a single interface with both input and > output. Add patterns for these properties in the dt-binding. The > property is split into two patterns in order to allow all valid > interface pairings. > > Signed-off-by: Nícolas F. R. A. Prado > > --- > The series from v1 of this patch was merged although some changes were > still needed in this patch, so the v1 of this patch was reverted [1] and > this standalone commit addresses the feedback from v1 and readds the > property. > > [1] https://lore.kernel.org/all/20220509185625.580811-1-nfraprado@collabora.com > > v1: https://lore.kernel.org/all/20220429203039.2207848-2-nfraprado@collabora.com/ > > Changes in v2: > - Added "mediatek," prefix to property > - Rewrote and added more information to property description > - Split into two patterns to validate that output-input pairings are > done > > .../bindings/sound/mt8192-afe-pcm.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml > index 7a25bc9b8060..2abf43c6c2c3 100644 > --- a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml > +++ b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml > @@ -54,6 +54,22 @@ properties: > - const: aud_infra_clk > - const: aud_infra_26m_clk > > +patternProperties: > + "^mediatek,i2s[13579]-share$": > + description: > + Each I2S interface has a single data line, input if its index is even or > + output if the index is odd. An input and an output I2S interface can be > + used together as if they were a single I2S interface with both input and > + output data lines by sharing the same clock. This property represents this > + pairing. The value should be the name of the interface whose clock is > + used, and the property name the other interface that depends on this > + clock. > + pattern: "^I2S[0268]$" > + > + "^mediatek,i2s[0268]-share$": > + description: Same as above. > + pattern: "^I2S[13579]$" Rob's question is still valid - why these are not phandles? In any case you miss $ref. Best regards, Krzysztof