From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bean Huo (beanhuo)" Subject: RE: [PATCH 4/5] mtd: nand: add support for Micron on-die ECC Date: Thu, 13 Apr 2017 14:08:17 +0000 Message-ID: References: <538805ebf8e64015a8b833de755652b3@SIWEX5A.sing.micron.com> <8a171dacd20c45bd8285ecc5dbe8854a@SIWEX5A.sing.micron.com> <20170322144507.4d80d2cc@bbrezillon> <0dccc0abcf234e98be6d340027cf1a30@SIWEX5A.sing.micron.com> <20170322155216.319efc3e@bbrezillon> <414dd35931814ce38381a251917ad79f@SIWEX5A.sing.micron.com> <20170411145102.563fa388@bbrezillon> <90300f14cd2a4ae6967d8be0f7dff4e9@SIWEX5A.sing.micron.com> <20170411173051.7aafb717@bbrezillon> <5a96e73ef951414a82c01b67088b24d3@SIWEX5A.sing.micron.com> <20170412090313.539f81b2@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20170412090313.539f81b2@bbrezillon> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Boris Brezillon Cc: Thomas Petazzoni , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "pawel.moll-5wv7dgnIgG8@public.gmane.org" , Campbell , "richard-/L3Ra7n9ekc@public.gmane.org" , Mark Rutland , "marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , Rob Herring , "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , Cyrille Pitchen , "computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi, Boris >One last question. Is it dangerous to call >SET_FEATURE(disable/enable-ECC) on a NAND that has ECC enabled by default? >We could use that to detect whether on-die ECC can be turned off or not and >adjust the chip->ecc init steps accordingly. > No any danger exist, NAND just gives response that set feature failed. Also, it is a good solution to detect whether on-die ECC support or not through SET_FEATURE(disable/enable-ECC) successful or not. >Thanks, > >Boris Happy Easter! //Bean -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html