From: <Claudiu.Beznea@microchip.com>
To: <krzysztof.kozlowski@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<daniel.lezcano@linaro.org>, <tglx@linutronix.de>,
<wim@linux-watchdog.org>, <linux@roeck-us.net>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: timer: atmel,at91sam9260-pit: convert to yaml
Date: Fri, 9 Jun 2023 12:09:58 +0000 [thread overview]
Message-ID: <e8fd0340-da21-0cf7-7ec3-a3f278716c15@microchip.com> (raw)
In-Reply-To: <9e4a0756-8b42-81a7-5b5c-60c0ebea0d7f@linaro.org>
On 09.06.2023 13:48, Krzysztof Kozlowski wrote:
[ ... ]
>
>>>> + properties:
>>>> + clocks:
>>>> + minItems: 2
>>>> + clock-names:
>>>> + items:
>>>> + - const: pclk
>>>> + - const: gclk
>>>
>>> interrupts? They are still required, so why no description here?
>>
>> It was here in the previous versions but Conor suggested to remove it as it
>> was nothing specific about this description. For the if-then branch I kept
>> it to specify that the interrupt is share with other devices. In this
>> branch the interrupt is only for the timer itself. With this, would you
>> still prefer to add it back?
>
> I just don't understand why interrupts are in one arm of the if: and not
> in the other.
>
As previously mentioned, Conor suggested to have it like this.
next prev parent reply other threads:[~2023-06-09 12:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 9:07 [PATCH v3 0/3] dt-bindings: timer: Microchip AT91 convert to YAML Claudiu Beznea
2023-05-30 9:07 ` [PATCH v3 1/3] dt-bindings: timer: atmel,at91sam9260-pit: convert to yaml Claudiu Beznea
2023-05-31 8:55 ` Krzysztof Kozlowski
2023-06-09 10:22 ` Claudiu.Beznea
2023-06-09 10:48 ` Krzysztof Kozlowski
2023-06-09 12:09 ` Claudiu.Beznea [this message]
2023-06-09 12:18 ` Krzysztof Kozlowski
2023-06-09 12:21 ` Claudiu.Beznea
2023-05-30 9:07 ` [PATCH v3 2/3] dt-bindings: watchdog: atmel,at91rm9200-wdt: " Claudiu Beznea
2023-05-31 8:56 ` Krzysztof Kozlowski
2023-05-30 9:07 ` [PATCH v3 3/3] dt-bindings: timer: atmel,at91rm9200-st: " Claudiu Beznea
2023-05-31 8:58 ` Krzysztof Kozlowski
2023-05-30 12:29 ` [PATCH v3 0/3] dt-bindings: timer: Microchip AT91 convert to YAML Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8fd0340-da21-0cf7-7ec3-a3f278716c15@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).