From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Rob Herring <robh@kernel.org>, Grant Likely <grant.likely@arm.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Kumar Gala <kumar.gala@linaro.org>,
devicetree@vger.kernel.org, devicetree-spec@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Frank Rowand <frowand.list@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: DT case sensitivity
Date: Thu, 23 Aug 2018 21:47:30 +1000 [thread overview]
Message-ID: <e9009f6dd3aded2b9aa735973f4eed8386dd9afb.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAL_Jsq+1T8k5mtc-DgDBtX3Qco9sQG9RWv6FTZ8NXppNbNg3Ww@mail.gmail.com>
On Thu, 2018-08-23 at 06:43 -0500, Rob Herring wrote:
> On Thu, Aug 23, 2018 at 4:02 AM Grant Likely <grant.likely@arm.com> wrote:
> >
> >
> > What problem are you trying to solve?
>
> I'm looking at removing device_node.name and using full_name instead
> (which now is only the local node name plus unit-address). This means
> replacing of_node_cmp() (and still some strcmp) calls in a lot of
> places. I need to use either strncmp or strncasecmp instead.
>
> > I would think making everything
> > case insensitive would be the direction to go if you do anything. Least
> > possibility of breaking existing platforms in that scenario.
>
> Really? Even if all the "new" arches are effectively case sensitive?
> Anything using dtc and libfdt are (and json-schema certainly will be).
> But I frequently say the kernel's job is not DT validation, so you
> pass crap in, you get undefined results.
I tend to agree with Grant. Let's put it this way:
What is the drawback of being case insensitive ?
Do we expect that there exist a case where we will want to distinguish
between nodes that have the same name with a different case ?
If not, I don't see the point of being strict about it.
Cheers,
Ben.
next prev parent reply other threads:[~2018-08-23 11:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 0:47 DT case sensitivity Rob Herring
2018-08-23 1:03 ` Benjamin Herrenschmidt
2018-08-23 1:26 ` Rob Herring
2018-08-23 1:29 ` Benjamin Herrenschmidt
2018-08-23 9:02 ` Grant Likely
2018-08-23 11:43 ` Rob Herring
2018-08-23 11:47 ` Benjamin Herrenschmidt [this message]
2018-08-23 11:56 ` Grant Likely
2018-08-23 12:08 ` Rob Herring
2018-08-23 12:48 ` Grant Likely
2018-08-23 12:36 ` Segher Boessenkool
2018-08-24 15:14 ` Rob Herring
2018-08-24 16:52 ` Segher Boessenkool
2018-08-23 12:19 ` Segher Boessenkool
2018-08-23 21:49 ` Benjamin Herrenschmidt
2018-08-24 5:39 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9009f6dd3aded2b9aa735973f4eed8386dd9afb.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-spec@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@arm.com \
--cc=kumar.gala@linaro.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).