From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: DT case sensitivity Date: Thu, 23 Aug 2018 21:47:30 +1000 Message-ID: References: <3335cff2cc999c1dda58d75949ab3d12185fca79.camel@kernel.crashing.org> <18175413a0148f7859ab36ed9715dce7a598f318.camel@kernel.crashing.org> <13bf5b39-0461-351e-57e3-60264eaa374d@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Rob Herring , Grant Likely Cc: Stephen Rothwell , Kumar Gala , devicetree@vger.kernel.org, devicetree-spec@vger.kernel.org, linuxppc-dev , Frank Rowand , David Gibson List-Id: devicetree@vger.kernel.org On Thu, 2018-08-23 at 06:43 -0500, Rob Herring wrote: > On Thu, Aug 23, 2018 at 4:02 AM Grant Likely wrote: > > > > > > What problem are you trying to solve? > > I'm looking at removing device_node.name and using full_name instead > (which now is only the local node name plus unit-address). This means > replacing of_node_cmp() (and still some strcmp) calls in a lot of > places. I need to use either strncmp or strncasecmp instead. > > > I would think making everything > > case insensitive would be the direction to go if you do anything. Least > > possibility of breaking existing platforms in that scenario. > > Really? Even if all the "new" arches are effectively case sensitive? > Anything using dtc and libfdt are (and json-schema certainly will be). > But I frequently say the kernel's job is not DT validation, so you > pass crap in, you get undefined results. I tend to agree with Grant. Let's put it this way: What is the drawback of being case insensitive ? Do we expect that there exist a case where we will want to distinguish between nodes that have the same name with a different case ? If not, I don't see the point of being strict about it. Cheers, Ben.