From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v9 3/5] ARM: dts: Renesas R9A06G032 base device tree file Date: Fri, 22 Jun 2018 13:25:56 +0100 Message-ID: References: <1528973829-25493-1-git-send-email-michel.pollet@bp.renesas.com> <1528973829-25493-4-git-send-email-michel.pollet@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven , Michel Pollet Cc: Linux-Renesas , Simon Horman , Phil Edworthy , Michel Pollet , Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Geert Uytterhoeven , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org On 22/06/18 13:14, Geert Uytterhoeven wrote: > Hi Michel, > > CC MarcZ > > On Thu, Jun 14, 2018 at 1:02 PM Michel Pollet > wrote: >> This adds the Renesas R9A06G032 bare bone support. >> >> This currently only handles the SYSCTRL block note, >> generic parts (gic, architected timer) and a UART. >> >> Signed-off-by: Michel Pollet > >> --- /dev/null >> +++ b/arch/arm/boot/dts/r9a06g032.dtsi > >> + timer { >> + compatible = "arm,cortex-a7-timer", > > Checkpatch says: > WARNING: DT compatible string "arm,cortex-a7-timer" appears > un-documented -- check ./Documentation/devicetree/bindings/ > >> + "arm,armv7-timer"; > > Documentation/devicetree/bindings/arm/arch_timer.txt says: > > compatible should at least contain "arm,armv7-timer" > > but fails to list other possible values? The idea is that you could add something useful that matches your CPU. Adding new CPU types in the binding seems to be a never ending battle... > >> + interrupt-parent = <&gic>; >> + arm,cpu-registers-not-fw-configured; Really? :-( Thanks, M. -- Jazz is not dead. It just smells funny...