From: Krzysztof Kozlowski <krzk@kernel.org>
To: Emil Gedenryd <emil.gedenryd@axis.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andreas Dannenberg <dannenberg@ti.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH 3/3] dt-bindings: iio: light: opt3001: add compatible for opt3002
Date: Thu, 5 Sep 2024 12:38:04 +0200 [thread overview]
Message-ID: <e912ca02-f06d-43da-92f4-f5611e08fb66@kernel.org> (raw)
In-Reply-To: <20240905-add_opt3002-v1-3-a5ae21b924fb@axis.com>
On 05/09/2024 12:20, Emil Gedenryd wrote:
> OPT3002 is a Light-to-Digital Sensor by TI with support for wide-range
> spectrum light.
> Add the compatible string of opt3002 to the existing list.
>
> Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com>
> ---
> Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> index 441e9343fc97..7a48a06968ca 100644
> --- a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> @@ -16,6 +16,7 @@ description: |
> properties:
> compatible:
> const: ti,opt3001
> + const: ti,opt3002
Never tested and obviously broken.
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-05 10:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 10:20 [PATCH 0/3] iio: light: opt3001: add support for TI's opt3002 light sensor Emil Gedenryd
2024-09-05 10:20 ` [PATCH 1/3] iio: light: opt3001: add missing full-scale range value Emil Gedenryd
2024-09-07 17:28 ` Jonathan Cameron
2024-09-09 7:15 ` Emil Gedenryd
2024-09-05 10:20 ` [PATCH 2/3] iio: light: opt3001: add support for TI's opt3002 light sensor Emil Gedenryd
2024-09-05 10:37 ` Krzysztof Kozlowski
2024-09-06 21:32 ` kernel test robot
2024-09-07 17:35 ` Jonathan Cameron
2024-09-09 7:54 ` Emil Gedenryd
2024-09-09 19:13 ` Jonathan Cameron
2024-09-13 7:18 ` Emil Gedenryd
2024-09-05 10:20 ` [PATCH 3/3] dt-bindings: iio: light: opt3001: add compatible for opt3002 Emil Gedenryd
2024-09-05 10:38 ` Krzysztof Kozlowski [this message]
2024-09-05 11:11 ` Rob Herring (Arm)
2024-09-05 10:38 ` [PATCH 0/3] iio: light: opt3001: add support for TI's opt3002 light sensor Krzysztof Kozlowski
2024-09-05 10:55 ` Emil Gedenryd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e912ca02-f06d-43da-92f4-f5611e08fb66@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dannenberg@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=emil.gedenryd@axis.com \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).