devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philipp Rossak <embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org,
	wens-jdAy2FN1RRM@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	knaack.h-Mmb7MZpHnFY@public.gmane.org,
	lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
	pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
	eugen.hristev-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org,
	rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	quentin.schulz-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org,
	geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org,
	lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org,
	icenowy-h8G6r0blFSE@public.gmane.org,
	arnd-r2nGTMty4D4@public.gmane.org,
	broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	arnaud.pouliquen-qxv4g6HH51o@public.gmane.org,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v3 21/30] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor
Date: Thu, 30 Aug 2018 22:00:36 +0200	[thread overview]
Message-ID: <e919cbdd-a874-4b46-a505-9412d093f54a@gmail.com> (raw)
In-Reply-To: <20180830162734.uq65l6ox6uwrmulo@core>

On 30.08.2018 18:27, Ondřej Jirman wrote:
>> +static int sun8i_h3_calibrate(struct sun4i_gpadc_iio *info)
>> +{
>> +//	regmap_write(info->regmap, SUNXI_THS_CDATA_0_1,
>> +//			info->calibration_data[0]);
>> +//	regmap_write(info->regmap, SUNXI_THS_CDATA_2_3,
>> +//			info->calibration_data[1]);
> This should probably be implemented, or left out completely.
> 
> regards,
>    o.
> 
Thanks you are right!
This should be implemented! I will fix this in the next version!

Thanks,
Philipp

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

  reply	other threads:[~2018-08-30 20:00 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 15:44 [PATCH v3 00/30] IIO-based thermal sensor driver for Allwinner H3 and A83T SoC Philipp Rossak
     [not found] ` <20180830154518.29507-1-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-30 15:44   ` [PATCH v3 01/30] mfd: Makefile: Remove build option for MFD:sun4i-gpadc Philipp Rossak
     [not found]     ` <20180830154518.29507-2-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  8:25       ` Maxime Ripard
2018-09-02 19:58         ` Jonathan Cameron
2018-08-30 15:44   ` [PATCH v3 02/30] mfd: Kconfig: Remove MFD_SUN4I_GPADC config option Philipp Rossak
2018-09-02 19:58     ` Jonathan Cameron
2018-08-30 15:44   ` [PATCH v3 03/30] iio: adc: Remove ID table Philipp Rossak
2018-08-30 15:44   ` [PATCH v3 04/30] iio: adc: Kconfig: Update Kconfig to new build options Philipp Rossak
     [not found]     ` <20180830154518.29507-5-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  8:32       ` Maxime Ripard
2018-08-30 15:44   ` [PATCH v3 05/30] iio: adc: move SUN4I_GPADC_CHANNEL define to header file Philipp Rossak
2018-09-02 20:01     ` Jonathan Cameron
2018-09-03 14:24       ` Philipp Rossak
2018-09-03 17:28         ` Jonathan Cameron
2018-08-30 15:44   ` [PATCH v3 06/30] iio: adc: remove ofnode options Philipp Rossak
2018-08-30 15:44   ` [PATCH v3 07/30] iio: adc: remove mfd_probe & sunwi_irq_init function Philipp Rossak
     [not found]     ` <20180830154518.29507-8-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  8:34       ` Maxime Ripard
2018-08-30 15:44   ` [PATCH v3 08/30] iio: adc: remove hwmon structure Philipp Rossak
     [not found]     ` <20180830154518.29507-9-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  8:34       ` Maxime Ripard
2018-08-30 15:44   ` [PATCH v3 09/30] iio: adc: Threat A33 as thermal sensor and remove non thermal sun4i channel Philipp Rossak
     [not found]     ` <20180830154518.29507-10-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-30 16:40       ` 'Ondřej Jirman' via linux-sunxi
2018-08-31  8:35       ` Maxime Ripard
2018-08-30 15:44   ` [PATCH v3 10/30] iio: adc: rework irq and adc_channel handling Philipp Rossak
     [not found]     ` <20180830154518.29507-11-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  8:44       ` Maxime Ripard
2018-08-30 15:44   ` [PATCH v3 11/30] iio: adc: add new compatibles Philipp Rossak
     [not found]     ` <20180830154518.29507-12-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  8:46       ` Maxime Ripard
2018-08-30 15:45   ` [PATCH v3 12/30] mfd: Remove old mfd driver & Move sun4i-gpadc.h to iio/adc/ Philipp Rossak
2018-08-30 15:45   ` [PATCH v3 13/30] arm: config: Enable SUN4I_GPADC in defconfig Philipp Rossak
2018-08-30 15:45   ` [PATCH v3 14/30] dt-bindings: update the Allwinner GPADC device tree binding for H3 & A83T Philipp Rossak
     [not found]     ` <20180830154518.29507-15-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  8:48       ` Maxime Ripard
2018-09-10 19:44         ` Rob Herring
2018-09-11  9:12           ` Maxime Ripard
2018-08-30 15:45   ` [PATCH v3 15/30] iio: adc: sun4i-gpadc-iio: rename A33-specified registers to contain A33 Philipp Rossak
2018-08-30 15:45   ` [PATCH v3 16/30] iio: adc: sun4i-gpadc-iio: rework: readout temp_data Philipp Rossak
     [not found]     ` <20180830154518.29507-17-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  8:50       ` Maxime Ripard
2018-08-30 15:45   ` [PATCH v3 17/30] iio: adc: sun4i-gpadc-iio: rework: support clocks and reset Philipp Rossak
     [not found]     ` <20180830154518.29507-18-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  9:03       ` Maxime Ripard
2018-08-30 15:45   ` [PATCH v3 18/30] iio: adc: sun4i-gpadc-iio: rework: support multiple sensors Philipp Rossak
     [not found]     ` <20180830154518.29507-19-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  9:05       ` Maxime Ripard
2018-09-02 20:11     ` Jonathan Cameron
2018-09-03 13:58       ` Philipp Rossak
2018-09-03 17:29         ` Jonathan Cameron
2018-08-30 15:45   ` [PATCH v3 19/30] iio: adc: sun4i-gpadc-iio: rework: support nvmem calibration data Philipp Rossak
     [not found]     ` <20180830154518.29507-20-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  9:07       ` Maxime Ripard
2018-08-30 15:45   ` [PATCH v3 20/30] iio: adc: sun4i-gpadc-iio: rework: device specific suspend & resume Philipp Rossak
     [not found]     ` <20180830154518.29507-21-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  9:09       ` Maxime Ripard
2018-08-31 12:05         ` Philipp Rossak
     [not found]           ` <ddd06c43-026e-2801-dc36-053d469e43f3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-03  9:44             ` Maxime Ripard
2018-08-30 15:45   ` [PATCH v3 21/30] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor Philipp Rossak
     [not found]     ` <20180830154518.29507-22-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-30 16:27       ` 'Ondřej Jirman' via linux-sunxi
2018-08-30 20:00         ` Philipp Rossak [this message]
     [not found]           ` <e919cbdd-a874-4b46-a505-9412d093f54a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-30 20:46             ` Philipp Rossak
2018-08-31  9:11       ` Maxime Ripard
2018-08-31  9:51         ` Icenowy Zheng
     [not found]           ` <f01ec2f202c7e2e5a7e0c822b2f9a8f0c55a9ea4.camel-h8G6r0blFSE@public.gmane.org>
2018-08-31 11:58             ` Philipp Rossak
2018-09-03 10:20             ` Maxime Ripard
2018-09-03 11:01               ` [linux-sunxi] " Icenowy Zheng
     [not found]                 ` <AFDFF5AB-8BF6-4461-A5C2-D628A2F22E2E-h8G6r0blFSE@public.gmane.org>
2018-09-05 14:58                   ` Maxime Ripard
2018-08-31 12:01         ` Philipp Rossak
2018-08-30 15:45   ` [PATCH v3 23/30] ARM: dts: sunxi-h3-h5: add support for the thermal sensor in H3 and H5 Philipp Rossak
2018-08-30 15:45   ` [PATCH v3 24/30] ARM: dts: sun8i: h3: add support for the thermal sensor in H3 Philipp Rossak
2018-08-30 15:45   ` [PATCH v3 25/30] ARM: dts: sun8i: h3: add thermal zone to H3 Philipp Rossak
     [not found]     ` <20180830154518.29507-26-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  9:14       ` Maxime Ripard
2018-08-30 15:45   ` [PATCH v3 26/30] ARM: dts: sun8i: h3: enable H3 sid controller Philipp Rossak
2018-08-30 15:45   ` [PATCH v3 27/30] ARM: dts: sun8i: h3: use calibration for ths Philipp Rossak
2018-09-04 16:46     ` Emmanuel Vadot
     [not found]       ` <20180904184623.e4386b8e6b657b1b25e90c09-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org>
2018-09-06 11:47         ` Philipp Rossak
     [not found]           ` <55579dd6-625d-e71b-1482-4592dccac665-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-06 11:51             ` Maxime Ripard
2018-09-06 12:04               ` [linux-sunxi] " Icenowy Zheng
2018-09-06 12:18                 ` Philipp Rossak
2019-02-19  7:54               ` Allwinner SID THS calibration data cell representation? Chen-Yu Tsai
2019-02-20 14:55                 ` Maxime Ripard
2019-02-21 10:10                 ` Emmanuel Vadot
     [not found]                 ` <CAGb2v65p0G83BVODsxxnXmiSCwuuwPFtY2k2ZV1F5xoFKrJjWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-02-25 20:37                   ` Philipp Rossak
2018-08-30 15:45   ` [PATCH v3 28/30] ARM: dts: sun8i: a83t: add support for the thermal sensor in A83T Philipp Rossak
2018-08-30 15:45   ` [PATCH v3 29/30] ARM: dts: sun8i: a83t: add thermal zone to A83T Philipp Rossak
2018-08-30 15:45 ` [PATCH v3 22/30] iio: adc: sun4i-gpadc-iio: add support for A83T thermal sensor Philipp Rossak
2018-08-30 15:45 ` [PATCH v3 30/30] ARM: sun8i: a83t: full range OPP tables and CPUfreq Philipp Rossak
     [not found]   ` <20180830154518.29507-31-embed3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-30 16:38     ` 'Ondřej Jirman' via linux-sunxi
2018-08-30 20:29       ` Philipp Rossak
2018-09-06  7:24     ` Quentin Schulz
2018-09-06 11:39       ` Philipp Rossak
     [not found]         ` <c76e71bc-6bc5-f73c-2c7a-c9315cf2da31-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-06 11:42           ` Maxime Ripard
2018-09-06 12:06             ` Quentin Schulz
2019-03-19 12:30 ` [PATCH v3 00/30] IIO-based thermal sensor driver for Allwinner H3 and A83T SoC Måns Rullgård
     [not found]   ` <yw1xzhpryrku.fsf-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>
2019-03-19 12:37     ` Maxime Ripard
2019-03-19 13:04       ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e919cbdd-a874-4b46-a505-9412d093f54a@gmail.com \
    --to=embed3d-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=arnaud.pouliquen-qxv4g6HH51o@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=eugen.hristev-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org \
    --cc=geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org \
    --cc=icenowy-h8G6r0blFSE@public.gmane.org \
    --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
    --cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \
    --cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
    --cc=quentin.schulz-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \
    --cc=rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).